AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity

GtkWidget: Fix motion event consumption detection for touch-only gestures

Browse Source 
If a GtkGestureSingle is set as touch-only, pointer events would be
discarded without giving an opportunity to the regular GtkGesture
handler to manage those.

Because the pointer events weren't actually managed by the gesture,
gtk_gesture_get_sequence_state() (rather unhelpfully here) will resort
to returning GTK_EVENT_SEQUENCE_NONE, which is in turn interpreted
by _gtk_widget_consumes_motion() as "may be handling the events for
this sequence", because gestures in this state presumably handle
the events, just that it's not "claimed" yet.

Instead, use gtk_gesture_handles_sequence(), which will perform the
expected check on the event sequence being managed, as we expect
here.
This commit is contained in:
Carlos Garnacho 2016-01-11 20:06:14 +01:00
parent 32eda187ee
commit 0167f7c65c
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
gtk/gtkwidget.c
View File

@ -17593,8 +17593,7 @@ _gtk_widget_consumes_motion (GtkWidget *widget,
if ((!GTK_IS_GESTURE_SINGLE (data->controller) ||
GTK_IS_GESTURE_DRAG (data->controller) ||
GTK_IS_GESTURE_SWIPE (data->controller)) &&
gtk_gesture_get_sequence_state (GTK_GESTURE (data->controller),
sequence) != GTK_EVENT_SEQUENCE_DENIED)
gtk_gesture_handles_sequence (GTK_GESTURE (data->controller), sequence))
return TRUE;
}