AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity

css provider: Issue deprecation warnings for style properties

Browse Source 
This makes G_PARAM_DEPRECATED useful for style properties.
This commit is contained in:
Matthias Clasen 2015-11-16 14:37:23 -05:00
parent 9facd00884
commit 08c4bc8aa5
1 changed files with 51 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

51
gtk/gtkcssprovider.c
View File

@ -2408,6 +2408,55 @@ name_is_style_property (const char *name)
return TRUE;
}
static void
warn_if_deprecated (GtkCssScanner *scanner,
const gchar *name)
{
gchar *n = NULL;
gchar *p;
const gchar *type_name;
const gchar *property_name;
GType type;
GTypeClass *class = NULL;
GParamSpec *pspec;
n = g_strdup (name);
/* skip initial - */
type_name = n + 1;
p = strchr (type_name, '-');
if (!p)
goto out;
p[0] = '\0';
property_name = p + 1;
type = g_type_from_name (type_name);
if (type == G_TYPE_INVALID ||
!g_type_is_a (type, GTK_TYPE_WIDGET))
goto out;
class = g_type_class_ref (type);
pspec = gtk_widget_class_find_style_property (GTK_WIDGET_CLASS (class), property_name);
if (!pspec)
goto out;
if (!(pspec->flags & G_PARAM_DEPRECATED))
goto out;
_gtk_css_parser_error_full (scanner->parser,
GTK_CSS_PROVIDER_ERROR_DEPRECATED,
"The style property %s:%s is deprecated and shouldn't be "
"used anymore. It will be removed in a future version",
g_type_name (pspec->owner_type), pspec->name);
out:
g_free (n);
if (class)
g_type_class_unref (class);
}
static void
parse_declaration (GtkCssScanner *scanner,
GtkCssRuleset *ruleset)
@ -2511,6 +2560,8 @@ parse_declaration (GtkCssScanner *scanner,
{
char *value_str;
warn_if_deprecated (scanner, name);
gtk_css_scanner_push_section (scanner, GTK_CSS_SECTION_VALUE);
value_str = _gtk_css_parser_read_value (scanner->parser);