From 0a49865ec4dbe7b085f52d9ec2a2120b0d9f82d3 Mon Sep 17 00:00:00 2001 From: Michael Natterer Date: Sun, 7 Mar 2010 12:15:33 +0100 Subject: [PATCH] gtk: remove begin-user-action/end-user-action around copying Copying to the clipboard is not a buffer mutation, so calling gtk_text_buffer_begin_user_action() and _end_user_action() is only confusing apps which connect to these signals in order to build undo stacks or otherwise track buffer changes. Most likely, these apps either didn't notice the bugus undo step or simply work around it. --- gtk/gtktextbuffer.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/gtk/gtktextbuffer.c b/gtk/gtktextbuffer.c index 97abf9a26d..dca5686e46 100644 --- a/gtk/gtktextbuffer.c +++ b/gtk/gtktextbuffer.c @@ -4016,9 +4016,7 @@ void gtk_text_buffer_copy_clipboard (GtkTextBuffer *buffer, GtkClipboard *clipboard) { - gtk_text_buffer_begin_user_action (buffer); cut_or_copy (buffer, clipboard, FALSE, TRUE, TRUE); - gtk_text_buffer_end_user_action (buffer); } /**