From 0f216525af6be01199c88d8a92712d9384f857fb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Wed, 3 Jul 2019 16:15:52 -0400 Subject: [PATCH] treeview: Remove in_scroll flag Keep using the pixel cache for backwards-compat, but remove the in_scroll flag to fix the missing invalidation during scrolling. Fixes #1977 --- gtk/gtktreeview.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/gtk/gtktreeview.c b/gtk/gtktreeview.c index 7782d0729e..6364ca8aca 100644 --- a/gtk/gtktreeview.c +++ b/gtk/gtktreeview.c @@ -495,8 +495,6 @@ struct _GtkTreeViewPrivate guint hover_expand : 1; guint imcontext_changed : 1; - guint in_scroll : 1; - guint rubber_banding_enable : 1; guint in_grab : 1; @@ -2421,11 +2419,6 @@ gtk_tree_view_bin_window_invalidate_handler (GdkWindow *window, gdk_window_get_user_data (window, &widget); tree_view = GTK_TREE_VIEW (widget); - /* Scrolling will invalidate everything in the bin window, - but we already have it in the cache, so we can ignore that */ - if (tree_view->priv->in_scroll) - return; - y = gtk_adjustment_get_value (tree_view->priv->vadjustment); cairo_region_translate (region, 0, y); @@ -11400,9 +11393,7 @@ gtk_tree_view_adjustment_changed (GtkAdjustment *adjustment, - gtk_adjustment_get_value (tree_view->priv->hadjustment), 0); dy = tree_view->priv->dy - (int) gtk_adjustment_get_value (tree_view->priv->vadjustment); - tree_view->priv->in_scroll = TRUE; gdk_window_scroll (tree_view->priv->bin_window, 0, dy); - tree_view->priv->in_scroll = FALSE; if (dy != 0) {