AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity

Correct the antiexposure vs implicit paint flush race

Browse Source 
The check for a possible implicit paint flush before queueing an
antiexposure was wrong. An implicit flush doesn't actually NULL
the implicit paint, se we have add a flag to explicitly track if
it is flushed.
This commit is contained in:
Alexander Larsson 2009-09-04 13:14:25 +02:00
parent 753f159aad
commit 223bcd23f7
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gdk/gdkwindow.c
View File

@ -142,6 +142,7 @@ struct _GdkWindowPaint
gint y_offset;
cairo_surface_t *surface;
guint uses_implicit : 1;
guint flushed : 1;
guint32 region_tag;
};
@ -2484,6 +2485,7 @@ gdk_window_begin_implicit_paint (GdkWindow *window, GdkRectangle *rect)
paint->x_offset = rect->x;
paint->y_offset = rect->y;
paint->uses_implicit = FALSE;
paint->flushed = FALSE;
paint->surface = NULL;
paint->pixmap =
gdk_pixmap_new (window,
@ -2512,6 +2514,7 @@ gdk_window_flush_implicit_paint (GdkWindow *window)
return;
paint = impl_window->implicit_paint;
paint->flushed = TRUE;
region = gdk_region_copy (private->clip_region_with_children);
/* Don't flush active double buffers, as that may show partially done
@ -5109,7 +5112,8 @@ gdk_window_process_updates_internal (GdkWindow *window)
* be to late to anti-expose now. Since this is merely an
* optimization we just avoid doing it at all in that case.
*/
if (private->implicit_paint != NULL) /* didn't flush implicit paint */
if (private->implicit_paint != NULL &&
!private->implicit_paint->flushed)
{
impl_iface = GDK_WINDOW_IMPL_GET_IFACE (private->impl);
save_region = impl_iface->queue_antiexpose (window, update_area);