From 2959b2075b670acd4501c56a2f67ff1d667b3546 Mon Sep 17 00:00:00 2001 From: Jakub Steiner Date: Fri, 7 Jun 2019 10:46:42 +0200 Subject: [PATCH] Adwaita: update treeview progressbars - The style resembles Clearlooks and is way outdated. https://gitlab.gnome.org/GNOME/gtk/issues/1938 --- gtk/theme/Adwaita/_common.scss | 27 ++++-------------------- gtk/theme/Adwaita/gtk-contained-dark.css | 12 +++++------ gtk/theme/Adwaita/gtk-contained.css | 10 ++++----- 3 files changed, 15 insertions(+), 34 deletions(-) diff --git a/gtk/theme/Adwaita/_common.scss b/gtk/theme/Adwaita/_common.scss index 828e78c4db..a596a9c9af 100644 --- a/gtk/theme/Adwaita/_common.scss +++ b/gtk/theme/Adwaita/_common.scss @@ -1972,36 +1972,26 @@ treeview.view { &.progressbar { // progress bar in treeviews @if $variant == light { color: $base_color; } - border: 1px solid $selected_borders_color; - border-radius: 4px; background-color: $selected_bg_color; - background-image: linear-gradient(to bottom, - $selected_bg_color, - darken($selected_bg_color, 10%)); - box-shadow: inset 0 1px if($variant=='light', transparentize(white, 0.7), transparentize(white, 0.85)), - 0 1px if($variant=='light', transparentize(black, 0.8), transparentize(black, 0.9)); + background-image: image($selected_bg_color); + box-shadow: none; &:selected { &:focus, & { - border-radius: 4px; @if $variant == 'light' { color: $selected_bg_color; - box-shadow: none; + } @else { box-shadow: inset 0 1px transparentize(white, 0.95); } - background-image: linear-gradient(to bottom, $base_color, darken($base_color,10%)); + background-image: image($base_color); &:backdrop { @if $variant == 'light' { color: $selected_bg_color; - border-color: $selected_borders_color; // otherwise it gets inherited by .view(?!?) } - - @else { border-color: $backdrop_base_color; } - background-color: $backdrop_base_color; } } @@ -2010,8 +2000,6 @@ treeview.view { &:backdrop { @if $variant == 'light' { color: $backdrop_base_color; } - @else { border-color: $backdrop_base_color; } - background-image: none; box-shadow: none; } @@ -2019,20 +2007,13 @@ treeview.view { &.trough { // progress bar trough in treeviews background-color: transparentize($fg_color,0.9); - border-radius: 4px; &:selected { &:focus, & { background-color: if($variant == 'light', transparentize($selected_fg_color, 0.7), darken($selected_bg_color, 10%)); - border-radius: 4px; - @if $variant == 'light' { - border-width: 1px 0; - border-style: solid; - border-color: $selected_bg_color; - } } } } diff --git a/gtk/theme/Adwaita/gtk-contained-dark.css b/gtk/theme/Adwaita/gtk-contained-dark.css index df6b6ab05c..17c9a24f39 100644 --- a/gtk/theme/Adwaita/gtk-contained-dark.css +++ b/gtk/theme/Adwaita/gtk-contained-dark.css @@ -770,17 +770,17 @@ treeview.view.expander:checked { -gtk-icon-source: -gtk-icontheme("pan-down-symb treeview.view.expander:backdrop { color: #747473; } -treeview.view.progressbar { border: 1px solid #030c17; border-radius: 4px; background-color: #15539e; background-image: linear-gradient(to bottom, #15539e, #0f3b71); box-shadow: inset 0 1px rgba(255, 255, 255, 0.15), 0 1px rgba(0, 0, 0, 0.1); } +treeview.view.progressbar { background-color: #15539e; background-image: image(#15539e); box-shadow: none; } -treeview.view.progressbar:selected:focus, treeview.view.progressbar:selected { border-radius: 4px; box-shadow: inset 0 1px rgba(255, 255, 255, 0.05); background-image: linear-gradient(to bottom, #2d2d2d, #141414); } +treeview.view.progressbar:selected:focus, treeview.view.progressbar:selected { box-shadow: inset 0 1px rgba(255, 255, 255, 0.05); background-image: image(#2d2d2d); } -treeview.view.progressbar:selected:focus:backdrop, treeview.view.progressbar:selected:backdrop { border-color: #303030; background-color: #303030; } +treeview.view.progressbar:selected:focus:backdrop, treeview.view.progressbar:selected:backdrop { background-color: #303030; } -treeview.view.progressbar:backdrop { border-color: #303030; background-image: none; box-shadow: none; } +treeview.view.progressbar:backdrop { background-image: none; box-shadow: none; } -treeview.view.trough { background-color: rgba(238, 238, 236, 0.1); border-radius: 4px; } +treeview.view.trough { background-color: rgba(238, 238, 236, 0.1); } -treeview.view.trough:selected:focus, treeview.view.trough:selected { background-color: #0f3b71; border-radius: 4px; } +treeview.view.trough:selected:focus, treeview.view.trough:selected { background-color: #0f3b71; } treeview.view header button { color: #8e8e8d; background-color: #2d2d2d; font-weight: bold; text-shadow: none; box-shadow: none; } diff --git a/gtk/theme/Adwaita/gtk-contained.css b/gtk/theme/Adwaita/gtk-contained.css index c8dbbb4961..4362a7ff71 100644 --- a/gtk/theme/Adwaita/gtk-contained.css +++ b/gtk/theme/Adwaita/gtk-contained.css @@ -778,17 +778,17 @@ treeview.view.expander:checked { -gtk-icon-source: -gtk-icontheme("pan-down-symb treeview.view.expander:backdrop { color: #b2b4b4; } -treeview.view.progressbar { color: #ffffff; border: 1px solid #185fb4; border-radius: 4px; background-color: #3584e4; background-image: linear-gradient(to bottom, #3584e4, #1b6acb); box-shadow: inset 0 1px rgba(255, 255, 255, 0.3), 0 1px rgba(0, 0, 0, 0.2); } +treeview.view.progressbar { color: #ffffff; background-color: #3584e4; background-image: image(#3584e4); box-shadow: none; } -treeview.view.progressbar:selected:focus, treeview.view.progressbar:selected { border-radius: 4px; color: #3584e4; box-shadow: none; background-image: linear-gradient(to bottom, #ffffff, #e6e6e6); } +treeview.view.progressbar:selected:focus, treeview.view.progressbar:selected { color: #3584e4; background-image: image(#ffffff); } -treeview.view.progressbar:selected:focus:backdrop, treeview.view.progressbar:selected:backdrop { color: #3584e4; border-color: #185fb4; background-color: #fcfcfc; } +treeview.view.progressbar:selected:focus:backdrop, treeview.view.progressbar:selected:backdrop { color: #3584e4; background-color: #fcfcfc; } treeview.view.progressbar:backdrop { color: #fcfcfc; background-image: none; box-shadow: none; } -treeview.view.trough { background-color: rgba(46, 52, 54, 0.1); border-radius: 4px; } +treeview.view.trough { background-color: rgba(46, 52, 54, 0.1); } -treeview.view.trough:selected:focus, treeview.view.trough:selected { background-color: rgba(255, 255, 255, 0.3); border-radius: 4px; border-width: 1px 0; border-style: solid; border-color: #3584e4; } +treeview.view.trough:selected:focus, treeview.view.trough:selected { background-color: rgba(255, 255, 255, 0.3); } treeview.view header button { color: #979a9b; background-color: #ffffff; font-weight: bold; text-shadow: none; box-shadow: none; }