AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity

video: Stop playing when appropriate

Browse Source 
When the widget gets unrealized or hidden, pause
the mediastream. Otherwise, audio might keep playing
unexpectedly.
This commit is contained in:
Matthias Clasen 2021-01-01 15:07:25 -05:00
parent 75a297632e
commit 29afe5a688
1 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
gtk/gtkvideo.c
View File

@ -131,6 +131,9 @@ gtk_video_unrealize (GtkWidget *widget)
{ {
GtkVideo *self = GTK_VIDEO (widget); GtkVideo *self = GTK_VIDEO (widget);
if (self->autoplay && self->media_stream)
gtk_media_stream_pause (self->media_stream);
if (self->media_stream) if (self->media_stream)
{ {
GdkSurface *surface; GdkSurface *surface;
@ -165,11 +168,20 @@ gtk_video_unmap (GtkWidget *widget)
gtk_revealer_set_reveal_child (GTK_REVEALER (self->controls_revealer), FALSE); gtk_revealer_set_reveal_child (GTK_REVEALER (self->controls_revealer), FALSE);
} }
/* XXX: pause video here? */
GTK_WIDGET_CLASS (gtk_video_parent_class)->unmap (widget); GTK_WIDGET_CLASS (gtk_video_parent_class)->unmap (widget);
} }
static void
gtk_video_hide (GtkWidget *widget)
{
GtkVideo *self = GTK_VIDEO (widget);
if (self->autoplay && self->media_stream)
gtk_media_stream_pause (self->media_stream);
GTK_WIDGET_CLASS (gtk_video_parent_class)->hide (widget);
}
static void static void
gtk_video_set_focus_child (GtkWidget *widget, gtk_video_set_focus_child (GtkWidget *widget,
GtkWidget *child) GtkWidget *child)
@ -268,6 +280,7 @@ gtk_video_class_init (GtkVideoClass *klass)
widget_class->unrealize = gtk_video_unrealize; widget_class->unrealize = gtk_video_unrealize;
widget_class->map = gtk_video_map; widget_class->map = gtk_video_map;
widget_class->unmap = gtk_video_unmap; widget_class->unmap = gtk_video_unmap;
widget_class->hide = gtk_video_hide;
widget_class->set_focus_child = gtk_video_set_focus_child; widget_class->set_focus_child = gtk_video_set_focus_child;
gobject_class->dispose = gtk_video_dispose; gobject_class->dispose = gtk_video_dispose;