AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity

testsuite: Remove a GtkColorButton special case

Browse Source 
The comment above explains neatly why subclassing GtkButton for
GtkColorButton was a bad idea. Nowadays it's a GtkWidget subclass
containing a GtkButton so let's remove the special case here.
This commit is contained in:
Timm Bäder 2018-06-27 17:58:01 +02:00
parent 73cad1e784
commit 2f8284a386
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
testsuite/gtk/notify.c
View File

@ -509,13 +509,6 @@ test_type (gconstpointer data)
g_str_equal (pspec->name, "draw-indicator"))
continue;
/* Really a bug in the way GtkButton and its subclasses interact:
* setting label etc on a subclass destroys the content, breaking
* e.g. GtkColorButton pretty badly
*/
if (type == GTK_TYPE_COLOR_BUTTON && pspec->owner_type == GTK_TYPE_BUTTON)
continue;
/* Too many special cases involving -set properties */
if (g_str_equal (g_type_name (pspec->owner_type), "GtkCellRendererText") ||
g_str_equal (g_type_name (pspec->owner_type), "GtkTextTag"))