AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity

GtkQuery: Make API follow GTK+ conversions

Browse Source 
We generally have const getters for strings, and the two users
of this API were promptly leaking the (unexpected) copy they
got from gtk_query_get_location and gtk_query_get_text.
This commit is contained in:
Matthias Clasen 2015-07-21 20:39:29 -04:00
parent 9418712782
commit 38a5db8f83
4 changed files with 17 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
gtk/gtkfilechooserwidget.c
View File

@ -7272,14 +7272,13 @@ search_setup_widgets (GtkFileChooserWidget *impl)
/* if there already is a query, restart it */
if (priv->search_query)
{
gchar *query;
const gchar *query;
query = gtk_query_get_text (priv->search_query);
if (query)
{
gtk_entry_set_text (GTK_ENTRY (priv->search_entry), query);
search_start_query (impl, query);
g_free (query);
}
else
{

8
gtk/gtkquery.c
View File

@ -70,10 +70,10 @@ gtk_query_new (void)
}
gchar *
const gchar *
gtk_query_get_text (GtkQuery *query)
{
return g_strdup (query->priv->text);
return query->priv->text;
}
void
@ -87,10 +87,10 @@ gtk_query_set_text (GtkQuery *query,
query->priv->words = NULL;
}
gchar *
const gchar *
gtk_query_get_location (GtkQuery *query)
{
return g_strdup (query->priv->location_uri);
return query->priv->location_uri;
}
void

20
gtk/gtkquery.h
View File

@ -49,20 +49,20 @@ struct _GtkQueryClass
GObjectClass parent_class;
};
GType gtk_query_get_type (void);
GType gtk_query_get_type (void);
GtkQuery* gtk_query_new (void);
GtkQuery *gtk_query_new (void);
gchar* gtk_query_get_text (GtkQuery *query);
void gtk_query_set_text (GtkQuery *query,
const gchar *text);
const gchar *gtk_query_get_text (GtkQuery *query);
void gtk_query_set_text (GtkQuery *query,
const gchar *text);
gchar* gtk_query_get_location (GtkQuery *query);
void gtk_query_set_location (GtkQuery *query,
const gchar *uri);
const gchar *gtk_query_get_location (GtkQuery *query);
void gtk_query_set_location (GtkQuery *query,
const gchar *uri);
gboolean gtk_query_matches_string (GtkQuery *query,
const gchar *string);
gboolean gtk_query_matches_string (GtkQuery *query,
const gchar *string);
G_END_DECLS

5
gtk/gtksearchenginetracker.c
View File

@ -320,8 +320,8 @@ static void
gtk_search_engine_tracker_start (GtkSearchEngine *engine)
{
GtkSearchEngineTracker *tracker;
gchar *search_text;
gchar *location_uri;
const gchar *search_text;
const gchar *location_uri;
GString *sparql;
gboolean recursive;
@ -386,7 +386,6 @@ gtk_search_engine_tracker_start (GtkSearchEngine *engine)
get_query_results (tracker, sparql->str, query_callback, g_object_ref (tracker));
g_string_free (sparql, TRUE);
g_free (search_text);
}
static void