AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity

headerbar: fix leak of separator

Browse Source 
https://bugzilla.gnome.org/show_bug.cgi?id=772859
This commit is contained in:
Alan Jenkins 2016-10-12 16:18:47 +01:00 committed by Matthias Clasen
parent b3af460860
commit 3eb53e9e7c
1 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
gtk/gtkheaderbar.c
View File

@ -340,11 +340,6 @@ _gtk_header_bar_update_window_buttons (GtkHeaderBar *bar)
gtk_widget_set_no_show_all (separator, TRUE); gtk_widget_set_no_show_all (separator, TRUE);
gtk_style_context_add_class (gtk_widget_get_style_context (separator), "titlebutton"); gtk_style_context_add_class (gtk_widget_get_style_context (separator), "titlebutton");
if (i == 0)
priv->titlebar_start_separator = separator;
else
priv->titlebar_end_separator = separator;
box = gtk_box_new (GTK_ORIENTATION_HORIZONTAL, priv->spacing); box = gtk_box_new (GTK_ORIENTATION_HORIZONTAL, priv->spacing);
for (j = 0; t[j]; j++) for (j = 0; t[j]; j++)
@ -460,6 +455,7 @@ _gtk_header_bar_update_window_buttons (GtkHeaderBar *bar)
if (n_children == 0) if (n_children == 0)
{ {
gtk_widget_destroy (box); gtk_widget_destroy (box);
gtk_widget_destroy (separator);
continue; continue;
} }
@ -487,9 +483,15 @@ _gtk_header_bar_update_window_buttons (GtkHeaderBar *bar)
gtk_widget_set_parent (box, GTK_WIDGET (bar)); gtk_widget_set_parent (box, GTK_WIDGET (bar));
if (i == 0) if (i == 0)
priv->titlebar_start_box = box; {
priv->titlebar_start_box = box;
priv->titlebar_start_separator = separator;
}
else else
priv->titlebar_end_box = box; {
priv->titlebar_end_box = box;
priv->titlebar_end_separator = separator;
}
} }
g_strfreev (tokens); g_strfreev (tokens);
} }