From 4288d7d7f4ad5d3d94737c908088d500abcbf36b Mon Sep 17 00:00:00 2001 From: Ryan Lortie Date: Wed, 20 Aug 2014 16:00:14 -0400 Subject: [PATCH] GtkMenuTracker: one more visibility tweak On creation, we call action_removed() in case the action was missing from the start. Because we just created the action, 'can_activate' will always be FALSE here and this function will therefore always do nothing. We do want the visibility state to be updated though, for the case where the action is missing but the item should still be visible from the start. Update the visibility directly instead of trying to call action_removed(). https://bugzilla.gnome.org/show_bug.cgi?id=735122 --- gtk/gtkmenutrackeritem.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gtk/gtkmenutrackeritem.c b/gtk/gtkmenutrackeritem.c index a815d330c4..b9185def48 100644 --- a/gtk/gtkmenutrackeritem.c +++ b/gtk/gtkmenutrackeritem.c @@ -548,10 +548,9 @@ _gtk_menu_tracker_item_new (GtkActionObservable *observable, else { GTK_NOTE(ACTIONS, g_message ("menutracker: %s missing from the start", action_name)); - gtk_menu_tracker_item_action_removed (GTK_ACTION_OBSERVER (self), observable, NULL); + gtk_menu_tracker_item_update_visibility (self); } - if (state) g_variant_unref (state); }