AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity

Range: Make down/up keys act like down/up scrolls

Browse Source 
Before now, down/up keys on H Ranges would increase/decrease value resp,
which is unintuitive & worse, contradicts what we already do for scrolls

Fix simply by moving to the new should_invert_move() as scrolls just did
– which also gets us the other benefits explained in the last 2 commits.

https://bugzilla.gnome.org/show_bug.cgi?id=407242
https://bugzilla.gnome.org/show_bug.cgi?id=791802
This commit is contained in:
Daniel Boles 2018-01-01 14:31:56 +00:00 committed by Daniel Boles
parent 6985dde320
commit 45c8c8f934
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
gtk/gtkrange.c
View File

@ -2494,28 +2494,28 @@ gtk_range_scroll (GtkRange *range,
switch (scroll)
{
case GTK_SCROLL_STEP_LEFT:
if (should_invert (range))
if (should_invert_move (range, GTK_ORIENTATION_HORIZONTAL))
step_forward (range);
else
step_back (range);
break;
case GTK_SCROLL_STEP_UP:
if (should_invert (range))
if (should_invert_move (range, GTK_ORIENTATION_VERTICAL))
step_forward (range);
else
step_back (range);
break;
case GTK_SCROLL_STEP_RIGHT:
if (should_invert (range))
if (should_invert_move (range, GTK_ORIENTATION_HORIZONTAL))
step_back (range);
else
step_forward (range);
break;
case GTK_SCROLL_STEP_DOWN:
if (should_invert (range))
if (should_invert_move (range, GTK_ORIENTATION_VERTICAL))
step_back (range);
else
step_forward (range);
@ -2530,28 +2530,28 @@ gtk_range_scroll (GtkRange *range,
break;
case GTK_SCROLL_PAGE_LEFT:
if (should_invert (range))
if (should_invert_move (range, GTK_ORIENTATION_HORIZONTAL))
page_forward (range);
else
page_back (range);
break;
case GTK_SCROLL_PAGE_UP:
if (should_invert (range))
if (should_invert_move (range, GTK_ORIENTATION_VERTICAL))
page_forward (range);
else
page_back (range);
break;
case GTK_SCROLL_PAGE_RIGHT:
if (should_invert (range))
if (should_invert_move (range, GTK_ORIENTATION_HORIZONTAL))
page_back (range);
else
page_forward (range);
break;
case GTK_SCROLL_PAGE_DOWN:
if (should_invert (range))
if (should_invert_move (range, GTK_ORIENTATION_VERTICAL))
page_back (range);
else
page_forward (range);