AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity

css: Don't crash when color stop offsets descend

Browse Source 
Testcase included.

Fixes #4424
This commit is contained in:
Benjamin Otte 2021-11-10 17:26:13 +01:00
parent fcb3638ac3
commit 46f8600b6a
5 changed files with 28 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gtk/gtkcssimageradial.c
View File

@ -178,7 +178,7 @@ gtk_css_image_radial_snapshot (GtkCssImage *image,
else
pos = MIN (1.0, _gtk_css_number_value_get (stop->offset, hradius) / hradius);
pos = MAX (pos, 0);
pos = MAX (pos, offset);
step = (pos - offset) / (i - last);
for (last = last + 1; last <= i; last++)
{

7
testsuite/reftests/css-radial-gradient-colorstop-crash.css Normal file
View File

@ -0,0 +1,7 @@
window {
background: red;
}
#test {
background: radial-gradient(circle, red 100%, blue 0%, red 100%);
}

8
testsuite/reftests/css-radial-gradient-colorstop-crash.ref.ui Normal file
View File

@ -0,0 +1,8 @@
<?xml version="1.0" encoding="UTF-8"?>
<interface>
<object class="GtkWindow">
<property name="width_request">10</property>
<property name="height_request">10</property>
<property name="decorated">0</property>
</object>
</interface>

9
testsuite/reftests/css-radial-gradient-colorstop-crash.ui Normal file
View File

@ -0,0 +1,9 @@
<?xml version="1.0" encoding="UTF-8"?>
<interface>
<object class="GtkWindow">
<property name="name">test</property>
<property name="width_request">10</property>
<property name="height_request">10</property>
<property name="decorated">0</property>
</object>
</interface>

3
testsuite/reftests/meson.build
View File

@ -258,6 +258,9 @@ testdata = [
'css-multi-state.css',
'css-multi-state.ref.ui',
'css-multi-state.ui',
'css-radial-gradient-colorstop-crash.css',
'css-radial-gradient-colorstop-crash.ref.ui',
'css-radial-gradient-colorstop-crash.ui',
'data-url.css',
'data-url.ref.ui',
'data-url.ui',