AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity

Plug leaks in error code paths

Browse Source 
* gtk/gtkbuilderparser.c: Plug leaks in error code paths

svn path=/trunk/; revision=18254
This commit is contained in:
Johan Dahlin 2007-06-27 04:03:35 +00:00
parent 610331684f
commit 4c1343a22c
2 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ChangeLog
View File

@ -1,3 +1,7 @@
2007-06-27 Johan Dahlin <jdahlin@async.com.br>
* gtk/gtkbuilderparser.c: Plug leaks in error code paths
2007-06-26 Johan Dahlin <jdahlin@async.com.br>
* tests/buildertest.c (test_object_properties):

14
gtk/gtkbuilderparser.c
View File

@ -38,8 +38,8 @@
#include "gtktypeutils.h"
#include "gtkalias.h"
static void free_property_info (PropertyInfo *info,
gpointer user_data);
static void free_property_info (PropertyInfo *info);
static void free_object_info (ObjectInfo *info);
static inline void
state_push (ParserData *data, gpointer info)
@ -196,6 +196,8 @@ parse_object (ParserData *data,
if (child_info && strcmp (child_info->tag.name, "object") == 0)
{
error_invalid_tag (data, element_name, NULL, error);
if (child_info)
free_object_info ((ObjectInfo*)child_info);
return;
}
@ -288,6 +290,8 @@ parse_child (ParserData *data,
if (!object_info || strcmp (object_info->tag.name, "object") != 0)
{
error_invalid_tag (data, element_name, "object", error);
if (object_info)
free_object_info (object_info);
return;
}
@ -372,8 +376,7 @@ parse_property (ParserData *data,
}
static void
free_property_info (PropertyInfo *info,
gpointer user_data)
free_property_info (PropertyInfo *info)
{
g_free (info->data);
g_free (info->name);
@ -728,6 +731,9 @@ end_element (GMarkupParseContext *context,
if (!prop_info->data)
{
error_missing_property_value (data, error);
free_property_info (prop_info);
if (strcmp (info->tag.name, "object") == 0)
free_object_info((ObjectInfo*)info);
return;
}