AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity

textview: Hide the selection bubble better

Browse Source 
The selection bubble is not part of the text windows, so hiding it
during scroll should not be done in the text window code.

Also remove an unused variable that was only set in that code but never
read.
This commit is contained in:
Benjamin Otte 2017-11-11 02:47:59 +01:00
parent e9dd5f327f
commit 52424d8640
1 changed files with 4 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
gtk/gtktextview.c
View File

@ -288,7 +288,6 @@ struct _GtkTextViewPrivate
guint selection_handle_dragged : 1;
guint populate_all : 1;
guint in_scroll : 1;
guint handling_key_event : 1;
};
@ -8697,6 +8696,9 @@ gtk_text_view_value_changed (GtkAdjustment *adjustment,
if (gtk_widget_get_realized (GTK_WIDGET (text_view)))
{
if (priv->selection_bubble)
gtk_widget_hide (priv->selection_bubble);
if (dy != 0)
{
if (priv->left_window)
@ -9790,17 +9792,8 @@ text_window_scroll (GtkTextWindow *win,
gint dx,
gint dy)
{
GtkTextView *view = GTK_TEXT_VIEW (win->widget);
GtkTextViewPrivate *priv = view->priv;
if (dx != 0 || dy != 0)
{
if (priv->selection_bubble)
gtk_widget_hide (priv->selection_bubble);
view->priv->in_scroll = TRUE;
gdk_window_scroll (win->bin_window, dx, dy);
view->priv->in_scroll = FALSE;
}
gdk_window_scroll (win->bin_window, dx, dy);
}
static void