button: don't be active when holding the mouse button outside the bounds

GtkButton currently draws itself as active (pressed down) in case we're
pressing and holding the mouse pointer outside its bounds; this is
misleading though, since we won't activate the button unless the mouse
is released inside the button itself.
Fix this by only setting the ACTIVE state flag when the button is
actually pressed down.

https://bugzilla.gnome.org/show_bug.cgi?id=668141
This commit is contained in:
Cosimo Cecchi 2012-01-17 17:14:23 -05:00
parent ab688333b4
commit 5495152e30

View File

@ -2427,7 +2427,7 @@ gtk_button_update_state (GtkButton *button)
if (priv->in_button)
new_state |= GTK_STATE_FLAG_PRELIGHT;
if (priv->button_down || depressed)
if (depressed)
new_state |= GTK_STATE_FLAG_ACTIVE;
_gtk_button_set_depressed (button, depressed);