AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity

entry: Disconnect text signals in dispose

Browse Source 
This was showing up as crashes when closing
the file chooser.
This commit is contained in:
Matthias Clasen 2019-03-21 19:15:24 -04:00
parent 0bf136a902
commit 56df49971a
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
gtk/gtkentry.c
View File

@ -1254,6 +1254,15 @@ connect_text_signals (GtkEntry *entry)
g_signal_connect (priv->text, "notify", G_CALLBACK (notify_cb), entry);
}
static void
disconnect_text_signals (GtkEntry *entry)
{
GtkEntryPrivate *priv = gtk_entry_get_instance_private (entry);
g_signal_handlers_disconnect_by_func (priv->text, activate_cb, entry);
g_signal_handlers_disconnect_by_func (priv->text, notify_cb, entry);
}
static void
gtk_entry_init (GtkEntry *entry)
{
@ -1278,7 +1287,10 @@ gtk_entry_dispose (GObject *object)
gtk_entry_set_completion (entry, NULL);
if (priv->text)
gtk_editable_finish_delegate (GTK_EDITABLE (entry));
{
disconnect_text_signals (entry);
gtk_editable_finish_delegate (GTK_EDITABLE (entry));
}
g_clear_pointer (&priv->text, gtk_widget_unparent);
gtk_entry_set_icon_from_paintable (entry, GTK_ENTRY_ICON_PRIMARY, NULL);