AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity

columnview: Plug listmodel memory leaks

Browse Source 
We were leaking references returned from g_list_model_get_item
in some places.
This commit is contained in:
Matthias Clasen 2020-11-10 09:07:22 -05:00
parent d63afaf5ad
commit 6079033cde
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gtk/gtkcolumnview.c
View File

@ -983,6 +983,8 @@ header_drag_begin (GtkGestureDrag *gesture,
break; break;
} }
g_object_unref (column);
} }
for (i = 0; !self->in_column_resize && i < n; i++) for (i = 0; !self->in_column_resize && i < n; i++)
@ -1049,7 +1051,10 @@ header_drag_end (GtkGestureDrag *gesture,
sequence = gtk_gesture_single_get_current_sequence (GTK_GESTURE_SINGLE (gesture)); sequence = gtk_gesture_single_get_current_sequence (GTK_GESTURE_SINGLE (gesture));
if (!gtk_gesture_handles_sequence (GTK_GESTURE (gesture), sequence)) if (!gtk_gesture_handles_sequence (GTK_GESTURE (gesture), sequence))
{
g_object_unref (column);
return; return;
}
for (i = 0; i < g_list_model_get_n_items (G_LIST_MODEL (self->columns)); i++) for (i = 0; i < g_list_model_get_n_items (G_LIST_MODEL (self->columns)); i++)
{ {
@ -1531,7 +1536,6 @@ gtk_column_view_remove_column (GtkColumnView *self,
g_object_unref (item); g_object_unref (item);
if (item == column) if (item == column)
break; break;
} }
gtk_column_view_sorter_remove_column (GTK_COLUMN_VIEW_SORTER (self->sorter), column); gtk_column_view_sorter_remove_column (GTK_COLUMN_VIEW_SORTER (self->sorter), column);