AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity

Handle expose events moving or resizing windows

Browse Source 
When a window is moved or resized from a double-buffered expose handler
we can't really just copy the window region around, as the window
will be overdrawn with the double buffered region when the expose returns.

Instead we remove all regions with outstanding implicit paints from the
region to be copied and just mark this area as invalid to be redrawn
later.

This fixes bug 594880.
This commit is contained in:
Alexander Larsson 2009-09-14 13:38:47 +02:00
parent 2d2dc2c7e9
commit 6d84fcab76
1 changed files with 19 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
gdk/gdkwindow.c
View File

@ -3136,12 +3136,10 @@ append_move_region (GdkWindowObject *impl_window,
/* Moves bits and update area by dx/dy in impl window.
Takes ownership of region to avoid copy (because we may change it) */
static void
move_region_on_impl (GdkWindowObject *private,
move_region_on_impl (GdkWindowObject *impl_window,
GdkRegion *region, /* In impl window coords */
int dx, int dy)
{
GdkWindowObject *impl_window;
if ((dx == 0 && dy == 0) ||
gdk_region_empty (region))
{
@ -3149,12 +3147,13 @@ move_region_on_impl (GdkWindowObject *private,
return;
}
impl_window = gdk_window_get_impl_window (private);
g_assert (impl_window == gdk_window_get_impl_window (impl_window));
/* Move any old invalid regions in the copy source area by dx/dy */
if (impl_window->update_area)
{
GdkRegion *update_area;
update_area = gdk_region_copy (region);
/* Convert from target to source */
@ -3176,6 +3175,22 @@ move_region_on_impl (GdkWindowObject *private,
gdk_region_destroy (update_area);
}
/* If we're currently exposing this window, don't copy to this
destination, as it will be overdrawn when the expose is done,
instead invalidate it and repaint later. */
if (impl_window->implicit_paint)
{
GdkWindowPaint *implicit_paint = impl_window->implicit_paint;
GdkRegion *exposing;
exposing = gdk_region_copy (implicit_paint->region);
gdk_region_intersect (exposing, region);
gdk_region_subtract (region, exposing);
impl_window_add_update_area (impl_window, exposing);
gdk_region_destroy (exposing);
}
if (1) /* Enable flicker free handling of moves. */
append_move_region (impl_window, region, dx, dy);
else