AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity

gtkprintoperation: job names must not exceed 255 chars

Browse Source 
According to http://datatracker.ietf.org/doc/rfc2911/, The 'name'
attribute syntax is essentially the same as 'text', including the
REQUIRED support of UTF-8 except that the sequence of characters
is limited so that its encoded form MUST NOT exceed 255 (MAX) octets.

CUPS will not print jobs with names exceeding 255 characters.

https://bugzilla.gnome.org/show_bug.cgi?id=755988
This commit is contained in:
Felipe Borges 2015-10-02 17:15:26 +02:00
parent 5548665351
commit 70f577251f
1 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
gtk/gtkprintoperation.c
View File

@ -1606,6 +1606,7 @@ gtk_print_operation_set_job_name (GtkPrintOperation *op,
const gchar *job_name) const gchar *job_name)
{ {
GtkPrintOperationPrivate *priv; GtkPrintOperationPrivate *priv;
gchar *end;
g_return_if_fail (GTK_IS_PRINT_OPERATION (op)); g_return_if_fail (GTK_IS_PRINT_OPERATION (op));
g_return_if_fail (job_name != NULL); g_return_if_fail (job_name != NULL);
@ -1613,7 +1614,25 @@ gtk_print_operation_set_job_name (GtkPrintOperation *op,
priv = op->priv; priv = op->priv;
g_free (priv->job_name); g_free (priv->job_name);
/*
* according to http://datatracker.ietf.org/doc/rfc2911/,
* job names MUST NOT exceed 255 (MAX) octets.
*
* CUPS will not print jobs with names exceeding 255 chars.
*/
if (strlen (job_name) > 255)
{
end = g_utf8_find_prev_char (job_name, job_name + 255);
priv->job_name = g_utf8_substring (job_name,
0,
g_utf8_pointer_to_offset (job_name,
end));
}
else
{
priv->job_name = g_strdup (job_name); priv->job_name = g_strdup (job_name);
}
g_object_notify (G_OBJECT (op), "job-name"); g_object_notify (G_OBJECT (op), "job-name");
} }