AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity

places sidebar: Avoid markup confusion in tooltips

Browse Source 
At one point, the sidebar was using gtk_treeview_set_tooltip_column,
which expects tooltips to be markup. With the listbox-based sidebar,
we don't do that anymore. So don't escape the tooltip text.

https://bugzilla.gnome.org/show_bug.cgi?id=766175
This commit is contained in:
Matthias Clasen 2016-05-10 21:47:20 -04:00
parent 7e7d7991cc
commit 7c21a32b28
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gtk/gtkplacessidebar.c
View File

@ -454,7 +454,6 @@ add_place (GtkPlacesSidebar *sidebar,
{ {
gboolean show_eject, show_unmount; gboolean show_eject, show_unmount;
gboolean show_eject_button; gboolean show_eject_button;
gchar *tooltip_escaped;
GtkWidget *row; GtkWidget *row;
GtkWidget *eject_button; GtkWidget *eject_button;
GtkWidget *event_box; GtkWidget *event_box;
@ -467,12 +466,11 @@ add_place (GtkPlacesSidebar *sidebar,
show_eject_button = (show_unmount || show_eject); show_eject_button = (show_unmount || show_eject);
tooltip_escaped = g_markup_escape_text (tooltip, -1);
row = g_object_new (GTK_TYPE_SIDEBAR_ROW, row = g_object_new (GTK_TYPE_SIDEBAR_ROW,
"sidebar", sidebar, "sidebar", sidebar,
"icon", icon, "icon", icon,
"label", name, "label", name,
"tooltip", tooltip_escaped, "tooltip", tooltip,
"ejectable", show_eject_button, "ejectable", show_eject_button,
"order-index", index, "order-index", index,
"section-type", section_type, "section-type", section_type,
@ -483,7 +481,6 @@ add_place (GtkPlacesSidebar *sidebar,
"mount", mount, "mount", mount,
NULL); NULL);
g_free (tooltip_escaped);
eject_button = gtk_sidebar_row_get_eject_button (GTK_SIDEBAR_ROW (row)); eject_button = gtk_sidebar_row_get_eject_button (GTK_SIDEBAR_ROW (row));
event_box = gtk_sidebar_row_get_event_box (GTK_SIDEBAR_ROW (row)); event_box = gtk_sidebar_row_get_event_box (GTK_SIDEBAR_ROW (row));