AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity

linkbutton: Use the LINK role

Browse Source 
It is a bit ambiguous, but I think link buttons are
more links than buttons. See WAI-ARIA for a discussion
of the differences.

Update tests to match.
This commit is contained in:
Matthias Clasen 2020-10-21 21:54:17 -04:00
parent bcbc6159f4
commit 800eb76a2d
4 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
docs/reference/gtk/section-accessibility.md
View File

@ -54,6 +54,7 @@ Each role name is part of the #GtkAccessibleRole enumeration.
| `GRID_CELL` | An item in a grid | #GtkFlowBoxChild, #GtkGridView, #GtkColumnView |
| `IMG` | An image | #GtkImage, #GtkPicture |
| `LABEL` | A visible name or caption for a user interface component | #GtkLabel |
| `LINK` | A clickable hyperlink | #GtkLinkButton |
| `LIST` | A list of items | #GtkListBox |
| `LIST_ITEM` | An item in a list | #GtkListBoxRow |
| `MENU` | A menu | #GtkPopoverMenu |

2
gtk/gtkenums.h
View File

@ -1183,7 +1183,7 @@ typedef enum {
* @GTK_ACCESSIBLE_ROLE_LABEL: A visible name or caption for a user interface component.
* @GTK_ACCESSIBLE_ROLE_LANDMARK: Abstract role.
* @GTK_ACCESSIBLE_ROLE_LEGEND: Unused
* @GTK_ACCESSIBLE_ROLE_LINK: Unused
* @GTK_ACCESSIBLE_ROLE_LINK: A clickable link.
* @GTK_ACCESSIBLE_ROLE_LIST: A list of items.
* @GTK_ACCESSIBLE_ROLE_LIST_BOX: Unused.
* @GTK_ACCESSIBLE_ROLE_LIST_ITEM: An item in a list.

4
gtk/gtklinkbutton.c
View File

@ -50,7 +50,7 @@
*
* # Accessibility
*
* GtkLinkButton uses the #GTK_ACCESSIBLE_ROLE_BUTTON role.
* GtkLinkButton uses the #GTK_ACCESSIBLE_ROLE_LINK role.
*/
#include "config.h"
@ -220,7 +220,7 @@ gtk_link_button_class_init (GtkLinkButtonClass *klass)
G_TYPE_BOOLEAN, 0);
gtk_widget_class_set_css_name (widget_class, I_("button"));
gtk_widget_class_set_accessible_role (widget_class, GTK_ACCESSIBLE_ROLE_BUTTON);
gtk_widget_class_set_accessible_role (widget_class, GTK_ACCESSIBLE_ROLE_LINK);
/**
* GtkLinkButton|clipboard.copy:

2
testsuite/a11y/button.c
View File

@ -49,7 +49,7 @@ linkbutton_role (void)
GtkWidget *button = gtk_link_button_new ("Hello");
g_object_ref_sink (button);
gtk_test_accessible_assert_role (button, GTK_ACCESSIBLE_ROLE_BUTTON);
gtk_test_accessible_assert_role (button, GTK_ACCESSIBLE_ROLE_LINK);
g_object_unref (button);
}