AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity

HC: Copy working tooltip code from Adwaita & tweak

Browse Source 
There were various problems, like only selecting on .tooltip and not the
widget node tooltip, not being specific enough for tooltip.csd, etc. So,
specific theming was absent, and default popup window styles got applied

This commit copies in the better working tooltip CSS from Adwaita, but
applies a couple of changes to make it work better in the HC themes:
 • Reduce the transparency of the tooltip, so we achieve higher contrast
 • Drop the black text-shadow, as it is not useful on this more black bg

Note: we may then need to re-add some of this to the .tooltip class. But
it is unclear what needs done there. While Adwaita is not doing it, we
are better not to confuse by keeping it in HC only; we should try to be
as close as possible, to make it easier for HC to keep up with Adwaita.

https://bugzilla.gnome.org/show_bug.cgi?id=769879
This commit is contained in:
Daniel Boles 2017-10-05 19:09:19 +01:00
parent acab79040a
commit 8abdbfee16
3 changed files with 34 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
gtk/theme/HighContrast/_common.scss
View File

@ -3114,20 +3114,29 @@ infobar {
* Tooltips *
************/
.tooltip {
color: white;
tooltip {
&.background {
// background-color needs to be set this way otherwise it gets drawn twice
// see https://bugzilla.gnome.org/show_bug.cgi?id=736155 for details.
background-color: transparentize(black, 0.1);
background-clip: padding-box;
border: 1px solid $borders_color;
}
padding: 4px; /* not working */
border-radius: 5px;
background-color: transparentize(black,0.2); //FIXME proper color
text-shadow: 0 1px black;
// border: 2px solid $borders_color; gnome shell style?
box-shadow: none; // otherwise it gets inherited by windowframe.csd
// FIXME: we need a border or tooltips vanish on black background.
decoration { background-color: transparent; }
* { // Yeah this is ugly
padding: 4px;
background-color: transparent;
color: white;
}
}
.tooltip * { //Yeah this is ugly
padding: 4px;
background-color: transparent;
color: inherit; // just to be sure
}
/*****************
* Color Chooser *
@ -3278,7 +3287,7 @@ decoration {
0 0 0 1px transparentize($_wm_border,0.1);
}
.tooltip & {
tooltip.csd & {
border-radius: 5px;
box-shadow: none;
}

10
gtk/theme/HighContrast/gtk-contained-inverse.css
View File

@ -1403,9 +1403,13 @@ infobar { border-width: 0; border-style: none; }
.info label:selected, .info label:selected:focus, .info label:selected:hover, .question label:selected, .question label:selected:focus, .question label:selected:hover, .warning label:selected, .warning label:selected:focus, .warning label:selected:hover, .error label:selected, .error label:selected:focus, .error label:selected:hover { background-color: white; }
/************ Tooltips * */
.tooltip { color: white; padding: 4px; /* not working */ border-radius: 5px; background-color: rgba(0, 0, 0, 0.8); text-shadow: 0 1px black; }
tooltip { padding: 4px; /* not working */ border-radius: 5px; box-shadow: none; }
.tooltip * { padding: 4px; background-color: transparent; color: inherit; }
tooltip.background { background-color: rgba(0, 0, 0, 0.9); background-clip: padding-box; border: 1px solid gray; }
tooltip decoration { background-color: transparent; }
tooltip * { padding: 4px; background-color: transparent; color: white; }
/***************** Color Chooser * */
colorswatch { box-shadow: inset 0 1px rgba(0, 0, 0, 0.1), 0 1px #000; }
@ -1471,7 +1475,7 @@ decoration:backdrop { box-shadow: 0 2px 6px 2px rgba(0, 0, 0, 0.2), 0 3px 9px 1p
.csd.popup decoration { border-radius: 0; box-shadow: 0 1px 2px rgba(0, 0, 0, 0.2), 0 0 0 1px rgba(0, 0, 0, 0.13); }
.tooltip decoration { border-radius: 5px; box-shadow: none; }
tooltip.csd decoration { border-radius: 5px; box-shadow: none; }
.solid-csd decoration { border-radius: 0; margin: 4px; background-color: #000; border: solid 1px #737373; box-shadow: none; }

10
gtk/theme/HighContrast/gtk-contained.css
View File

@ -1409,9 +1409,13 @@ infobar { border-width: 0; border-style: none; }
.info label:selected, .info label:selected:focus, .info label:selected:hover, .question label:selected, .question label:selected:focus, .question label:selected:hover, .warning label:selected, .warning label:selected:focus, .warning label:selected:hover, .error label:selected, .error label:selected:focus, .error label:selected:hover { background-color: #333333; }
/************ Tooltips * */
.tooltip { color: white; padding: 4px; /* not working */ border-radius: 5px; background-color: rgba(0, 0, 0, 0.8); text-shadow: 0 1px black; }
tooltip { padding: 4px; /* not working */ border-radius: 5px; box-shadow: none; }
.tooltip * { padding: 4px; background-color: transparent; color: inherit; }
tooltip.background { background-color: rgba(0, 0, 0, 0.9); background-clip: padding-box; border: 1px solid gray; }
tooltip decoration { background-color: transparent; }
tooltip * { padding: 4px; background-color: transparent; color: white; }
/***************** Color Chooser * */
colorswatch { box-shadow: inset 0 1px rgba(0, 0, 0, 0.1), 0 1px #fff; }
@ -1477,7 +1481,7 @@ decoration:backdrop { box-shadow: 0 2px 6px 2px rgba(0, 0, 0, 0.2), 0 3px 9px 1p
.csd.popup decoration { border-radius: 0; box-shadow: 0 1px 2px rgba(0, 0, 0, 0.2), 0 0 0 1px rgba(0, 0, 0, 0.13); }
.tooltip decoration { border-radius: 5px; box-shadow: none; }
tooltip.csd decoration { border-radius: 5px; box-shadow: none; }
.solid-csd decoration { border-radius: 0; margin: 4px; background-color: #fff; border: solid 1px #8d8d8d; box-shadow: none; }