AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity

cssimageradial: Only emit one error for wrong position

Browse Source 
Test included.
This commit is contained in:
Benjamin Otte 2016-02-05 18:30:28 +01:00
parent f2e08d3a9c
commit 982da040b2
5 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gtk/gtkcssimageradial.c
View File

@ -273,10 +273,7 @@ gtk_css_image_radial_parse (GtkCssImage *image,
{ {
radial->position = _gtk_css_position_value_parse (parser); radial->position = _gtk_css_position_value_parse (parser);
if (!radial->position) if (!radial->position)
{ return FALSE;
_gtk_css_parser_error (parser, "Expected a position after 'at'");
return FALSE;
}
found_one = has_position = TRUE; found_one = has_position = TRUE;
} }
else if (!has_size) else if (!has_size)

3
testsuite/css/parser/Makefile.am
View File

@ -407,6 +407,9 @@ test_data = \
pseudo-classes-unknown.ref.css \ pseudo-classes-unknown.ref.css \
radial.css \ radial.css \
radial.ref.css \ radial.ref.css \
radial-background-position-error.css \
radial-background-position-error.errors \
radial-background-position-error.ref.css \
selector.css \ selector.css \
selector.ref.css \ selector.ref.css \
shadow.css \ shadow.css \

3
testsuite/css/parser/radial-background-position-error.css Normal file
View File

@ -0,0 +1,3 @@
a {
background: radial-gradient(at your mom);
}

1
testsuite/css/parser/radial-background-position-error.errors Normal file
View File

@ -0,0 +1 @@
radial-background-position-error.css:2: error: GTK_CSS_PROVIDER_ERROR_SYNTAX

0
testsuite/css/parser/radial-background-position-error.ref.css Normal file
View File