Bug 555386 – format not a string literal and no format arguments

svn path=/trunk/; revision=21642
This commit is contained in:
Christian Persch 2008-10-13 12:54:45 +00:00
parent e68135a992
commit aadcba2dc5
8 changed files with 26 additions and 14 deletions

View File

@ -1,3 +1,15 @@
2008-10-13 Christian Persch <chpe@gnome.org>
Bug 555386 format not a string literal and no format arguments
* gtk/gtkiconfactory.c
* gtk/gtkprintbackend.c
* gtk/gtkprintoperation.c
* gtk/gtkthemes.c
* gtk/tests/builder.c
* modules/other/gail/gailtextview.c
* tests/testmerge.c: Use printf safely.
2008-10-13 Christian Persch <chpe@gnome.org>
Bug 555724 gtkcellrendereraccel not initialised correctly

View File

@ -2863,7 +2863,7 @@ icon_source_start_element (GMarkupParseContext *context,
error_domain,
tmp);
#else
g_warning (tmp);
g_warning ("%s", tmp);
#endif
g_free (tmp);
g_free (stock_id);

View File

@ -119,7 +119,7 @@ gtk_print_backend_module_load (GTypeModule *module)
pb_module->library = g_module_open (pb_module->path, G_MODULE_BIND_LAZY | G_MODULE_BIND_LOCAL);
if (!pb_module->library)
{
g_warning (g_module_error());
g_warning ("%s", g_module_error());
return FALSE;
}
@ -131,7 +131,7 @@ gtk_print_backend_module_load (GTypeModule *module)
!g_module_symbol (pb_module->library, "pb_module_create",
&createp))
{
g_warning (g_module_error());
g_warning ("%s", g_module_error());
g_module_close (pb_module->library);
return FALSE;

View File

@ -1848,10 +1848,10 @@ run_pdf (GtkPrintOperation *op,
width, height);
if (cairo_surface_status (surface) != CAIRO_STATUS_SUCCESS)
{
g_set_error (&priv->error,
GTK_PRINT_ERROR,
GTK_PRINT_ERROR_GENERAL,
cairo_status_to_string (cairo_surface_status (surface)));
g_set_error_literal (&priv->error,
GTK_PRINT_ERROR,
GTK_PRINT_ERROR_GENERAL,
cairo_status_to_string (cairo_surface_status (surface)));
*do_print = FALSE;
return GTK_PRINT_OPERATION_RESULT_ERROR;
}

View File

@ -81,7 +81,7 @@ gtk_theme_engine_load (GTypeModule *module)
g_free(engine_path);
if (!engine->library)
{
g_warning (g_module_error());
g_warning ("%s", g_module_error());
return FALSE;
}
@ -93,7 +93,7 @@ gtk_theme_engine_load (GTypeModule *module)
!g_module_symbol (engine->library, "theme_create_rc_style",
(gpointer *)&engine->create_rc_style))
{
g_warning (g_module_error());
g_warning ("%s", g_module_error());
g_module_close (engine->library);
return FALSE;

View File

@ -2293,7 +2293,7 @@ test_file (const gchar *filename)
if (!gtk_builder_add_from_file (builder, filename, &error))
{
g_error (error->message);
g_error ("%s", error->message);
g_error_free (error);
return;
}

View File

@ -1733,11 +1733,11 @@ static GIOChannel* gail_streamable_content_get_stream (AtkStreamable
gio = g_io_channel_unix_new (fd);
g_io_channel_set_encoding (gio, NULL, &err);
if (!err) g_io_channel_write_chars (gio, (const char *) cbuf, (gssize) len, &written, &err);
else g_message (err->message);
else g_message ("%s", err->message);
if (!err) g_io_channel_seek_position (gio, 0, G_SEEK_SET, &err);
else g_message (err->message);
else g_message ("%s", err->message);
if (!err) g_io_channel_flush (gio, &err);
else g_message (err->message);
else g_message ("%s", err->message);
if (err) {
g_message ("<error writing to stream [%s]>", tname);
g_error_free (err);

View File

@ -43,7 +43,7 @@ dump_tree (GtkWidget *button,
gchar *dump;
dump = gtk_ui_manager_get_ui (merge);
g_message (dump);
g_message ("%s", dump);
g_free (dump);
}