AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity

Fix buffer overruns in 'gtk-builder-tool simplify'

Browse Source 
Oops, here we allocate only one byte for each pointer we want to store.
We need to multiply by the size of a pointer.
This commit is contained in:
Michael Catanzaro 2020-12-21 15:35:51 -06:00
parent 466484176f
commit ab1b117d91
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gtk/tools/gtk-builder-tool-simplify.c
View File

@ -507,8 +507,8 @@ set_attribute_value (Element *element,
}
len = g_strv_length (element->attribute_names);
element->attribute_names = g_realloc (element->attribute_names, len + 2);
element->attribute_values = g_realloc (element->attribute_values, len + 2);
element->attribute_names = g_realloc_n (element->attribute_names, len + 2, sizeof (char *));
element->attribute_values = g_realloc_n (element->attribute_values, len + 2, sizeof (char *));
element->attribute_names[len] = g_strdup (name);
element->attribute_values[len] = g_strdup (value);
element->attribute_names[len + 1] = NULL;