AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity

widget: Always assign values to out parameter in translate_coordinates

Browse Source 
safe guard against people using the returned coordinate values without
checking the return value of gtk_widget_translate_coordinates.
This commit is contained in:
Timm Bäder 2018-01-18 14:43:36 +01:00
parent cc9a4c1720
commit aee4634ee5
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gtk/gtkwidget.c
View File

@ -4888,7 +4888,13 @@ gtk_widget_translate_coordinates (GtkWidget *src_widget,
ancestor = gtk_widget_common_ancestor (src_widget, dest_widget); ancestor = gtk_widget_common_ancestor (src_widget, dest_widget);
if (!ancestor || !_gtk_widget_get_realized (src_widget) || !_gtk_widget_get_realized (dest_widget)) if (!ancestor || !_gtk_widget_get_realized (src_widget) || !_gtk_widget_get_realized (dest_widget))
{
if (dest_x)
*dest_x = 0;
if (dest_y)
*dest_y = 0;
return FALSE; return FALSE;
}
parent = src_widget; parent = src_widget;