AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity

Revert "sizerequest: Only check reported baselines if requested"

Browse Source 
This reverts commit cf7fa931d3.

We store the baseline in the cache and we do not know if baselines might
be queried in the future. So always store them.

No reftest because I don't know how to write one.

premature optimization == √😈
This commit is contained in:
Benjamin Otte 2021-11-06 18:26:41 +01:00
parent 129042425d
commit b004706009
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
gtk/gtksizerequest.c
View File

@ -139,7 +139,6 @@ gtk_widget_query_size_for_orientation (GtkWidget *widget,
int *minimum_baseline,
int *natural_baseline)
{
const gboolean baselines_requested = (minimum_baseline != NULL || natural_baseline != NULL);
SizeRequestCache *cache;
int min_size = 0;
int nat_size = 0;
@ -361,7 +360,7 @@ gtk_widget_query_size_for_orientation (GtkWidget *widget,
nat_size = adjusted_natural;
}
if (baselines_requested && (min_baseline != -1 || nat_baseline != -1))
if (min_baseline != -1 || nat_baseline != -1)
{
if (orientation == GTK_ORIENTATION_HORIZONTAL)
{