Remove size_request from GtkFixed

This commit is contained in:
Matthias Clasen 2010-10-26 22:28:24 -04:00 committed by Tristan Van Berkom
parent e165c6c884
commit b3f6f67c33

View File

@ -44,8 +44,12 @@ enum {
}; };
static void gtk_fixed_realize (GtkWidget *widget); static void gtk_fixed_realize (GtkWidget *widget);
static void gtk_fixed_size_request (GtkWidget *widget, static void gtk_fixed_get_preferred_width (GtkWidget *widget,
GtkRequisition *requisition); gint *minimum,
gint *natural);
static void gtk_fixed_get_preferred_height (GtkWidget *widget,
gint *minimum,
gint *natural);
static void gtk_fixed_size_allocate (GtkWidget *widget, static void gtk_fixed_size_allocate (GtkWidget *widget,
GtkAllocation *allocation); GtkAllocation *allocation);
static void gtk_fixed_add (GtkContainer *container, static void gtk_fixed_add (GtkContainer *container,
@ -81,25 +85,24 @@ gtk_fixed_class_init (GtkFixedClass *class)
container_class = (GtkContainerClass*) class; container_class = (GtkContainerClass*) class;
widget_class->realize = gtk_fixed_realize; widget_class->realize = gtk_fixed_realize;
widget_class->size_request = gtk_fixed_size_request; widget_class->get_preferred_width = gtk_fixed_get_preferred_width;
widget_class->get_preferred_height = gtk_fixed_get_preferred_height;
widget_class->size_allocate = gtk_fixed_size_allocate; widget_class->size_allocate = gtk_fixed_size_allocate;
container_class->add = gtk_fixed_add; container_class->add = gtk_fixed_add;
container_class->remove = gtk_fixed_remove; container_class->remove = gtk_fixed_remove;
container_class->forall = gtk_fixed_forall; container_class->forall = gtk_fixed_forall;
container_class->child_type = gtk_fixed_child_type; container_class->child_type = gtk_fixed_child_type;
container_class->set_child_property = gtk_fixed_set_child_property; container_class->set_child_property = gtk_fixed_set_child_property;
container_class->get_child_property = gtk_fixed_get_child_property; container_class->get_child_property = gtk_fixed_get_child_property;
gtk_container_class_handle_border_width (container_class);
gtk_container_class_install_child_property (container_class, gtk_container_class_install_child_property (container_class,
CHILD_PROP_X, CHILD_PROP_X,
g_param_spec_int ("x", g_param_spec_int ("x",
P_("X position"), P_("X position"),
P_("X position of child widget"), P_("X position of child widget"),
G_MININT, G_MININT, G_MAXINT, 0,
G_MAXINT,
0,
GTK_PARAM_READWRITE)); GTK_PARAM_READWRITE));
gtk_container_class_install_child_property (container_class, gtk_container_class_install_child_property (container_class,
@ -107,9 +110,7 @@ gtk_fixed_class_init (GtkFixedClass *class)
g_param_spec_int ("y", g_param_spec_int ("y",
P_("Y position"), P_("Y position"),
P_("Y position of child widget"), P_("Y position of child widget"),
G_MININT, G_MININT, G_MAXINT, 0,
G_MAXINT,
0,
GTK_PARAM_READWRITE)); GTK_PARAM_READWRITE));
g_type_class_add_private (class, sizeof (GtkFixedPrivate)); g_type_class_add_private (class, sizeof (GtkFixedPrivate));
@ -124,16 +125,11 @@ gtk_fixed_child_type (GtkContainer *container)
static void static void
gtk_fixed_init (GtkFixed *fixed) gtk_fixed_init (GtkFixed *fixed)
{ {
GtkFixedPrivate *priv; fixed->priv = G_TYPE_INSTANCE_GET_PRIVATE (fixed, GTK_TYPE_FIXED, GtkFixedPrivate);
fixed->priv = G_TYPE_INSTANCE_GET_PRIVATE (fixed,
GTK_TYPE_FIXED,
GtkFixedPrivate);
priv = fixed->priv;
gtk_widget_set_has_window (GTK_WIDGET (fixed), FALSE); gtk_widget_set_has_window (GTK_WIDGET (fixed), FALSE);
priv->children = NULL; fixed->priv->children = NULL;
} }
GtkWidget* GtkWidget*
@ -149,13 +145,11 @@ get_child (GtkFixed *fixed,
GtkFixedPrivate *priv = fixed->priv; GtkFixedPrivate *priv = fixed->priv;
GList *children; GList *children;
children = priv->children; for (children = priv->children; children; children = children->next)
while (children)
{ {
GtkFixedChild *child; GtkFixedChild *child;
child = children->data; child = children->data;
children = children->next;
if (child->widget == widget) if (child->widget == widget)
return child; return child;
@ -188,39 +182,30 @@ gtk_fixed_put (GtkFixed *fixed,
static void static void
gtk_fixed_move_internal (GtkFixed *fixed, gtk_fixed_move_internal (GtkFixed *fixed,
GtkWidget *widget, GtkFixedChild *child,
gboolean change_x,
gint x, gint x,
gboolean change_y,
gint y) gint y)
{ {
GtkFixedChild *child;
g_return_if_fail (GTK_IS_FIXED (fixed)); g_return_if_fail (GTK_IS_FIXED (fixed));
g_return_if_fail (GTK_IS_WIDGET (widget)); g_return_if_fail (gtk_widget_get_parent (child->widget) == GTK_WIDGET (fixed));
g_return_if_fail (gtk_widget_get_parent (widget) == GTK_WIDGET (fixed));
child = get_child (fixed, widget); gtk_widget_freeze_child_notify (child->widget);
g_assert (child); if (child->x != x)
gtk_widget_freeze_child_notify (widget);
if (change_x)
{ {
child->x = x; child->x = x;
gtk_widget_child_notify (widget, "x"); gtk_widget_child_notify (child->widget, "x");
} }
if (change_y) if (child->y != y)
{ {
child->y = y; child->y = y;
gtk_widget_child_notify (widget, "y"); gtk_widget_child_notify (child->widget, "y");
} }
gtk_widget_thaw_child_notify (widget); gtk_widget_thaw_child_notify (child->widget);
if (gtk_widget_get_visible (widget) && if (gtk_widget_get_visible (child->widget) &&
gtk_widget_get_visible (GTK_WIDGET (fixed))) gtk_widget_get_visible (GTK_WIDGET (fixed)))
gtk_widget_queue_resize (GTK_WIDGET (fixed)); gtk_widget_queue_resize (GTK_WIDGET (fixed));
} }
@ -231,7 +216,7 @@ gtk_fixed_move (GtkFixed *fixed,
gint x, gint x,
gint y) gint y)
{ {
gtk_fixed_move_internal (fixed, widget, TRUE, x, TRUE, y); gtk_fixed_move_internal (fixed, get_child (fixed, widget), x, y);
} }
static void static void
@ -241,19 +226,24 @@ gtk_fixed_set_child_property (GtkContainer *container,
const GValue *value, const GValue *value,
GParamSpec *pspec) GParamSpec *pspec)
{ {
GtkFixed *fixed = GTK_FIXED (container);
GtkFixedChild *fixed_child;
fixed_child = get_child (fixed, child);
switch (property_id) switch (property_id)
{ {
case CHILD_PROP_X: case CHILD_PROP_X:
gtk_fixed_move_internal (GTK_FIXED (container), gtk_fixed_move_internal (fixed,
child, fixed_child,
TRUE, g_value_get_int (value), g_value_get_int (value),
FALSE, 0); fixed_child->y);
break; break;
case CHILD_PROP_Y: case CHILD_PROP_Y:
gtk_fixed_move_internal (GTK_FIXED (container), gtk_fixed_move_internal (fixed,
child, fixed_child,
FALSE, 0, fixed_child->x,
TRUE, g_value_get_int (value)); g_value_get_int (value));
break; break;
default: default:
GTK_CONTAINER_WARN_INVALID_CHILD_PROPERTY_ID (container, property_id, pspec); GTK_CONTAINER_WARN_INVALID_CHILD_PROPERTY_ID (container, property_id, pspec);
@ -325,46 +315,59 @@ gtk_fixed_realize (GtkWidget *widget)
} }
static void static void
gtk_fixed_size_request (GtkWidget *widget, gtk_fixed_get_preferred_width (GtkWidget *widget,
GtkRequisition *requisition) gint *minimum,
gint *natural)
{ {
GtkFixedPrivate *priv; GtkFixed *fixed = GTK_FIXED (widget);
GtkFixed *fixed; GtkFixedPrivate *priv = fixed->priv;
GtkFixedChild *child; GtkFixedChild *child;
GList *children; GList *children;
GtkRequisition child_requisition; gint child_min, child_nat;
guint border_width;
fixed = GTK_FIXED (widget); *minimum = 0;
priv = fixed->priv; *natural = 0;
requisition->width = 0; for (children = priv->children; children; children = children->next)
requisition->height = 0;
children = priv->children;
while (children)
{ {
child = children->data; child = children->data;
children = children->next;
if (gtk_widget_get_visible (child->widget)) if (!gtk_widget_get_visible (child->widget))
continue;
gtk_widget_get_preferred_width (child->widget, &child_min, &child_nat);
*minimum = MAX (*minimum, child->y + child_min);
*natural = MAX (*natural, child->y + child_nat);
}
}
static void
gtk_fixed_get_preferred_height (GtkWidget *widget,
gint *minimum,
gint *natural)
{
GtkFixed *fixed = GTK_FIXED (widget);
GtkFixedPrivate *priv = fixed->priv;
GtkFixedChild *child;
GList *children;
gint child_min, child_nat;
*minimum = 0;
*natural = 0;
for (children = priv->children; children; children = children->next)
{ {
gtk_widget_get_preferred_size (child->widget, child = children->data;
&child_requisition,
NULL);
requisition->height = MAX (requisition->height, if (!gtk_widget_get_visible (child->widget))
child->y + continue;
child_requisition.height);
requisition->width = MAX (requisition->width,
child->x +
child_requisition.width);
}
}
border_width = gtk_container_get_border_width (GTK_CONTAINER (fixed)); gtk_widget_get_preferred_height (child->widget, &child_min, &child_nat);
requisition->height += border_width * 2;
requisition->width += border_width * 2; *minimum = MAX (*minimum, child->y + child_min);
*natural = MAX (*natural, child->y + child_nat);
}
} }
static void static void
@ -377,7 +380,6 @@ gtk_fixed_size_allocate (GtkWidget *widget,
GtkAllocation child_allocation; GtkAllocation child_allocation;
GtkRequisition child_requisition; GtkRequisition child_requisition;
GList *children; GList *children;
guint border_width;
gtk_widget_set_allocation (widget, allocation); gtk_widget_set_allocation (widget, allocation);
@ -391,20 +393,16 @@ gtk_fixed_size_allocate (GtkWidget *widget,
allocation->height); allocation->height);
} }
border_width = gtk_container_get_border_width (GTK_CONTAINER (fixed)); for (children = priv->children; children; children = children->next)
children = priv->children;
while (children)
{ {
child = children->data; child = children->data;
children = children->next;
if (gtk_widget_get_visible (child->widget)) if (!gtk_widget_get_visible (child->widget))
{ continue;
gtk_widget_get_preferred_size (child->widget,
&child_requisition, NULL); gtk_widget_get_preferred_size (child->widget, &child_requisition, NULL);
child_allocation.x = child->x + border_width; child_allocation.x = child->x;
child_allocation.y = child->y + border_width; child_allocation.y = child->y;
if (!gtk_widget_get_has_window (widget)) if (!gtk_widget_get_has_window (widget))
{ {
@ -416,7 +414,6 @@ gtk_fixed_size_allocate (GtkWidget *widget,
child_allocation.height = child_requisition.height; child_allocation.height = child_requisition.height;
gtk_widget_size_allocate (child->widget, &child_allocation); gtk_widget_size_allocate (child->widget, &child_allocation);
} }
}
} }
static void static void
@ -436,8 +433,7 @@ gtk_fixed_remove (GtkContainer *container,
GtkWidget *widget_container = GTK_WIDGET (container); GtkWidget *widget_container = GTK_WIDGET (container);
GList *children; GList *children;
children = priv->children; for (children = priv->children; children; children = children->next)
while (children)
{ {
child = children->data; child = children->data;
@ -472,11 +468,9 @@ gtk_fixed_forall (GtkContainer *container,
GtkFixedChild *child; GtkFixedChild *child;
GList *children; GList *children;
children = priv->children; for (children = priv->children; children; children = children->next)
while (children)
{ {
child = children->data; child = children->data;
children = children->next;
(* callback) (child->widget, callback_data); (* callback) (child->widget, callback_data);
} }