AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity

scrolled window: Don't leak timeout sources

Browse Source 
We must only create a new source if there isn't one already,
otherwise we override the ID and leak the previous one.
This commit is contained in:
Matthias Clasen 2017-08-13 09:24:50 -04:00
parent 98089778df
commit b52c1cb8dc
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gtk/gtkscrolledwindow.c
View File

@ -3760,14 +3760,12 @@ indicator_set_fade (Indicator *indicator,
visible = indicator->current_pos != 0.0 || indicator->target_pos != 0.0;
if (visible)
if (visible && indicator->conceil_timer == 0)
{
if (indicator->conceil_timer != 0) g_print ("leaking conceil_timer!\n");
indicator->conceil_timer = g_timeout_add (INDICATOR_FADE_OUT_TIME, maybe_hide_indicator, indicator);
g_source_set_name_by_id (indicator->conceil_timer, "[gtk+] maybe_hide_indicator");
}
if (!visible && gtk_widget_get_mapped (indicator->scrollbar) &&
indicator->conceil_timer != 0)
if (!visible && indicator->conceil_timer != 0)
{
g_source_remove (indicator->conceil_timer);
indicator->conceil_timer = 0;