AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity

Remove obsolete FIXMEs

Browse Source 
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19856
This commit is contained in:
Federico Mena Quintero 2008-03-13 00:47:21 +00:00 committed by Federico Mena Quintero
parent 74f3d16c26
commit b7e32c8dcb
1 changed files with 3 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
gtk/gtkfilechooserentry.c
View File

@ -859,7 +859,7 @@ install_completion_feedback_timer (GtkFileChooserEntry *chooser_entry)
chooser_entry); chooser_entry);
} }
/* Gets the (x, y) position of the text cursor in the entry, in widget coordinates */ /* Gets the x position of the text cursor in the entry, in widget coordinates */
static void static void
get_entry_cursor_x (GtkFileChooserEntry *chooser_entry, get_entry_cursor_x (GtkFileChooserEntry *chooser_entry,
gint *x_ret) gint *x_ret)
@ -951,9 +951,9 @@ explicitly_complete (GtkFileChooserEntry *chooser_entry)
/* FIXME: see what Emacs does in case there is no common prefix, or there is more than one match: /* FIXME: see what Emacs does in case there is no common prefix, or there is more than one match:
* *
* - If there is a common prefix, insert it * - If there is a common prefix, insert it (done)
* - If there is no common prefix, pop up the suggestion window * - If there is no common prefix, pop up the suggestion window
* - If there are no matches at all, beep and bring up a tooltip * - If there are no matches at all, beep and bring up a tooltip (done)
* - If the suggestion window is already up, scroll it * - If the suggestion window is already up, scroll it
*/ */
result = append_common_prefix (chooser_entry, FALSE, TRUE); result = append_common_prefix (chooser_entry, FALSE, TRUE);
@ -989,14 +989,6 @@ explicitly_complete (GtkFileChooserEntry *chooser_entry)
default: default:
g_assert_not_reached (); g_assert_not_reached ();
} }
/* FIXME: this bit of code is commented out for reference; this is how we used to force the suggestion window to pop up
*
* Trigger the completion window to pop up again by a
* zero-length insertion, a bit of a hack.
*
* gtk_editable_insert_text (editable, "", -1, &pos);
*/
} }
static void static void
@ -1010,7 +1002,6 @@ start_explicit_completion (GtkFileChooserEntry *chooser_entry)
beep (chooser_entry); beep (chooser_entry);
pop_up_completion_feedback (chooser_entry, _("Invalid path")); pop_up_completion_feedback (chooser_entry, _("Invalid path"));
/* FIXME: make refresh_up_to_cursor_position() return a GError, and show that instead of "invalid path" */
chooser_entry->load_complete_action = LOAD_COMPLETE_NOTHING; chooser_entry->load_complete_action = LOAD_COMPLETE_NOTHING;
return; return;