Oct 26 20:55:57 2001 Owen Taylor <otaylor@redhat.com>

* gtk/gtkbutton.c: Revert changes to GTK_RUN_LAST.
        Unfortunately, people apparently erroneously connect
        to ::clicked for GtkToggleButton and expect
        they know what happened in the default signal handler
        instead of appropriately connecting to notification
        signal ::toggled. When the revolution comes, such
        people will be first against the wall.

        We'll just have to go back to the old less-reliable
        set-it-back hacks for handling model-view toggle
        buttons and entries. :-(.
This commit is contained in:
Owen Taylor 2001-10-27 00:59:51 +00:00
parent c226dd70fd
commit c860d735bd
8 changed files with 104 additions and 6 deletions

View File

@ -1,3 +1,17 @@
Fri Oct 26 20:55:57 2001 Owen Taylor <otaylor@redhat.com>
* gtk/gtkbutton.c: Revert changes to GTK_RUN_LAST.
Unfortunately, people apparently erroneously connect
to ::clicked for GtkToggleButton and expect
they know what happened in the default signal handler
instead of appropriately connecting to notification
signal ::toggled. When the revolution comes, such
people will be first against the wall.
We'll just have to go back to the old less-reliable
set-it-back hacks for handling model-view toggle
buttons and entries. :-(.
2001-10-27 Hans Breuer <hans@breuer.org>
* gtk/gtkbbox.c gtk/gtkctree.c gtk/gtkhbbox.c

View File

@ -1,3 +1,17 @@
Fri Oct 26 20:55:57 2001 Owen Taylor <otaylor@redhat.com>
* gtk/gtkbutton.c: Revert changes to GTK_RUN_LAST.
Unfortunately, people apparently erroneously connect
to ::clicked for GtkToggleButton and expect
they know what happened in the default signal handler
instead of appropriately connecting to notification
signal ::toggled. When the revolution comes, such
people will be first against the wall.
We'll just have to go back to the old less-reliable
set-it-back hacks for handling model-view toggle
buttons and entries. :-(.
2001-10-27 Hans Breuer <hans@breuer.org>
* gtk/gtkbbox.c gtk/gtkctree.c gtk/gtkhbbox.c

View File

@ -1,3 +1,17 @@
Fri Oct 26 20:55:57 2001 Owen Taylor <otaylor@redhat.com>
* gtk/gtkbutton.c: Revert changes to GTK_RUN_LAST.
Unfortunately, people apparently erroneously connect
to ::clicked for GtkToggleButton and expect
they know what happened in the default signal handler
instead of appropriately connecting to notification
signal ::toggled. When the revolution comes, such
people will be first against the wall.
We'll just have to go back to the old less-reliable
set-it-back hacks for handling model-view toggle
buttons and entries. :-(.
2001-10-27 Hans Breuer <hans@breuer.org>
* gtk/gtkbbox.c gtk/gtkctree.c gtk/gtkhbbox.c

View File

@ -1,3 +1,17 @@
Fri Oct 26 20:55:57 2001 Owen Taylor <otaylor@redhat.com>
* gtk/gtkbutton.c: Revert changes to GTK_RUN_LAST.
Unfortunately, people apparently erroneously connect
to ::clicked for GtkToggleButton and expect
they know what happened in the default signal handler
instead of appropriately connecting to notification
signal ::toggled. When the revolution comes, such
people will be first against the wall.
We'll just have to go back to the old less-reliable
set-it-back hacks for handling model-view toggle
buttons and entries. :-(.
2001-10-27 Hans Breuer <hans@breuer.org>
* gtk/gtkbbox.c gtk/gtkctree.c gtk/gtkhbbox.c

View File

@ -1,3 +1,17 @@
Fri Oct 26 20:55:57 2001 Owen Taylor <otaylor@redhat.com>
* gtk/gtkbutton.c: Revert changes to GTK_RUN_LAST.
Unfortunately, people apparently erroneously connect
to ::clicked for GtkToggleButton and expect
they know what happened in the default signal handler
instead of appropriately connecting to notification
signal ::toggled. When the revolution comes, such
people will be first against the wall.
We'll just have to go back to the old less-reliable
set-it-back hacks for handling model-view toggle
buttons and entries. :-(.
2001-10-27 Hans Breuer <hans@breuer.org>
* gtk/gtkbbox.c gtk/gtkctree.c gtk/gtkhbbox.c

View File

@ -1,3 +1,17 @@
Fri Oct 26 20:55:57 2001 Owen Taylor <otaylor@redhat.com>
* gtk/gtkbutton.c: Revert changes to GTK_RUN_LAST.
Unfortunately, people apparently erroneously connect
to ::clicked for GtkToggleButton and expect
they know what happened in the default signal handler
instead of appropriately connecting to notification
signal ::toggled. When the revolution comes, such
people will be first against the wall.
We'll just have to go back to the old less-reliable
set-it-back hacks for handling model-view toggle
buttons and entries. :-(.
2001-10-27 Hans Breuer <hans@breuer.org>
* gtk/gtkbbox.c gtk/gtkctree.c gtk/gtkhbbox.c

View File

@ -1,3 +1,17 @@
Fri Oct 26 20:55:57 2001 Owen Taylor <otaylor@redhat.com>
* gtk/gtkbutton.c: Revert changes to GTK_RUN_LAST.
Unfortunately, people apparently erroneously connect
to ::clicked for GtkToggleButton and expect
they know what happened in the default signal handler
instead of appropriately connecting to notification
signal ::toggled. When the revolution comes, such
people will be first against the wall.
We'll just have to go back to the old less-reliable
set-it-back hacks for handling model-view toggle
buttons and entries. :-(.
2001-10-27 Hans Breuer <hans@breuer.org>
* gtk/gtkbbox.c gtk/gtkctree.c gtk/gtkhbbox.c

View File

@ -212,42 +212,42 @@ gtk_button_class_init (GtkButtonClass *klass)
button_signals[PRESSED] =
gtk_signal_new ("pressed",
GTK_RUN_LAST,
GTK_RUN_FIRST,
GTK_CLASS_TYPE (object_class),
GTK_SIGNAL_OFFSET (GtkButtonClass, pressed),
gtk_marshal_VOID__VOID,
GTK_TYPE_NONE, 0);
button_signals[RELEASED] =
gtk_signal_new ("released",
GTK_RUN_LAST,
GTK_RUN_FIRST,
GTK_CLASS_TYPE (object_class),
GTK_SIGNAL_OFFSET (GtkButtonClass, released),
gtk_marshal_VOID__VOID,
GTK_TYPE_NONE, 0);
button_signals[CLICKED] =
gtk_signal_new ("clicked",
GTK_RUN_LAST | GTK_RUN_ACTION,
GTK_RUN_FIRST | GTK_RUN_ACTION,
GTK_CLASS_TYPE (object_class),
GTK_SIGNAL_OFFSET (GtkButtonClass, clicked),
gtk_marshal_VOID__VOID,
GTK_TYPE_NONE, 0);
button_signals[ENTER] =
gtk_signal_new ("enter",
GTK_RUN_LAST,
GTK_RUN_FIRST,
GTK_CLASS_TYPE (object_class),
GTK_SIGNAL_OFFSET (GtkButtonClass, enter),
gtk_marshal_VOID__VOID,
GTK_TYPE_NONE, 0);
button_signals[LEAVE] =
gtk_signal_new ("leave",
GTK_RUN_LAST,
GTK_RUN_FIRST,
GTK_CLASS_TYPE (object_class),
GTK_SIGNAL_OFFSET (GtkButtonClass, leave),
gtk_marshal_VOID__VOID,
GTK_TYPE_NONE, 0);
button_signals[ACTIVATE] =
gtk_signal_new ("activate",
GTK_RUN_LAST,
GTK_RUN_FIRST,
GTK_CLASS_TYPE (object_class),
GTK_SIGNAL_OFFSET (GtkButtonClass, activate),
gtk_marshal_VOID__VOID,