AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity

text: Don't compute invisible char needlessly

Browse Source 
There is no real reason to do expensive text layout
operations unless we need the invisible char because
the text's visibilty is FALSE.
This commit is contained in:
Matthias Clasen 2020-08-23 15:12:57 -04:00
parent c0191c7225
commit ca0f136deb
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
gtk/gtktext.c
View File

@ -3441,7 +3441,7 @@ gtk_text_update_cached_style_values (GtkText *self)
{ {
GtkTextPrivate *priv = gtk_text_get_instance_private (self); GtkTextPrivate *priv = gtk_text_get_instance_private (self);
if (!priv->invisible_char_set) if (!priv->visible && !priv->invisible_char_set)
{ {
gunichar ch = find_invisible_char (GTK_WIDGET (self)); gunichar ch = find_invisible_char (GTK_WIDGET (self));
@ -5550,11 +5550,13 @@ gtk_text_set_invisible_char (GtkText *self,
* @self: a #GtkText * @self: a #GtkText
* *
* Retrieves the character displayed in place of the real characters * Retrieves the character displayed in place of the real characters
* for entries with visibility set to false. * for entries with visibility set to false. Note that GTK does not
* See gtk_text_set_invisible_char(). * compute this value unless it needs it, so the value returned by
* this function is not very useful unless it has been explicitly
* set with gtk_text_set_invisible_char()
* *
* Returns: the current invisible char, or 0, if the self does not * Returns: the current invisible char, or 0, if @text does not
* show invisible text at all. * show invisible text at all.
**/ **/
gunichar gunichar
gtk_text_get_invisible_char (GtkText *self) gtk_text_get_invisible_char (GtkText *self)