GtkSocket: Add error trap around call to XFixesChangeSaveSet()

Previously any X error from XFixesChangeSaveSet() was being eaten
by the subsequent error trap when sending a client message. With
asynchronous error traps, that side effect no longer occurs, so
we need to add a proper error trap around the call to
XFixesChangeSaveSet().

https://bugzilla.gnome.org/show_bug.cgi?id=633274
This commit is contained in:
Owen W. Taylor 2010-10-27 12:40:59 -04:00 committed by Matthias Clasen
parent d13bf0801d
commit cb287cde00

View File

@ -281,9 +281,11 @@ _gtk_socket_windowing_embed_notify (GtkSocket *socket)
#ifdef HAVE_XFIXES
GdkDisplay *display = gtk_widget_get_display (GTK_WIDGET (socket));
gdk_error_trap_push ();
XFixesChangeSaveSet (GDK_DISPLAY_XDISPLAY (display),
GDK_WINDOW_XWINDOW (socket->plug_window),
SetModeInsert, SaveSetRoot, SaveSetUnmap);
gdk_error_trap_pop_ignore ();
#endif
_gtk_xembed_send_message (socket->plug_window,
XEMBED_EMBEDDED_NOTIFY, 0,