AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity

range: Don't leave css nodes behind

Browse Source 
We create and destroy gadgets inside the range hierarchy here,
and if we don't explicitly remove their CSS nodes from the parent,
they stick around.
This commit is contained in:
Matthias Clasen 2016-03-01 15:48:01 -05:00
parent 37007c47a5
commit cb614cc838
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gtk/gtkrange.c
View File

@ -1568,6 +1568,7 @@ gtk_range_set_show_fill_level (GtkRange *range,
} }
else else
{ {
gtk_css_node_set_parent (gtk_css_gadget_get_node (priv->fill_gadget), NULL);
g_clear_object (&priv->fill_gadget); g_clear_object (&priv->fill_gadget);
} }
@ -3807,6 +3808,7 @@ _gtk_range_set_has_origin (GtkRange *range,
} }
else else
{ {
gtk_css_node_set_parent (gtk_css_gadget_get_node (priv->highlight_gadget), NULL);
g_clear_object (&priv->highlight_gadget); g_clear_object (&priv->highlight_gadget);
} }
} }
@ -3917,7 +3919,10 @@ sync_stepper_gadget (GtkRange *range,
if (!should_have_stepper) if (!should_have_stepper)
{ {
if (*gadget_ptr != NULL) if (*gadget_ptr != NULL)
gtk_box_gadget_remove_gadget (GTK_BOX_GADGET (priv->contents_gadget), *gadget_ptr); {
gtk_css_node_set_parent (gtk_css_gadget_get_node (*gadget_ptr), NULL);
gtk_box_gadget_remove_gadget (GTK_BOX_GADGET (priv->contents_gadget), *gadget_ptr);
}
g_clear_object (gadget_ptr); g_clear_object (gadget_ptr);
return; return;
} }