From 2a92ee22da585b3378c4a4dd7863f3b855ec1ae0 Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Tue, 28 Jul 2020 21:53:56 -0400 Subject: [PATCH 1/9] gdk: Small doc fixup We no longer use for plurals, gtk-doc is smart enough to detect them without that. --- gdk/gdkseat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdk/gdkseat.c b/gdk/gdkseat.c index 8b6a88997c..9c29968ae7 100644 --- a/gdk/gdkseat.c +++ b/gdk/gdkseat.c @@ -465,7 +465,7 @@ gdk_seat_get_tool (GdkSeat *seat, * gdk_seat_get_tools: * @seat: A #GdkSeat * - * Returns all #GdkDeviceTools that are known to the + * Returns all #GdkDeviceTools that are known to the * application. * * Returns: (transfer container) (element-type Gdk.DeviceTool): A list of tools. Free with From fc47e79cb6816ab36862a2882b2b9d2ece7821be Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Tue, 28 Jul 2020 21:58:06 -0400 Subject: [PATCH 2/9] Document gdk_device_tool_get_axes --- gdk/gdkdevicetool.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/gdk/gdkdevicetool.c b/gdk/gdkdevicetool.c index efd3a6c6a7..0cfcf800bf 100644 --- a/gdk/gdkdevicetool.c +++ b/gdk/gdkdevicetool.c @@ -210,6 +210,14 @@ gdk_device_tool_get_tool_type (GdkDeviceTool *tool) return tool->type; } +/** + * gdk_device_tool_get_axes: + * @tool: a #GdkDeviceTool + * + * Gets the axes of the tool. + * + * Returns: the axes of @tool + */ GdkAxisFlags gdk_device_tool_get_axes (GdkDeviceTool *tool) { From e07b9605bcc70b34f503d286916dcb9c056878ec Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Tue, 28 Jul 2020 22:07:44 -0400 Subject: [PATCH 3/9] a11y: Fix a few glitches in the role enum When the enumeration was synced with the latest draft of the ARIA spec, the math and note roles missed the boat. --- gtk/gtkenums.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/gtk/gtkenums.h b/gtk/gtkenums.h index 436d2ac39d..6fcb418daf 100644 --- a/gtk/gtkenums.h +++ b/gtk/gtkenums.h @@ -1187,19 +1187,21 @@ typedef enum { * @GTK_ACCESSIBLE_ROLE_LANDMARK: Unused * @GTK_ACCESSIBLE_ROLE_LEGEND: Unused * @GTK_ACCESSIBLE_ROLE_LINK: Unused + * @GTK_ACCESSIBLE_ROLE_LIST: Unused * @GTK_ACCESSIBLE_ROLE_LIST_BOX: Unused * @GTK_ACCESSIBLE_ROLE_LIST_ITEM: Unused * @GTK_ACCESSIBLE_ROLE_LOG: Unused * @GTK_ACCESSIBLE_ROLE_MAIN: Unused * @GTK_ACCESSIBLE_ROLE_MARQUEE: Unused - * @GTK_ACCESSIBLE_ROLE_METER: Unused * @GTK_ACCESSIBLE_ROLE_MATH: Unused + * @GTK_ACCESSIBLE_ROLE_METER: Unused * @GTK_ACCESSIBLE_ROLE_MENU: Unused * @GTK_ACCESSIBLE_ROLE_MENU_BAR: Unused * @GTK_ACCESSIBLE_ROLE_MENU_ITEM: Unused * @GTK_ACCESSIBLE_ROLE_MENU_ITEM_CHECKBOX: Unused * @GTK_ACCESSIBLE_ROLE_MENU_ITEM_RADIO: Unused * @GTK_ACCESSIBLE_ROLE_NAVIGATION: Unused + * @GTK_ACCESSIBLE_ROLE_NONE: Unused * @GTK_ACCESSIBLE_ROLE_NOTE: Unused * @GTK_ACCESSIBLE_ROLE_OPTION: Unused * @GTK_ACCESSIBLE_ROLE_PRESENTATION: Unused @@ -1285,6 +1287,7 @@ typedef enum { GTK_ACCESSIBLE_ROLE_LOG, GTK_ACCESSIBLE_ROLE_MAIN, GTK_ACCESSIBLE_ROLE_MARQUEE, + GTK_ACCESSIBLE_ROLE_MATH, GTK_ACCESSIBLE_ROLE_METER, GTK_ACCESSIBLE_ROLE_MENU, GTK_ACCESSIBLE_ROLE_MENU_BAR, @@ -1293,6 +1296,7 @@ typedef enum { GTK_ACCESSIBLE_ROLE_MENU_ITEM_RADIO, GTK_ACCESSIBLE_ROLE_NAVIGATION, GTK_ACCESSIBLE_ROLE_NONE, + GTK_ACCESSIBLE_ROLE_NOTE, GTK_ACCESSIBLE_ROLE_OPTION, GTK_ACCESSIBLE_ROLE_PRESENTATION, GTK_ACCESSIBLE_ROLE_PROGRESS_BAR, From 1772d23f8ec5321902372d882ce06355f57a2636 Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Tue, 28 Jul 2020 22:08:37 -0400 Subject: [PATCH 4/9] docs: Update private headers list --- docs/reference/gtk/meson.build | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/docs/reference/gtk/meson.build b/docs/reference/gtk/meson.build index d13686fec7..4334af35f0 100644 --- a/docs/reference/gtk/meson.build +++ b/docs/reference/gtk/meson.build @@ -6,17 +6,24 @@ private_headers = [ 'gdkpixbufutilsprivate.h', 'gtkaccelgroupprivate.h', 'gtkaccelmapprivate.h', + 'gtkaccessibleattributesetprivate.h', + 'gtkaccessibleattributevalueprivate.h', + 'gtkaccessibleprivate.h', + 'gtkaccessiblevalueprivate.h', 'gtkactionhelperprivate.h', 'gtkactionmuxerprivate.h', + 'gtkactionobservableprivate.h', + 'gtkactionobserverprivate.h', 'gtkadjustmentprivate.h', 'gtkallocatedbitmaskprivate.h', 'gtkappchooserprivate.h', 'gtkapplicationaccelsprivate.h', 'gtkapplicationprivate.h', - 'gtkarrayimplprivate.h', + 'gtkatcontextprivate.h', 'gtkbindingsprivate.h', 'gtkbitmaskprivate.h', 'gtkbuilderprivate.h', + 'gtkbuilderscopeprivate.h', 'gtkbuttonprivate.h', 'gtkcellareaboxcontextprivate.h', 'gtkcheckbuttonprivate.h', @@ -45,6 +52,7 @@ private_headers = [ 'gtkcssarrayvalueprivate.h', 'gtkcssbgsizevalueprivate.h', 'gtkcssbordervalueprivate.h', + 'gtkcssboxesimplprivate.h', 'gtkcssboxesprivate.h', 'gtkcsscalcvalueprivate.h', 'gtkcsscolorvalueprivate.h', From e4a37467559f158362d4666a5f8cb958c335b339 Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Tue, 28 Jul 2020 22:18:52 -0400 Subject: [PATCH 5/9] docs: Update the symbols list Make sure the sections file is in sync with what we actually export. --- docs/reference/gtk/gtk4-sections.txt | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/docs/reference/gtk/gtk4-sections.txt b/docs/reference/gtk/gtk4-sections.txt index 943e9ab771..3f886e0d78 100644 --- a/docs/reference/gtk/gtk4-sections.txt +++ b/docs/reference/gtk/gtk4-sections.txt @@ -862,7 +862,6 @@ gtk_combo_box_set_active_id gtk_combo_box_get_model gtk_combo_box_set_model gtk_combo_box_popdown -gtk_combo_box_get_popup_accessible gtk_combo_box_get_row_separator_func gtk_combo_box_set_row_separator_func GtkSensitivityType @@ -1204,9 +1203,6 @@ gtk_entry_completion_compute_prefix gtk_entry_completion_complete gtk_entry_completion_get_completion_prefix gtk_entry_completion_insert_prefix -gtk_entry_completion_insert_action_text -gtk_entry_completion_insert_action_markup -gtk_entry_completion_delete_action gtk_entry_completion_set_text_column gtk_entry_completion_get_text_column gtk_entry_completion_set_inline_completion @@ -2813,7 +2809,7 @@ gtk_sort_list_model_set_model gtk_sort_list_model_get_model gtk_sort_list_model_set_incremental gtk_sort_list_model_get_incremental -gtk_sort_list_model_get_peanding +gtk_sort_list_model_get_pending GTK_SORT_LIST_MODEL GTK_IS_SORT_LIST_MODEL @@ -4055,7 +4051,6 @@ GtkCellRendererState GtkCellRendererMode GtkCellRenderer GtkCellRendererClass -gtk_cell_renderer_class_set_accessible_type gtk_cell_renderer_get_aligned_area gtk_cell_renderer_snapshot gtk_cell_renderer_activate @@ -4468,9 +4463,7 @@ gtk_widget_get_cursor gtk_widget_set_cursor gtk_widget_set_cursor_from_name gtk_widget_mnemonic_activate -gtk_widget_class_set_accessible_type gtk_widget_class_set_accessible_role -gtk_widget_get_accessible gtk_widget_child_focus gtk_widget_get_child_visible gtk_widget_get_parent From 07bf9045fbc316bf10657ec0c1a53bbe933c82d0 Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Tue, 28 Jul 2020 22:19:35 -0400 Subject: [PATCH 6/9] a11y: Document GtkATContext::state-changed --- gtk/gtkatcontext.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/gtk/gtkatcontext.c b/gtk/gtkatcontext.c index aefce4df4f..f38b5921de 100644 --- a/gtk/gtkatcontext.c +++ b/gtk/gtkatcontext.c @@ -172,6 +172,19 @@ gtk_at_context_class_init (GtkATContextClass *klass) G_PARAM_CONSTRUCT_ONLY | G_PARAM_STATIC_STRINGS); + /** + * GtkATContext::state-change: + * @self: the #GtkATContext + * @changed_states: flags for the changed states + * @changed_properties: flags for the changed properties + * @changed_relations, + * @states: the new states + * @properties: the new properties + * @relations: the new relations + * + * Emitted when the attributes of the accessible for the + * #GtkATContext instance change. + */ obj_signals[STATE_CHANGE] = g_signal_new ("state-change", G_TYPE_FROM_CLASS (gobject_class), From 26200c0f7eb295a8c32e0a03fbbfeefa1e50b9a8 Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Tue, 28 Jul 2020 22:19:59 -0400 Subject: [PATCH 7/9] filechooser: Document the response.activate action --- gtk/gtkfilechooserdialog.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/gtk/gtkfilechooserdialog.c b/gtk/gtkfilechooserdialog.c index 9eebd2dae0..6870bccb1c 100644 --- a/gtk/gtkfilechooserdialog.c +++ b/gtk/gtkfilechooserdialog.c @@ -304,6 +304,11 @@ gtk_file_chooser_dialog_class_init (GtkFileChooserDialogClass *class) gtk_widget_class_bind_template_child_private (widget_class, GtkFileChooserDialog, buttons); gtk_widget_class_bind_template_callback (widget_class, response_cb); + /** + * GtkFileChooserDialog|response.activate: + * + * Activate the default response of the dialog. + */ gtk_widget_class_install_action (widget_class, "response.activate", NULL, gtk_file_chooser_dialog_activate_response); } From d0abe5a9196ec24f0a2bd7c9e4915ee6202373f8 Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Tue, 28 Jul 2020 22:20:19 -0400 Subject: [PATCH 8/9] filter: Typo fix --- gtk/gtkfilter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gtk/gtkfilter.c b/gtk/gtkfilter.c index fc3d63efaf..6ea692e45c 100644 --- a/gtk/gtkfilter.c +++ b/gtk/gtkfilter.c @@ -83,7 +83,7 @@ gtk_filter_class_init (GtkFilterClass *class) class->get_strictness = gtk_filter_default_get_strictness; /** - * GtkFilter:changed: + * GtkFilter::changed: * @self: The #GtkFilter * @change: how the filter changed * From 3b35ae870cb09b8aed2ba6c8b931546ac740ff1f Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Tue, 28 Jul 2020 22:39:31 -0400 Subject: [PATCH 9/9] docs: Add a missing symbol --- docs/reference/gtk/gtk4-sections.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/reference/gtk/gtk4-sections.txt b/docs/reference/gtk/gtk4-sections.txt index 3f886e0d78..85bcb0038c 100644 --- a/docs/reference/gtk/gtk4-sections.txt +++ b/docs/reference/gtk/gtk4-sections.txt @@ -7638,6 +7638,7 @@ GtkAccessibleTristate GtkAccessibleInvalidState GtkAccessibleAutocomplete GtkAccessibleSort +gtk_accessible_get_accessible_role gtk_accessible_update_state gtk_accessible_update_state_value gtk_accessible_reset_state