AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity

grid: Swap wrong spacing properties

Browse Source 
row-spacing behaved like column-spacing should have and vice versa.

Also update tests that erroneously checked this behavior.

Thanks to Joanmarie Diggs for finding this.
This commit is contained in:
Benjamin Otte 2011-08-30 15:11:02 +02:00
parent b314f03bf4
commit d717a2dcfc
3 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
gtk/gtkgrid.c
View File

@ -163,11 +163,11 @@ gtk_grid_get_property (GObject *object,
break;
case PROP_ROW_SPACING:
g_value_set_int (value, ROWS (priv)->spacing);
g_value_set_int (value, COLUMNS (priv)->spacing);
break;
case PROP_COLUMN_SPACING:
g_value_set_int (value, COLUMNS (priv)->spacing);
g_value_set_int (value, ROWS (priv)->spacing);
break;
case PROP_ROW_HOMOGENEOUS:
@ -1821,9 +1821,9 @@ gtk_grid_set_row_spacing (GtkGrid *grid,
priv = grid->priv;
if (ROWS (priv)->spacing != spacing)
if (COLUMNS (priv)->spacing != spacing)
{
ROWS (priv)->spacing = spacing;
COLUMNS (priv)->spacing = spacing;
if (gtk_widget_get_visible (GTK_WIDGET (grid)))
gtk_widget_queue_resize (GTK_WIDGET (grid));
@ -1848,7 +1848,7 @@ gtk_grid_get_row_spacing (GtkGrid *grid)
priv = grid->priv;
return ROWS (priv)->spacing;
return COLUMNS (priv)->spacing;
}
/**
@ -1868,9 +1868,9 @@ gtk_grid_set_column_spacing (GtkGrid *grid,
priv = grid->priv;
if (COLUMNS (priv)->spacing != spacing)
if (ROWS (priv)->spacing != spacing)
{
COLUMNS (priv)->spacing = spacing;
ROWS (priv)->spacing = spacing;
if (gtk_widget_get_visible (GTK_WIDGET (grid)))
gtk_widget_queue_resize (GTK_WIDGET (grid));
@ -1896,5 +1896,5 @@ gtk_grid_get_column_spacing (GtkGrid *grid)
priv = grid->priv;
return COLUMNS (priv)->spacing;
return ROWS (priv)->spacing;
}

2
tests/reftests/grid-spacing1.ui
View File

@ -13,7 +13,7 @@
<object class="GtkGrid" id="grid0">
<property name="visible">True</property>
<property name="can_focus">False</property>
<property name="row-spacing">20</property>
<property name="column-spacing">20</property>
<child>
<object class="GtkLabel" id="one">
<property name="visible">True</property>

2
tests/reftests/grid-spacing2.ui
View File

@ -13,7 +13,7 @@
<object class="GtkGrid" id="grid0">
<property name="visible">True</property>
<property name="can_focus">False</property>
<property name="column-spacing">20</property>
<property name="row-spacing">20</property>
<child>
<object class="GtkLabel" id="one">
<property name="visible">True</property>