AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity

Don't deprecate gtk_widget_show_all()

Browse Source 
After discussions on IRC, the conclusion was reached that deprecations
only make sense if an action can be taken to not use the deprecated code
that makes the code more current and simplifies a later port to a newer
GTK version.

In this particular case, the suitable action would be adding
gtk_widget_show() calls whenever a widget is created, so that a call to
show_all() is not necessary.
However, in GTK4 these calls would not be necessary and end up just
bloating the codebase unnecessarily.

So it was decided the better solution would be to not deprecate the API
and instead leave this work to be done during potential GTK4 ports of
applications.

This reverts commit 4d71d2303d.

Fixes !1282
This commit is contained in:
Benjamin Otte 2018-08-22 19:48:20 +02:00
parent 2b9f5e9e32
commit da8994f941
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gtk/gtkwidget.c
View File

@ -1260,7 +1260,7 @@ G_GNUC_END_IGNORE_DEPRECATIONS
P_("No show all"),
P_("Whether gtk_widget_show_all() should not affect this widget"),
FALSE,
GTK_PARAM_READWRITE|G_PARAM_EXPLICIT_NOTIFY|G_PARAM_DEPRECATED);
GTK_PARAM_READWRITE|G_PARAM_EXPLICIT_NOTIFY);
/**
* GtkWidget:has-tooltip:

6
gtk/gtkwidget.h
View File

@ -628,12 +628,12 @@ GDK_AVAILABLE_IN_ALL
void gtk_widget_hide (GtkWidget *widget);
GDK_AVAILABLE_IN_ALL
void gtk_widget_show_now (GtkWidget *widget);
GDK_DEPRECATED_IN_3_24
GDK_AVAILABLE_IN_ALL
void gtk_widget_show_all (GtkWidget *widget);
GDK_DEPRECATED_IN_3_24
GDK_AVAILABLE_IN_ALL
void gtk_widget_set_no_show_all (GtkWidget *widget,
gboolean no_show_all);
GDK_DEPRECATED_IN_3_24
GDK_AVAILABLE_IN_ALL
gboolean gtk_widget_get_no_show_all (GtkWidget *widget);
GDK_AVAILABLE_IN_ALL
void gtk_widget_map (GtkWidget *widget);