AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity

popover: Change default for cascade-popdown

Browse Source 
We've found a number of cases where this cascading
has unexpected side-effects. So, turn it off by
default, and only set it for menus.
This commit is contained in:
Matthias Clasen 2020-11-03 10:23:34 -05:00
parent a3f3dc0f1c
commit dab11ea841
3 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
demos/widget-factory/widget-factory.ui
View File

@ -3220,7 +3220,7 @@ bad things might happen.</property>
<object class="GtkMenuButton">
<property name="halign">end</property>
<property name="icon-name">emblem-system-symbolic</property>
<property name="menu-model">gear_menu</property>
<property name="menu-model">gear_menu_model</property>
<property name="tooltip-text">This is a menu button</property>
<layout>
<property name="column">1</property>

4
gtk/gtkpopover.c
View File

@ -839,7 +839,7 @@ gtk_popover_init (GtkPopover *popover)
priv->final_position = GTK_POS_BOTTOM;
priv->autohide = TRUE;
priv->has_arrow = TRUE;
priv->cascade_popdown = TRUE;
priv->cascade_popdown = FALSE;
controller = gtk_event_controller_key_new ();
g_signal_connect_swapped (controller, "key-pressed", G_CALLBACK (gtk_popover_key_pressed), popover);
@ -1674,7 +1674,7 @@ gtk_popover_class_init (GtkPopoverClass *klass)
g_param_spec_boolean ("cascade-popdown",
P_("Cascade popdown"),
P_("Wether the popover pops down after a child popover"),
TRUE,
FALSE,
GTK_PARAM_READWRITE|G_PARAM_EXPLICIT_NOTIFY);
g_object_class_install_properties (object_class, NUM_PROPERTIES, properties);

1
gtk/gtkpopovermenu.c
View File

@ -309,6 +309,7 @@ gtk_popover_menu_init (GtkPopoverMenu *popover)
g_free (controllers);
gtk_popover_disable_auto_mnemonics (GTK_POPOVER (popover));
gtk_popover_set_cascade_popdown (GTK_POPOVER (popover), TRUE);
}
static void