From e3568419579af7a8682dd7e4065a47be6e6a370e Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Fri, 22 Aug 2014 11:04:07 -0400 Subject: [PATCH] GtkBuilder: Improve error messages No `' looks just terrible. For quoting in non-UI contexts, we prefer either '' or "". https://bugzilla.gnome.org/show_bug.cgi?id=735192 --- gtk/gtkbuilder-menus.c | 2 +- gtk/gtkbuilderparser.c | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/gtk/gtkbuilder-menus.c b/gtk/gtkbuilder-menus.c index 1b36f6828e..8a42faa9f9 100644 --- a/gtk/gtkbuilder-menus.c +++ b/gtk/gtkbuilder-menus.c @@ -314,7 +314,7 @@ gtk_builder_menu_text (GMarkupParseContext *context, else g_set_error (error, G_MARKUP_ERROR, G_MARKUP_ERROR_INVALID_CONTENT, - _("text may not appear inside <%s>"), + _("Text may not appear inside <%s>"), g_markup_parse_context_get_element (context)); break; } diff --git a/gtk/gtkbuilderparser.c b/gtk/gtkbuilderparser.c index 9b34993866..ab7d3d49a8 100644 --- a/gtk/gtkbuilderparser.c +++ b/gtk/gtkbuilderparser.c @@ -337,7 +337,7 @@ parse_object (GMarkupParseContext *context, g_markup_parse_context_get_position (context, &line, NULL); g_set_error (error, GTK_BUILDER_ERROR, GTK_BUILDER_ERROR_INVALID_VALUE, - _("Invalid object type `%s' on line %d"), + _("Invalid object type '%s' on line %d"), values[i], line); return; } @@ -772,7 +772,7 @@ parse_signal (ParserData *data, g_markup_parse_context_get_position (data->ctx, &line, NULL); g_set_error (error, GTK_BUILDER_ERROR, GTK_BUILDER_ERROR_INVALID_SIGNAL, - _("Invalid signal `%s' for type `%s' on line %d"), + _("Invalid signal '%s' for type '%s' on line %d"), values[i], g_type_name (object_info->type), line); return; } @@ -1064,7 +1064,7 @@ start_element (GMarkupParseContext *context, { g_set_error (error, GTK_BUILDER_ERROR, GTK_BUILDER_ERROR_UNHANDLED_TAG, - _("Invalid root element: '%s'"), + _("Invalid root element: <%s>"), element_name); return; } @@ -1107,7 +1107,7 @@ start_element (GMarkupParseContext *context, data, error)) g_set_error (error, GTK_BUILDER_ERROR, GTK_BUILDER_ERROR_UNHANDLED_TAG, - _("Unhandled tag: '%s'"), + _("Unhandled tag: <%s>"), element_name); }