AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity

remove some debug code that seems to have caused a breakpoint in valid

Browse Source 
2001-09-07  Havoc Pennington  <hp@redhat.com>

	* gtk/gtktextlayout.c (gtk_text_layout_get_lines): remove some
	debug code that seems to have caused a breakpoint in valid cases

	* gtk/gtktextbtree.c (_gtk_text_btree_add_view): set the prev
	pointer on the first view when adding the second view, fixes
	crash when closing gtk-demo text test with active selection

	* gtk/gtktextbuffer.c
	(gtk_text_buffer_remove_selection_clipboard): don't leave dead
	clipboards in the list of clipboards - probably fixes #59836
This commit is contained in:
Havoc Pennington 2001-09-07 22:32:02 +00:00 committed by Havoc Pennington
parent 1bbf2ac7ee
commit e8648181ed
10 changed files with 104 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
ChangeLog
View File

@ -1,3 +1,16 @@
2001-09-07 Havoc Pennington <hp@redhat.com>
* gtk/gtktextlayout.c (gtk_text_layout_get_lines): remove some
debug code that seems to have caused a breakpoint in valid cases
* gtk/gtktextbtree.c (_gtk_text_btree_add_view): set the prev
pointer on the first view when adding the second view, fixes
crash when closing gtk-demo text test with active selection
* gtk/gtktextbuffer.c
(gtk_text_buffer_remove_selection_clipboard): don't leave dead
clipboards in the list of clipboards - probably fixes #59836
Fri Sep 7 11:51:44 2001 Owen Taylor <otaylor@redhat.com> Fri Sep 7 11:51:44 2001 Owen Taylor <otaylor@redhat.com>
Make gdkx.h the only installed header from gdk/x11. Make gdkx.h the only installed header from gdk/x11.

13
ChangeLog.pre-2-0
View File

@ -1,3 +1,16 @@
2001-09-07 Havoc Pennington <hp@redhat.com>
* gtk/gtktextlayout.c (gtk_text_layout_get_lines): remove some
debug code that seems to have caused a breakpoint in valid cases
* gtk/gtktextbtree.c (_gtk_text_btree_add_view): set the prev
pointer on the first view when adding the second view, fixes
crash when closing gtk-demo text test with active selection
* gtk/gtktextbuffer.c
(gtk_text_buffer_remove_selection_clipboard): don't leave dead
clipboards in the list of clipboards - probably fixes #59836
Fri Sep 7 11:51:44 2001 Owen Taylor <otaylor@redhat.com> Fri Sep 7 11:51:44 2001 Owen Taylor <otaylor@redhat.com>
Make gdkx.h the only installed header from gdk/x11. Make gdkx.h the only installed header from gdk/x11.

13
ChangeLog.pre-2-10
View File

@ -1,3 +1,16 @@
2001-09-07 Havoc Pennington <hp@redhat.com>
* gtk/gtktextlayout.c (gtk_text_layout_get_lines): remove some
debug code that seems to have caused a breakpoint in valid cases
* gtk/gtktextbtree.c (_gtk_text_btree_add_view): set the prev
pointer on the first view when adding the second view, fixes
crash when closing gtk-demo text test with active selection
* gtk/gtktextbuffer.c
(gtk_text_buffer_remove_selection_clipboard): don't leave dead
clipboards in the list of clipboards - probably fixes #59836
Fri Sep 7 11:51:44 2001 Owen Taylor <otaylor@redhat.com> Fri Sep 7 11:51:44 2001 Owen Taylor <otaylor@redhat.com>
Make gdkx.h the only installed header from gdk/x11. Make gdkx.h the only installed header from gdk/x11.

13
ChangeLog.pre-2-2
View File

@ -1,3 +1,16 @@
2001-09-07 Havoc Pennington <hp@redhat.com>
* gtk/gtktextlayout.c (gtk_text_layout_get_lines): remove some
debug code that seems to have caused a breakpoint in valid cases
* gtk/gtktextbtree.c (_gtk_text_btree_add_view): set the prev
pointer on the first view when adding the second view, fixes
crash when closing gtk-demo text test with active selection
* gtk/gtktextbuffer.c
(gtk_text_buffer_remove_selection_clipboard): don't leave dead
clipboards in the list of clipboards - probably fixes #59836
Fri Sep 7 11:51:44 2001 Owen Taylor <otaylor@redhat.com> Fri Sep 7 11:51:44 2001 Owen Taylor <otaylor@redhat.com>
Make gdkx.h the only installed header from gdk/x11. Make gdkx.h the only installed header from gdk/x11.

13
ChangeLog.pre-2-4
View File

@ -1,3 +1,16 @@
2001-09-07 Havoc Pennington <hp@redhat.com>
* gtk/gtktextlayout.c (gtk_text_layout_get_lines): remove some
debug code that seems to have caused a breakpoint in valid cases
* gtk/gtktextbtree.c (_gtk_text_btree_add_view): set the prev
pointer on the first view when adding the second view, fixes
crash when closing gtk-demo text test with active selection
* gtk/gtktextbuffer.c
(gtk_text_buffer_remove_selection_clipboard): don't leave dead
clipboards in the list of clipboards - probably fixes #59836
Fri Sep 7 11:51:44 2001 Owen Taylor <otaylor@redhat.com> Fri Sep 7 11:51:44 2001 Owen Taylor <otaylor@redhat.com>
Make gdkx.h the only installed header from gdk/x11. Make gdkx.h the only installed header from gdk/x11.

13
ChangeLog.pre-2-6
View File

@ -1,3 +1,16 @@
2001-09-07 Havoc Pennington <hp@redhat.com>
* gtk/gtktextlayout.c (gtk_text_layout_get_lines): remove some
debug code that seems to have caused a breakpoint in valid cases
* gtk/gtktextbtree.c (_gtk_text_btree_add_view): set the prev
pointer on the first view when adding the second view, fixes
crash when closing gtk-demo text test with active selection
* gtk/gtktextbuffer.c
(gtk_text_buffer_remove_selection_clipboard): don't leave dead
clipboards in the list of clipboards - probably fixes #59836
Fri Sep 7 11:51:44 2001 Owen Taylor <otaylor@redhat.com> Fri Sep 7 11:51:44 2001 Owen Taylor <otaylor@redhat.com>
Make gdkx.h the only installed header from gdk/x11. Make gdkx.h the only installed header from gdk/x11.

13
ChangeLog.pre-2-8
View File

@ -1,3 +1,16 @@
2001-09-07 Havoc Pennington <hp@redhat.com>
* gtk/gtktextlayout.c (gtk_text_layout_get_lines): remove some
debug code that seems to have caused a breakpoint in valid cases
* gtk/gtktextbtree.c (_gtk_text_btree_add_view): set the prev
pointer on the first view when adding the second view, fixes
crash when closing gtk-demo text test with active selection
* gtk/gtktextbuffer.c
(gtk_text_buffer_remove_selection_clipboard): don't leave dead
clipboards in the list of clipboards - probably fixes #59836
Fri Sep 7 11:51:44 2001 Owen Taylor <otaylor@redhat.com> Fri Sep 7 11:51:44 2001 Owen Taylor <otaylor@redhat.com>
Make gdkx.h the only installed header from gdk/x11. Make gdkx.h the only installed header from gdk/x11.

9
gtk/gtktextbtree.c
View File

@ -1395,6 +1395,12 @@ _gtk_text_btree_add_view (GtkTextBTree *tree,
view->next = tree->views; view->next = tree->views;
view->prev = NULL; view->prev = NULL;
if (tree->views)
{
g_assert (tree->views->prev == NULL);
tree->views->prev = view;
}
tree->views = view; tree->views = view;
/* The last line in the buffer has identity values for the per-view /* The last line in the buffer has identity values for the per-view
@ -1453,6 +1459,9 @@ _gtk_text_btree_remove_view (GtkTextBTree *tree,
gtk_text_btree_node_remove_view (view, tree->root_node, view_id); gtk_text_btree_node_remove_view (view, tree->root_node, view_id);
view->layout = (gpointer) 0xdeadbeef;
view->view_id = (gpointer) 0xdeadbeef;
g_free (view); g_free (view);
} }

3
gtk/gtktextbuffer.c
View File

@ -3070,6 +3070,9 @@ gtk_text_buffer_remove_selection_clipboard (GtkTextBuffer *buffer,
if (gtk_clipboard_get_owner (selection_clipboard->clipboard) == G_OBJECT (buffer)) if (gtk_clipboard_get_owner (selection_clipboard->clipboard) == G_OBJECT (buffer))
gtk_clipboard_clear (selection_clipboard->clipboard); gtk_clipboard_clear (selection_clipboard->clipboard);
buffer->selection_clipboards = g_slist_remove (buffer->selection_clipboards,
selection_clipboard);
g_free (selection_clipboard); g_free (selection_clipboard);
} }
} }

6
gtk/gtktextlayout.c
View File

@ -586,12 +586,6 @@ gtk_text_layout_get_lines (GtkTextLayout *layout,
_gtk_text_btree_line_count (_gtk_text_buffer_get_btree (layout->buffer)) - 1, _gtk_text_btree_line_count (_gtk_text_buffer_get_btree (layout->buffer)) - 1,
NULL); NULL);
{
GtkTextLineData *ld = _gtk_text_line_get_data (last_btree_line, layout);
if (ld->height == 0)
G_BREAKPOINT ();
}
g_assert (last_btree_line != NULL); g_assert (last_btree_line != NULL);
line = first_btree_line; line = first_btree_line;