AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity

filechooserwidget: Avoid an uninitialised value

Browse Source 
For NULL filters, we were never calling g_list_store_find, so leaving
filter_index undefined.
This commit is contained in:
Timm Bäder 2020-06-05 06:26:56 +02:00
parent 8bee3e2fe0
commit ea1cc4b991
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
gtk/gtkfilechooserwidget.c
View File

@ -6900,8 +6900,15 @@ set_current_filter (GtkFileChooserWidget *impl,
guint filter_index;
/* NULL filters are allowed to reset to non-filtered status */
if (filter && !g_list_store_find (impl->filters, filter, &filter_index))
if (filter)
{
if (!g_list_store_find (impl->filters, filter, &filter_index))
return;
}
else
{
filter_index = -1;
}
if (impl->current_filter)
g_object_unref (impl->current_filter);
@ -6911,7 +6918,6 @@ set_current_filter (GtkFileChooserWidget *impl,
gtk_drop_down_set_selected (GTK_DROP_DOWN (impl->filter_combo), filter_index);
g_print ("set current filter %u\n", filter_index);
clear_model_cache (impl, MODEL_COL_IS_SENSITIVE);
set_model_filter (impl, impl->current_filter);
g_object_notify (G_OBJECT (impl), "filter");