AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity

file chooser: Fix Ctrl-L

Browse Source 
We were forwarding key events to the search entry
and unconditionally considered search started
afterwards. That is not correct, since things
like a Ctrl key press should not trigger search.
Fix this by only switching to search mode when
the event was actually consumed.

Closes: https://gitlab.gnome.org/GNOME/gtk/issues/1829
This commit is contained in:
Matthias Clasen 2019-04-27 17:43:59 +00:00
parent cc4b3798e5
commit eea1388cf4
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
gtk/gtkfilechooserwidget.c
View File

@ -1411,12 +1411,13 @@ widget_key_press_cb (GtkEventControllerKey *controller,
}
else
{
gtk_event_controller_key_forward (controller, priv->search_entry);
if (gtk_event_controller_key_forward (controller, priv->search_entry))
{
if (priv->operation_mode != OPERATION_MODE_SEARCH)
operation_mode_set (impl, OPERATION_MODE_SEARCH);
if (priv->operation_mode != OPERATION_MODE_SEARCH)
operation_mode_set (impl, OPERATION_MODE_SEARCH);
handled = TRUE;
handled = TRUE;
}
}
g_object_unref (event);