Improve the efficiency here by prepending on the list and reverting it

Thu Feb 19 00:45:02 2004  Matthias Clasen  <maclas@gmx.de>

	* gtk/gtktreeselection.c (gtk_tree_selection_get_selected_rows):
	Improve the efficiency here by prepending on the list and reverting
	it after the loop.  (#133435, Christian Biere)
This commit is contained in:
Matthias Clasen 2004-02-18 23:42:46 +00:00 committed by Matthias Clasen
parent 1971cb4938
commit eeccdcb829
6 changed files with 35 additions and 3 deletions

View File

@ -1,3 +1,9 @@
Thu Feb 19 00:45:02 2004 Matthias Clasen <maclas@gmx.de>
* gtk/gtktreeselection.c (gtk_tree_selection_get_selected_rows):
Improve the efficiency here by prepending on the list and reverting
it after the loop. (#133435, Christian Biere)
Thu Feb 19 00:32:21 2004 Matthias Clasen <maclas@gmx.de> Thu Feb 19 00:32:21 2004 Matthias Clasen <maclas@gmx.de>
* gtk/gtkplug.c (_gtk_plug_remove_from_socket): Avoid errors when * gtk/gtkplug.c (_gtk_plug_remove_from_socket): Avoid errors when

View File

@ -1,3 +1,9 @@
Thu Feb 19 00:45:02 2004 Matthias Clasen <maclas@gmx.de>
* gtk/gtktreeselection.c (gtk_tree_selection_get_selected_rows):
Improve the efficiency here by prepending on the list and reverting
it after the loop. (#133435, Christian Biere)
Thu Feb 19 00:32:21 2004 Matthias Clasen <maclas@gmx.de> Thu Feb 19 00:32:21 2004 Matthias Clasen <maclas@gmx.de>
* gtk/gtkplug.c (_gtk_plug_remove_from_socket): Avoid errors when * gtk/gtkplug.c (_gtk_plug_remove_from_socket): Avoid errors when

View File

@ -1,3 +1,9 @@
Thu Feb 19 00:45:02 2004 Matthias Clasen <maclas@gmx.de>
* gtk/gtktreeselection.c (gtk_tree_selection_get_selected_rows):
Improve the efficiency here by prepending on the list and reverting
it after the loop. (#133435, Christian Biere)
Thu Feb 19 00:32:21 2004 Matthias Clasen <maclas@gmx.de> Thu Feb 19 00:32:21 2004 Matthias Clasen <maclas@gmx.de>
* gtk/gtkplug.c (_gtk_plug_remove_from_socket): Avoid errors when * gtk/gtkplug.c (_gtk_plug_remove_from_socket): Avoid errors when

View File

@ -1,3 +1,9 @@
Thu Feb 19 00:45:02 2004 Matthias Clasen <maclas@gmx.de>
* gtk/gtktreeselection.c (gtk_tree_selection_get_selected_rows):
Improve the efficiency here by prepending on the list and reverting
it after the loop. (#133435, Christian Biere)
Thu Feb 19 00:32:21 2004 Matthias Clasen <maclas@gmx.de> Thu Feb 19 00:32:21 2004 Matthias Clasen <maclas@gmx.de>
* gtk/gtkplug.c (_gtk_plug_remove_from_socket): Avoid errors when * gtk/gtkplug.c (_gtk_plug_remove_from_socket): Avoid errors when

View File

@ -1,3 +1,9 @@
Thu Feb 19 00:45:02 2004 Matthias Clasen <maclas@gmx.de>
* gtk/gtktreeselection.c (gtk_tree_selection_get_selected_rows):
Improve the efficiency here by prepending on the list and reverting
it after the loop. (#133435, Christian Biere)
Thu Feb 19 00:32:21 2004 Matthias Clasen <maclas@gmx.de> Thu Feb 19 00:32:21 2004 Matthias Clasen <maclas@gmx.de>
* gtk/gtkplug.c (_gtk_plug_remove_from_socket): Avoid errors when * gtk/gtkplug.c (_gtk_plug_remove_from_socket): Avoid errors when

View File

@ -474,7 +474,7 @@ gtk_tree_selection_get_selected_rows (GtkTreeSelection *selection,
do do
{ {
if (GTK_RBNODE_FLAG_SET (node, GTK_RBNODE_IS_SELECTED)) if (GTK_RBNODE_FLAG_SET (node, GTK_RBNODE_IS_SELECTED))
list = g_list_append (list, gtk_tree_path_copy (path)); list = g_list_prepend (list, gtk_tree_path_copy (path));
if (node->children) if (node->children)
{ {
@ -506,7 +506,8 @@ gtk_tree_selection_get_selected_rows (GtkTreeSelection *selection,
if (!tree) if (!tree)
{ {
gtk_tree_path_free (path); gtk_tree_path_free (path);
return list;
goto done;
} }
gtk_tree_path_up (path); gtk_tree_path_up (path);
@ -519,7 +520,8 @@ gtk_tree_selection_get_selected_rows (GtkTreeSelection *selection,
gtk_tree_path_free (path); gtk_tree_path_free (path);
return list; done:
return g_list_reverse (list);
} }
static void static void