AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity

filechooser: Fix memory leaks

Browse Source 
The returned strings from `file_chooser_get_location()` were never freed.
This commit is contained in:
Barnabás Pőcze 2023-03-08 00:28:25 +01:00
parent 30586d75ac
commit f0e4293b83
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
gtk/gtkfilechooserwidget.c
View File

@ -6989,15 +6989,20 @@ location_sort_func (gconstpointer a,
gpointer user_data)
{
GtkFileChooserWidget *impl = user_data;
char *location_a, *location_b;
char *key_a, *key_b;
GtkOrdering result;
/* FIXME: use sortkeys for these */
key_a = g_utf8_collate_key_for_filename (file_chooser_get_location (impl, (GFileInfo *)a), -1);
key_b = g_utf8_collate_key_for_filename (file_chooser_get_location (impl, (GFileInfo *)b), -1);
location_a = file_chooser_get_location (impl, (GFileInfo *)a);
location_b = file_chooser_get_location (impl, (GFileInfo *)b);
key_a = g_utf8_collate_key_for_filename (location_a, -1);
key_b = g_utf8_collate_key_for_filename (location_b, -1);
result = g_strcmp0 (key_a, key_b);
g_free (location_a);
g_free (location_b);
g_free (key_a);
g_free (key_b);