printbackendlpr: Static analysis fixes

This commit is contained in:
Matthias Clasen 2021-05-03 07:35:57 -04:00
parent a49ff5a1c4
commit f472cb53ae

View File

@ -336,18 +336,13 @@ gtk_print_backend_lpr_print_stream (GtkPrintBackend *print_backend,
NULL, NULL,
NULL, NULL,
&print_error)) &print_error))
goto out; goto out;
ps->in = g_io_channel_unix_new (in_fd); ps->in = g_io_channel_unix_new (in_fd);
g_io_channel_set_encoding (ps->in, NULL, &print_error); g_io_channel_set_encoding (ps->in, NULL, &print_error);
if (print_error != NULL) if (print_error != NULL)
{ goto out;
if (ps->in != NULL)
g_io_channel_unref (ps->in);
goto out;
}
g_io_channel_set_close_on_unref (ps->in, TRUE); g_io_channel_set_close_on_unref (ps->in, TRUE);
@ -362,9 +357,14 @@ gtk_print_backend_lpr_print_stream (GtkPrintBackend *print_backend,
if (print_error != NULL) if (print_error != NULL)
{ {
lpr_print_cb (GTK_PRINT_BACKEND_LPR (print_backend), lpr_print_cb (GTK_PRINT_BACKEND_LPR (print_backend), print_error, ps);
print_error, ps);
g_error_free (print_error); g_error_free (print_error);
if (ps->in != NULL)
g_io_channel_unref (ps->in);
if (ps->job)
g_object_unref (ps->job);
g_free (ps);
} }
} }