Bilal Elmoussaoui
0919320086
g-i: Add missing since annotations
2022-11-28 07:54:48 +00:00
Matthias Clasen
90c986e493
Merge branch 'wip/corey/spi-logging' into 'main'
...
atspicontext: Log failure to connect to a11y
See merge request GNOME/gtk!5270
2022-11-28 01:29:10 +00:00
Corey Berla
16fd72e606
atspicontext: Log failure to connect to a11y
...
GTK depends on the a11y infrastructure to be in place unless GTK_A11Y is
set to none. It appears that despite that, users attempt to
get around the a11y requirement without setting GTK_A11Y.
This can cause, amongst other issues, performance problems
with gtk applications. Log failure to connect to the a11y
bus.
2022-11-27 14:13:13 -08:00
Bilal Elmoussaoui
5ede8dd1eb
g-i: Add missing since annotation
2022-11-25 10:16:37 +00:00
Matthias Clasen
e73f0f6974
file dialog: Handle Escape better
...
Closing the dialog by hitting Escape should
have the same effect as clicking the cancel
button. Make it so.
2022-11-24 10:29:43 -05:00
Matthias Clasen
ff14c51950
color dialog: Handle Escape better
...
Closing the dialog by hitting Escape should
have the same effect as clicking the cancel
button. Make it so.
2022-11-24 10:29:03 -05:00
Matthias Clasen
942f8d4b4b
Deprecate GtkInfoBar
...
This widget has a dialog-like API, which is something
we want to get rid of in GTK 5, and libadwaita has
a replacement with AdwBanner incoming.
2022-11-23 13:00:09 -05:00
Matthias Clasen
d34ac99916
filefilter: Add properties for the criteria
...
Add construct-only properties for patterns,
suffixes and mime-types. This provides an
alternative way to specify these in ui files.
Related: #5350
2022-11-21 22:44:03 -05:00
Matthias Clasen
205b718fe5
colorpicker: Always try the portal first
...
It does not hurt., and going forward, we want to
prefer portals.
2022-11-21 14:26:29 -05:00
Matthias Clasen
01ae136a4c
Merge branch 'bilelmoussaoui/g-i' into 'main'
...
g-i: add missing array annotation to AlertDialog.set_buttons
See merge request GNOME/gtk!5234
2022-11-21 10:49:05 +00:00
Matthias Clasen
83839cb219
Merge branch 'drop-buildable-get-id' into 'main'
...
builder: Stop using GtkBuildable.get_id
See merge request GNOME/gtk!5239
2022-11-21 10:35:16 +00:00
Matthias Clasen
e357ff6055
Drop gtk_widget_buildable_parser_finished
...
No need to have this no-op implementation.
This was the only implementation of this vfunc
in GTK.
2022-11-20 14:36:35 -05:00
Matthias Clasen
92edd4c476
builder: Stop using GtkBuildable.get_id
...
Drop the only implementation of this vfunc,
and stop using it. It isn't needed, and the
only implementation did the same thing GtkBuilder
does anyway.
2022-11-20 14:35:36 -05:00
Matthias Clasen
f0aefe2f7f
stringlist: Add a construct-only strings property
...
This enables creating string lists in ui files
without using custom markup.
Related: #5350
2022-11-20 14:07:45 -05:00
Matthias Clasen
8dc89ba3d8
centerbox: Add properties for child widgets
...
This provides and alternative to add children
in ui files.
Related: #5350
2022-11-20 12:54:31 -05:00
Bilal Elmoussaoui
97d76417fa
g-i: add missing array annotation to AlertDialog.(s|g)et_buttons
2022-11-19 14:33:19 +01:00
Matthias Clasen
ab530b9e5a
Merge branch 'builder-parse-attributes' into 'main'
...
builder: Parse PangoAttrList values
See merge request GNOME/gtk!5228
2022-11-19 02:49:23 +00:00
Matthias Clasen
21a69e7107
Merge branch 'wip/carlosg/osk-activation' into 'main'
...
gtktext: Claim gesture more selectively
Closes #5351
See merge request GNOME/gtk!5230
2022-11-18 19:33:55 +00:00
Matthias Clasen
d45155364e
Merge branch 'kjellahl/menubar' into 'main'
...
gtk_popover_menu_bar_set_menu_model(): Accept model == NULL
See merge request GNOME/gtk!5232
2022-11-18 19:33:37 +00:00
Kjell Ahlstedt
8911015549
gtkpopovermenubar: Make model nullable
...
The description of gtk_popover_menu_bar_new_from_model() and
gtk_popover_menu_bar_set_menu_model() says that model is nullable.
Make it so.
2022-11-18 18:09:42 +01:00
Carlos Garnacho
ae54374a51
gtktext: Claim gesture more selectively
...
Even though button 1 (or touch down) presses do most often have
an effect in one way or another (starting drag, moving focus,
starting selection, ...), there is one situation that they do
immediately nothing: When clicking on the entry does not move
the text caret around. Dragging might start a selection, but
the entry did not do anything just yet, and an immediate
button/touch release should remain at "did nothing".
And that is precisely the hint that the Wayland IM context's click
gesture takes, clicks that do not scroll nor move the caret around,
having the GtkText not claim the gesture in that situation makes
the IM gesture able to do its thing without in-fighting.
This is typically not a problem when the GtkText is embedded in
another GtkEditable implementation (e.g. GtkEntry), since the
IM gesture is inactive and capturing from the parent widget, so
gets a pass that it otherwise doesn't get when both gestures are
in the same widget. This makes it work regardless of GtkText not
being a child of a composite widget, like NautilusQueryEditor
and AdwRowEntry.
Closes: https://gitlab.gnome.org/GNOME/gtk/-/issues/5351
2022-11-18 17:56:14 +01:00
Matthias Clasen
1f97714293
immodule: Accept 'simple' and 'none'
...
Everybody (including myself) gets this wrong,
so accept 'simple' and 'none' as shorthands
for the official IDs 'gtk-im-context-simple'
and 'gtk-im-context-none'.
2022-11-18 11:18:48 -05:00
Matthias Clasen
9af8c6fb25
immmodule: Warn if GTK_IM_MODULE is bad
...
If we don't find an immodule matching the
ids in the GTK_IM_MODULE envvar, print a
warning.
2022-11-18 11:18:48 -05:00
Matthias Clasen
9682085e09
builder: Parse PangoAttrList values
...
Allow specifying PangoAttrList properties in the
serialized format supported by pango_attr_list_to_string().
Test included.
2022-11-18 10:42:50 -05:00
Matthias Clasen
9cbfbbdf39
stringsorter: Fix one case of collation handling
...
When not ignoring case, and not collating, we were
returning sort keys that were already freed. Oops.
Pointed out by clang.
2022-11-18 00:04:23 -05:00
Matthias Clasen
95fc5109bb
composetable: Fix a memory leak
...
Pointed out by clang.
2022-11-18 00:04:23 -05:00
Matthias Clasen
60aaf38f39
gdk: Clean up gdkprivate.h
...
Move apis to more specific headers.
2022-11-17 22:49:56 -05:00
Matthias Clasen
b12d31d189
Fix spelling errors
...
These were pointed out by codespell.
2022-11-17 22:49:45 -05:00
Matthias Clasen
0d2161ee40
Merge branch 'file-dialog-portals' into 'main'
...
file dialog: Use portals
See merge request GNOME/gtk!5221
2022-11-18 03:49:30 +00:00
Matthias Clasen
b0148972fd
filedialog: Use portals
...
We want this new API to be portal-first.
Make it so.
2022-11-17 15:52:53 -05:00
Cam Cook
2a14753739
Merge branch 'main' into ccook/doc-spelling-fixes
2022-11-16 23:23:42 -05:00
Cam Cook
4ccc3b53eb
doc/spelling changes: gtkselectionmodel.c, 'call this when the* selection changes'
2022-11-16 23:20:50 -05:00
Matthias Clasen
793954055e
Merge branch 'radioactiveman-main-patch-52462' into 'main'
...
label: Fix markup doc example
See merge request GNOME/gtk!5201
2022-11-17 03:46:43 +00:00
Thomas Lange
7adf720f08
label: Fix markup doc example
2022-11-17 03:46:01 +00:00
Matthias Clasen
501577196a
Merge branch 'matthiasc/for-main' into 'main'
...
Inspector: Add a missing event type
See merge request GNOME/gtk!5218
2022-11-16 19:24:54 +00:00
robxnano
adc0264dac
filechooser: Fix gtk_file_chooser_set_choice again
...
If the choice was in the form of a GtkDropDown, the code failed to
find the widget and so the choice never got set. Fixes #5346 .
2022-11-16 18:07:20 +00:00
Matthias Clasen
4eb017904b
Alertdialog: Cosmetics
2022-11-15 10:36:32 +00:00
Matthias Clasen
c9df9978d2
Inspector: Add a missing event type
...
We did not have a name for the new touchpad hold
events.
To prevent this from happening again in the future,
add a static assertion.
2022-11-15 07:18:41 +01:00
Cam Cook
d1bb927286
Documentation fix: Various spelling mistakes (and one use of the wrong verb) across a few domains that show up in documentation.
...
| domain | current | suggestion |
|--------|---------|------------|
| [GtkButton](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtkbutton.c#L691 ) | "Buttons can has a flat appearance" | "Buttons can have a flat appearance" |
| [GtkCenterBox](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtkcenterbox.c#L275 ) | "pas %NULL" | "pass %NULL" |
| [GtkEditable](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtkeditable.c#L466 ) | "the text to append" | "the text to insert" |
| [GtkFlowbox](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtkflowbox.c#L4921 ) | "the are equal" | "they are equal" |
| [GtkSelectionModel](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtkselectionmodel.c#L550 ) | "Call this when a the selection changes" | "Call this when a selection changes" |
| [GtkWIndow](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtkwindow.c#L5321 ) | "(e.g. the user or the window manager" | "(e.g. the user or the window manager)" |
2022-11-13 11:55:05 -05:00
Matthias Clasen
2daea9e459
Merge branch 'focus-no-parent' into 'main'
...
focus: fall back to old behaviour if we didn't focus anything
See merge request GNOME/gtk!5189
2022-11-11 10:29:00 +00:00
Matthias Clasen
d1bdc36331
window: fixups
2022-11-09 16:28:30 +01:00
Matthias Clasen
f9982a61e6
window: Use gdk_toplevel_export_handle
2022-11-09 16:28:29 +01:00
Matthias Clasen
9e28a407df
Merge branch 'ebassi/since-for-main' into 'main'
...
docs: Add deprecation notices for properties
See merge request GNOME/gtk!5204
2022-11-08 16:01:11 +00:00
Matthias Clasen
a5780beba7
Merge branch 'ccook/gtk_aspect_frame_doc_fix' into 'main'
...
doc/comment fix: @self misspelled as self@
See merge request GNOME/gtk!5200
2022-11-08 15:28:08 +00:00
Emmanuele Bassi
5a51cbe673
docs: Add deprecation notices for properties
2022-11-08 10:45:09 +00:00
Matthias Clasen
e00b96053b
colordialogbutton: Actually accept NULL
...
As pointed out in #5321 , my previous fix was not
good enough.
Fixes : #5321
2022-11-07 15:24:13 +01:00
Cam Cook
ed16946685
doc/comment fix: the ref to @self was misspelled as self@ for gtkaspectframe.h/gtk_aspect_frame_get_child
...
Noticed this while reviewing the gi-docgen docs for GtkAspectFrame while developing some java bindings.
It's my understanding that @self was intended; as it would cause gi-docgen to interpret it as a reference to
the the GtkAspectFrame pointer named 'self'.
2022-11-06 17:59:23 -05:00
Matthias Clasen
466db31aac
color/fontdialogbutton: Fix constructors
...
The arguments were meant to be nullable.
Make it so!
Fixes : #5321
2022-11-06 14:12:02 +01:00
Adam Williamson
e07f8ef506
focus: fall back to old behaviour if we didn't focus anything
...
8455b9ac74
seems to have introduced a problem where we can wind
up focusing no widget at all if the `while (parent)` loop doesn't
find a widget it can successfully move the focus to. This 'fixes'
that by falling back to doing the previous thing if we make it
all the way through that loop without moving the focus. Thanks to
@coreyberla for a hint to improve the implementation.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-11-02 09:32:32 -07:00
Matthias Clasen
030e8c0bf9
Be consistent in preconditions for async API
...
Do the same checks in all our finish functions.
2022-10-31 16:40:54 -04:00