Emmanuele Bassi
1f132607f7
gtk: Use appropriate constness for variables
2016-10-17 11:44:11 +01:00
Benjamin Otte
1518fe0a8f
API: stylecontext: Remove state argument from getters
...
The argument must always be the current state.
2016-10-16 18:18:58 +02:00
Timm Bäder
3b336dda73
dialog: Remove alternative button order API
2016-10-16 18:17:21 +02:00
Timm Bäder
f45dadadd0
box: Remove 'padding' child property
2016-10-16 18:17:21 +02:00
Matthias Clasen
a43fce058c
print dialog: Apply initial capabilities
...
I was struggling to understand why calling
gtk_print_unix_dialog_set_manual_capabilities (...,0)
was not having the expected effect of hiding the preview
button. The initial capabilities were not applied at all.
2016-07-02 18:08:38 -04:00
Matthias Clasen
52e0ab53dc
print dialog: More baseline alignment
...
Some places were missing the right valign setting to make
baselines line up properly.
2016-02-21 00:09:32 -05:00
Matthias Clasen
0bcd8603eb
print dialog: Fix layout preview drawing
...
Use the CSS name paper for this as well, and make sure Adwaita
sets a color that makes the text visible in the dark theme as well.
2016-02-03 16:07:51 +01:00
Matthias Clasen
9657ec9331
print dialog: Set a CSS name
...
The CSS name for GtkPrintUnixDialog is printdialog.
2016-01-13 23:41:38 -05:00
Emmanuele Bassi
0d4a010cbb
Remove an unused variable declaration
...
And the compiler warning that comes with it.
2015-11-10 13:42:02 +00:00
Matthias Clasen
c2d0aa7851
print dialog: Avoid gtk_style_context_save
...
There was one more call to gtk_style_context_save here that I
overlooked. We can get rid of it by just setting the element name
on the drawing area.
2015-11-10 07:54:59 -05:00
Matthias Clasen
59c1547a48
print dialog: Use an element name for rendering the paper
...
Use a transient node with name paper instead of a random
collection of style classes for rendering the papers.
2015-11-07 00:57:03 -05:00
Matthias Clasen
5c2759af3c
Use standard cursor names
...
This changes GTK+ to use gdk_cursor_new_from_name() with the
'standard' css names, instead of GdkCursorType.
https://bugzilla.gnome.org/show_bug.cgi?id=652085
2015-07-26 01:45:06 -04:00
Matthias Clasen
99935b14c6
GtkPrintUnixDialog: Use a better busy cursor
2015-05-07 22:24:19 -04:00
Matthias Clasen
f00f2fdf0d
Remove a redundant const
...
const gchar const is still just const gchar, unless there's
indirections in between.
2015-03-22 15:18:35 -04:00
Philip Withnall
ac4da770e1
gtkprintunixdialog: Fix a potential g_object_unref(NULL) call
...
The code above checks whether (printer == NULL), so we’d better do so
here as well.
Found by scan-build.
https://bugzilla.gnome.org/show_bug.cgi?id=712760
2015-03-10 07:32:19 +00:00
Philip Withnall
af36220bca
gtkprintcontext: Fix several potential g_object_[un]ref(NULL) calls
...
The page_setup of a GtkPrintContext or GtkPrintUnixDialog is nullable,
so all reference count changes to it have to be guarded against NULL
values.
Found by scan-build.
https://bugzilla.gnome.org/show_bug.cgi?id=712760
2015-03-09 13:41:37 +00:00
Matthias Clasen
768e6a4579
Ensure print-related types are registered
...
These types are not covered by g_test_register_all_types,
and having the types registered when a print dialog is used
helps in cases where GTK+ is dlopened.
https://bugzilla.gnome.org/show_bug.cgi?id=745065
2015-03-04 20:37:01 -05:00
Matthias Clasen
a03583d14f
printing: Avoid missing icons
...
I've noticed a missing image show up in my print dialog, where
the printer reported "printer-paused" as icon. Rearrange things
so we always fall back to "printer" for printer icons.
2014-10-04 12:20:23 -04:00
Matthias Clasen
f634684eeb
printing: Another tweak to sheet drawing
...
After consultation, revisit the vertical centering to center
the first 'stack', and put the second one behind it.
2014-10-04 11:56:44 -04:00
Benjamin Otte
82b7d21f6e
print: Add a .paper style class
...
... and use it in the print preview.
2014-10-04 17:18:50 +02:00
Matthias Clasen
4bc09a6a17
printing: Simplify sheet drawing
...
We don't need the scaling support anymore - icon sizes are
no longer settable.
2014-10-04 11:00:10 -04:00
Matthias Clasen
10d0dad2cf
print: Center sheet drawing horizontally
...
Center the page ordering indicator horizontally, relative to the
spinbutton above it.
2014-10-04 10:55:13 -04:00
Matthias Clasen
99c65b1587
print: Center sheet drawing vertically
...
Center the page ordering indicator vertically, relative to the
checkboxes next to it.
2014-10-04 10:55:06 -04:00
Benjamin Otte
39453478ab
print: Improve sheet drawing a bit
...
This is only one step in the right direction. Long term this code should
probably be replaced by real widgets.
2014-10-03 06:18:06 +02:00
Jasper St. Pierre
9c37b3de74
gtk: Don't use GObjectClass.constructor
...
Use the newer constructed instead, which has a fast path in GObject.
2014-06-26 19:06:43 -04:00
Matthias Clasen
eec1bc7ed1
GtkPrintUnixDialog: Remove some dead code
...
Automatic template children get cleaned up and NULLed out in destroy,
the g_clear_pointer() calls in finalize never do anything.
2014-05-30 19:33:11 -04:00
Bastien Nocera
f71f7215ab
all: Name more idles and timeouts
...
Following up from 438cd857c4
,
name more timeouts and idles.
The original grep was missing checking for gdk_threads_add_*()
functions (at least for some of the files).
https://bugzilla.gnome.org/show_bug.cgi?id=726870
2014-03-26 20:09:30 -04:00
Marek Kasik
b95ce71b89
printing: Fail nicely when /tmp is not writable
...
Don't crash when /tmp is not writable when printing to file.
Show that getting of printer details failed for CUPS printers.
https://bugzilla.gnome.org/show_bug.cgi?id=693200
2014-03-17 14:37:34 -04:00
Marek Kasik
31748fa5c0
printing: Fix sensitivity of the Print button
...
Don't make Print button sensitive until a printer is selected.
https://bugzilla.gnome.org/show_bug.cgi?id=724895
2014-02-21 16:04:49 +01:00
William Jon McCann
469d333aa2
docs: use Returns: consistently
...
Instead of Return value:
2014-02-19 18:56:05 -05:00
Matthias Clasen
7fbf6a67a2
Fix a small memory leak
...
GtkPrintUnixDialog was leaking a GFile.
Spotted by Christian Persch in
https://bugzilla.gnome.org/show_bug.cgi?id=724631
2014-02-19 00:31:40 -05:00
Matthias Clasen
2392b1e534
Make print dialog destruction work
...
This was also causing the templates test to fail.
2014-02-17 21:40:36 -05:00
William Jon McCann
e34bd4137d
docs: use apostrophes in *n't
2014-02-07 13:32:47 -05:00
William Jon McCann
0ce016650b
docs: Use markup for links
2014-02-07 09:42:12 -05:00
William Jon McCann
2a45418b67
docs: use proper quotes
2014-02-05 15:08:42 -05:00
William Jon McCann
3b3d8ca456
docs: Use "#" for refsect2 instead of ##
2014-02-04 21:00:58 -05:00
Matthias Clasen
09d1b28249
docs: Convert to markdown
...
Specifically, switch to using markdown syntax for sections.
2014-02-02 00:30:27 -05:00
William Jon McCann
768bc44081
docs: use |[ ]| instead of <programlisting></programlisting>
...
https://bugzilla.gnome.org/show_bug.cgi?id=723119
2014-01-29 12:45:49 -05:00
William Jon McCann
2d003553e8
docs: don't use <emphasis>
...
It is a little heavy handed. The text can speak for itself.
2014-01-28 02:02:05 -05:00
William Jon McCann
22586ea7c2
docs: use #*-struct instead of <structname>
2014-01-27 19:59:55 -05:00
Marek Kasik
8418e6422f
printing: Enable search through locations in printers list
...
Add printer_compare() function for comparing printers according
to their names and locations. It is possible to search by multiple
keys separated by space or tabulator using logical conjunction.
Based on patch by William Hua.
https://bugzilla.gnome.org/show_bug.cgi?id=692931
2014-01-27 16:40:43 +01:00
Marek Kasik
f17b36dc02
printing: Show "Replace" button when printing to existing file
...
Use gtk_dialog_add_button() which adds the button to
the message dialog correctly and uses gtk_widget_show() on it.
2014-01-27 11:12:48 +01:00
William Jon McCann
4a11acdc8c
resources: move resources into a subdirectory
2014-01-23 21:04:59 -05:00
William Jon McCann
0a16518bcf
docs: fix links to print api
2014-01-21 18:57:38 -05:00
William Jon McCann
bb951fe783
print dialog: Use headerbar
...
Make the print dialog use a headerbar when desired.
https://bugzilla.gnome.org/show_bug.cgi?id=720059
2014-01-17 17:52:08 -05:00
Matthias Clasen
25e6ba48e7
Update all internal users of alternative button order
...
We'll keep this code around for now to not regress
on Windows, but avoid deprecation warnings.
2014-01-17 17:52:07 -05:00
Philip Withnall
b37f8b80b4
gtkprintunixdialog: Remove a redundant (GFile != NULL) check
...
g_file_new_for_uri() is guaranteed to return a non-NULL value, so this
check was redundant, and was confusing the static analyser into
returning a false positive, where it thought the file could be NULL.
https://bugzilla.gnome.org/show_bug.cgi?id=712760
2013-12-02 10:36:26 +00:00
Matthias Clasen
56719c6363
Don't use depeprecated api
...
GtkPrintUnixDialog and testtitlebar were still using
gtk_widget_set_margin_left/right. Switch them over to
gtk_widget_set_margin_start/end.
2013-12-01 16:55:57 -05:00
Chenthill Palanisamy
1fd74de214
Do not reset the waiting_for_printer on status change
...
* gtk/gtkprintunixdialog.c (printer_status_cb): Do not reset the
waiting_for_printer on status change as the default printer might
get added later.
https://bugzilla.gnome.org/show_bug.cgi?id=577642
2013-11-05 13:33:40 +01:00
Matthias Clasen
66445fec1d
Fix dark theme issues in the print dialog
...
The dimensions in the n-up illustration were not using the
color of the style for drawing.
https://bugzilla.gnome.org/show_bug.cgi?id=709420
2013-10-05 23:02:54 -04:00