Commit Graph

8020 Commits

Author SHA1 Message Date
Federico Mena Quintero
74f3d16c26 Remove debug printfs
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19855
2008-03-13 00:47:05 +00:00
Federico Mena Quintero
bb4c73e81b Add some FIXMEs
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19854
2008-03-13 00:46:48 +00:00
Federico Mena Quintero
b0e2c417cb On error when loading a folder, use the raw error message instead of commenting it up
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19853
2008-03-13 00:46:31 +00:00
Federico Mena Quintero
c406ebcc44 Clear the current_folder_path if loading yields an error
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19852
2008-03-13 00:46:14 +00:00
Federico Mena Quintero
7efced5687 Present an error if we can't load the folder during explicit completion
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19851
2008-03-13 00:45:58 +00:00
Federico Mena Quintero
d5df63cc1c Detect when Tab would generate no new completions
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19850
2008-03-13 00:45:41 +00:00
Federico Mena Quintero
801553bee6 Debug printfs for deleting/inserting the completion
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19849
2008-03-13 00:45:23 +00:00
Federico Mena Quintero
857c561ffe If explicitly completing and we have a completion, just unselect it
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19848
2008-03-13 00:45:05 +00:00
Federico Mena Quintero
bcb36780ed Another FIXME
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19847
2008-03-13 00:44:48 +00:00
Federico Mena Quintero
e33260acf3 Add completion feedback in other places
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19846
2008-03-13 00:44:30 +00:00
Federico Mena Quintero
932e20e9df Find the cursor position from GtkEntry for the completion feedback
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19845
2008-03-13 00:44:12 +00:00
Federico Mena Quintero
197ab5dee8 Use a timer for the completion feedback window
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19844
2008-03-13 00:43:54 +00:00
Federico Mena Quintero
2465beb901 Destroy the completion feedback window
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19843
2008-03-13 00:43:36 +00:00
Federico Mena Quintero
53b09108df Use an alignment for the label like in GtkTooltip
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19842
2008-03-13 00:43:18 +00:00
Federico Mena Quintero
547069a38e Show the label as well as the feedback window
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19841
2008-03-13 00:42:58 +00:00
Federico Mena Quintero
b17ffff0ff Debug printfs for the completion feedback position
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19840
2008-03-13 00:42:38 +00:00
Federico Mena Quintero
3b5ddd8b55 Create a tooltip-like window to present completion feedback
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19839
2008-03-13 00:42:19 +00:00
Federico Mena Quintero
f47227adde Beep if there are no matches for explicit completion
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19838
2008-03-13 00:41:58 +00:00
Federico Mena Quintero
a83799a32a Scan the completion store again to look for complete-but-not-unique matches
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19837
2008-03-13 00:41:38 +00:00
Federico Mena Quintero
e5f8a4693e Stubs for all cases of completion feedback
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19836
2008-03-13 00:41:17 +00:00
Federico Mena Quintero
806cca3c9c Update comments on explicit completion
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19835
2008-03-13 00:40:57 +00:00
Federico Mena Quintero
47ddc0c86f Stubs to give feedback when doing explicit completion
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19834
2008-03-13 00:40:37 +00:00
Federico Mena Quintero
1510b02c75 Refresh the file part when it gets requested and when activating the entry
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19833
2008-03-13 00:40:16 +00:00
Federico Mena Quintero
8482f9a7de Clear the completion flags before appending the common prefix
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19832
2008-03-13 00:39:56 +00:00
Federico Mena Quintero
6a06c6daee Add FIXMEs for beeping later
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19831
2008-03-13 00:39:35 +00:00
Federico Mena Quintero
d2293cc4f8 Factor out some code
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19830
2008-03-13 00:39:15 +00:00
Federico Mena Quintero
989637296b Implement the basic code path for explicit completion
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19829
2008-03-13 00:38:53 +00:00
Federico Mena Quintero
11a9457ee1 Clear pending completions thoroughly
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19828
2008-03-13 00:38:31 +00:00
Federico Mena Quintero
e7009432b2 Remove debug printfs from populate_completion_store()
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19827
2008-03-13 00:38:11 +00:00
Federico Mena Quintero
a531c03baf Debug printfs for finishing the folder load
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19826
2008-03-13 00:37:50 +00:00
Federico Mena Quintero
deec573420 More debug printfs for populating the completion store
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19825
2008-03-13 00:37:27 +00:00
Federico Mena Quintero
b2fe9f70d3 Debug printfs for populating the completion store
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19824
2008-03-13 00:37:05 +00:00
Federico Mena Quintero
baeaea3ca8 Turn on in_change while changing the filename in the entry
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19823
2008-03-13 00:36:42 +00:00
Federico Mena Quintero
b25ec8e40e Update some FIXMEs
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19822
2008-03-13 00:36:18 +00:00
Federico Mena Quintero
a6bdc59213 When finding the common prefix, assert that we have the correct folder loaded
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19821
2008-03-13 00:35:54 +00:00
Federico Mena Quintero
073093bde0 Discard the completion store when we change the folder
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19820
2008-03-13 00:35:31 +00:00
Federico Mena Quintero
f5343b9037 Add some more FIXMEs
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19819
2008-03-13 00:35:08 +00:00
Federico Mena Quintero
bdebb1c7fb Remove obsolete comments
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19818
2008-03-13 00:34:44 +00:00
Federico Mena Quintero
69f62828f4 Cancel all forms of completion at the appropriate times, not just in ::changed
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19817
2008-03-13 00:34:21 +00:00
Federico Mena Quintero
9c9b5e6034 Put some more FIXMEs
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19816
2008-03-13 00:33:55 +00:00
Federico Mena Quintero
f96770eb2f Re-create the completion store right before populating it
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19815
2008-03-13 00:33:31 +00:00
Federico Mena Quintero
af7a4e2ecf Populate the completion store when the folder is done loading
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19814
2008-03-13 00:32:58 +00:00
Federico Mena Quintero
756497d142 Remove files_added handler
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19813
2008-03-13 00:32:32 +00:00
Federico Mena Quintero
d254972b7a Remove files_deleted handler
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19812
2008-03-13 00:32:05 +00:00
Federico Mena Quintero
340e9ac350 Handle the folder being completely loaded
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19811
2008-03-13 00:31:38 +00:00
Federico Mena Quintero
f1101e1169 Debug printfs for finding the common prefix
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19810
2008-03-13 00:31:13 +00:00
Federico Mena Quintero
4158110fe8 Debug printfs for the common prefix
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19809
2008-03-13 00:30:47 +00:00
Federico Mena Quintero
f027017d8b Autocomplete by inserting/selecting the common prefix
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19808
2008-03-13 00:30:20 +00:00
Federico Mena Quintero
e7afb62172 Debugging printfs
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19807
2008-03-13 00:29:55 +00:00
Federico Mena Quintero
25b98dca7b Start autocompletion in an idle so GtkEntry updates its cursor position
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19806
2008-03-13 00:29:30 +00:00
Federico Mena Quintero
5f32bf06e0 Rework the way autocompletion is initiated
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19805
2008-03-13 00:29:04 +00:00
Federico Mena Quintero
d64fa89eec For autocompletion, consider only the text up to the cursor
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19804
2008-03-13 00:28:38 +00:00
Federico Mena Quintero
1394858329 Don't overwrite the suffix after the cursor when inserting the completion
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19803
2008-03-13 00:28:12 +00:00
Federico Mena Quintero
bbb847aef7 Skip the cursor past the autocompleted part when requesting explicit completion
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19802
2008-03-13 00:27:46 +00:00
Federico Mena Quintero
45c87ed009 Move the cursor to the end only if we highlight the completed match
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19801
2008-03-13 00:27:16 +00:00
Federico Mena Quintero
46d0480711 Complete even if not at the end of the text
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19800
2008-03-13 00:26:49 +00:00
Federico Mena Quintero
833e32fa08 Only auto-insert the prefix if we are at the end of the text
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19799
2008-03-13 00:26:20 +00:00
Federico Mena Quintero
795727aad4 Find the common prefix based on the cursor position
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19798
2008-03-13 00:25:50 +00:00
Tor Lillqvist
4217ebbf78 Remove one extraneous space.
svn path=/trunk/; revision=19793
2008-03-12 19:41:30 +00:00
Tor Lillqvist
0cc4738b0c Bug 510000 - GtkStatusIcon doesn't reshow after explorer.exe crash
2008-03-12  Tor Lillqvist  <tml@novell.com>

	Bug 510000 - GtkStatusIcon doesn't reshow after explorer.exe crash

	* gtk/gtkstatusicon.c [Win32]: Keep a list of status icons. Check
	for the TaskbarCreated message in the window procedure for the
	dummy "tray observer" window we create. When we get a
	TaskbarCreated message, iterate over the status icons and re-add
	them to the task bar, and update them by calling
	gtk_status_icon_update_image().

	Move some ifdefs around to avoid unused functions.


svn path=/trunk/; revision=19792
2008-03-12 19:34:38 +00:00
Matthias Clasen
b7aeafa395 Add an overwrite confirmation dialog for print-to-file. (#474302, Marek
2008-03-12  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkprintunixdialog.c: Add an overwrite confirmation
        dialog for print-to-file.  (#474302, Marek Kašík)



svn path=/trunk/; revision=19787
2008-03-12 18:02:29 +00:00
Matthias Clasen
d0d95f8bc9 Don't leak paper_size here. (#488820, Morten Welinder)
2008-03-12  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkpagesetup.c (gtk_page_setup_copy): Don't leak
        paper_size here.  (#488820, Morten Welinder)


svn path=/trunk/; revision=19781
2008-03-12 16:37:51 +00:00
Tor Lillqvist
c8b617382d Bug 469868 - Filenames with colon ":" are not saved correctly
2008-03-11  Tor Lillqvist  <tml@novell.com>

	Bug 469868 - Filenames with colon ":" are not saved correctly

	* gtk/gtkfilechooserentry.c (insert_text_callback)
	(delete_text_callback) [Win32]: New functions to make sure that
	colons used otherwise than as a separator after a drive letter, or
	characters that are always illegal in file names, are rejected on
	input. This means that the GTK+ file chooser can't be used to
	input full names of alternate data streams, but oh well. There are
	still more checks that could be done on the file names, see the
	bug report. But this will do for now.
	(_gtk_file_chooser_entry_init) [Win32]: Connect above functions.


svn path=/trunk/; revision=19753
2008-03-11 18:43:49 +00:00
Michael Natterer
e8c3fbf4d8 removed linux-fb backend files.
2008-03-11  Michael Natterer  <mitch@imendio.com>

	* gdk/linux-fb/*: removed linux-fb backend files.

	* acconfig.h
	* config.h.win32.in
	* docs/README.linux-fb
	* gtk/Makefile.am: remove remaining traces of linux-fb.

	* gtk/gtkwindow-decorate.c: same here. There is some code that
	calls into linux-fb to set window move/resize callbacks. I put it
	in #if 0 as a reminder because we did use decorated windows with
	the DirectFB backend and it did work, so I don't really know why
	this code is needed or how it could work with DirectFB back then.
	The file does actually compile now if DECORATE_WINDOWS is defined,
	but I didn't test with DirectFB to check if it does anything.


svn path=/trunk/; revision=19749
2008-03-11 17:14:00 +00:00
Alberto Ruiz
1e1f49e09a Take thickness into account in the size allocation of the child widgets in
2008-03-11  Alberto Ruiz  <aruiz@gnome.org>

	* gtk/gtkcombobox.c (gtk_combo_box_size_allocate):
	Take thickness into account in the size allocation of the child widgets in
	list mode.
	Fixes #521442


svn path=/trunk/; revision=19747
2008-03-11 13:46:37 +00:00
Tor Lillqvist
26c98dfaca Remove from SVN, finally.
2008-03-10  Tor Lillqvist  <tml@novell.com>

	* gtk/gtktrayicon-win32.c: Remove from SVN, finally.


svn path=/trunk/; revision=19744
2008-03-10 18:35:29 +00:00
Johan Dahlin
27472fe72b Revert #508760
svn path=/trunk/; revision=19740
2008-03-09 22:56:29 +00:00
Johan Dahlin
424cc287f1 - Treat enums like enums and not values - Avoid invalid free, in case of
2008-03-07  Johan Dahlin  <johan@gnome.org>

    * gtk/gtkbuilder.c:
    * gtk/gtkbuilderparser.c:
    * gtk/gtkbuilderprivate.h:
    * gtk/gtkiconfactory.c:
    * tests/buildertest.c:
    - Treat enums like enums and not values
    - Avoid invalid free, in case of more than two sources
    - Add better error messages
    - Add much improved tests
    (#520979, Christian Persch)


svn path=/trunk/; revision=19732
2008-03-07 20:03:35 +00:00
Carlos Garnacho
f55db27521 Fix build.
2008-03-07  Carlos Garnacho  <carlos@imendio.com>

        * gtk/gtkiconfactory.c (gtk_icon_factory_buildable_custom_tag_end):
        Fix build.

svn path=/trunk/; revision=19731
2008-03-07 11:13:47 +00:00
Federico Mena Quintero
384dbd3c88 bgo505857 - GtkFileChooserDialog ensures its default response
Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19727
2008-03-07 03:53:58 +00:00
Johan Dahlin
61be2a7127 Implement GtkBuildable on GtkIconFactory, to make it possible to register
2008-03-06  Johan Dahlin  <jdahlin@async.com.br>

    * docs/reference/gtk/tmpl/gtkiconfactory.sgml:
    * gtk/gtkbuilder.c:
    * gtk/gtkbuilderprivate.h:
    * gtk/gtkiconfactory.c:
    * tests/buildertest.c:
    Implement GtkBuildable on GtkIconFactory, to make
    it possible to register custom stock icons.
    Fixes #517066


svn path=/trunk/; revision=19726
2008-03-07 00:08:16 +00:00
Johan Dahlin
6f9bcaa8b7 Make gtk-doc happy:
2008-03-06  Johan Dahlin  <johan@gnome.org>

    Make gtk-doc happy:
    
    * gtk/gtkstyle.c: npoints->n_points.
    * gtk/gtktestutils.h: widget->spinner
    * gtk/gtktestutils.c: argc->argcp, argv->argvp


svn path=/trunk/; revision=19725
2008-03-06 23:21:26 +00:00
William Rikard Lachance
b68d7cc100 Oops, forgot to make the raw "%H:%M" string localizable (as it should be).
svn path=/trunk/; revision=19724
2008-03-06 19:57:55 +00:00
William Rikard Lachance
69cef720a4 Don't print "Today at" in front of the time for today's date. It's
redudant. (see bug #410517).

svn path=/trunk/; revision=19723
2008-03-06 19:43:22 +00:00
Xan Lopez
6dc678ede3 fix typo in documentation.
2008-03-06  Xan Lopez  <xan@gnome.org>

	* gtk/gtkfixed.c: fix typo in documentation.

svn path=/trunk/; revision=19722
2008-03-06 19:14:17 +00:00
Johan Dahlin
b381678a92 Move GtkTranslateFunc to gtktypeutils.h so we can completely deprecate
2008-03-06  Johan Dahlin  <jdahlin@async.com.br>

    * gtk/gtkitemfactory.h:
    * gtk/gtktypeutils.h:
    Move GtkTranslateFunc to gtktypeutils.h so we can completely
    deprecate gtkitemfactory.h. 

    * gtk/gtkactiongroup.h:
    * gtk/gtkstock.h:
    Do not include gtkitemfactory.h directly, instead include gtktypeutils.h

    * README.in: 
    Add a note describing this slight incompatible change


svn path=/trunk/; revision=19721
2008-03-06 14:04:30 +00:00
Johan Dahlin
b4fbde69b4 Avoid double-deprecation.
2008-03-06  Johan Dahlin  <johan@gnome.org>

    * gtk/gtkpreview.h: Avoid double-deprecation.


svn path=/trunk/; revision=19720
2008-03-06 13:43:26 +00:00
Michael Natterer
95c236f027 gtk/gtk.h move the remaining deprecated widgets to the separate sections
2008-03-06  Michael Natterer  <mitch@imendio.com>

	* gtk/gtk.h
	* gtk/Makefile.am: move the remaining deprecated widgets to the
	separate sections and replaced spaces by tabs in Makefile.am


svn path=/trunk/; revision=19719
2008-03-06 10:51:16 +00:00
Johan Dahlin
22900f7853 Separate broken and deprecated sources and headers into different sections
2008-03-05  Johan Dahlin  <johan@gnome.org>

    * gtk/gtk.h: 
    * gtk/Makefile.am:
    Separate broken and deprecated sources and headers into different sections


svn path=/trunk/; revision=19714
2008-03-05 15:36:41 +00:00
Kristian Rietveld
4e6561b2b2 short-circuit in case an empty root level would be build (and thus
2008-03-05  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtktreemodelfilter.c (gtk_tree_model_filter_row_inserted):
	short-circuit in case an empty root level would be build (and thus
	directly destroyed) if no virtual root has been set.


svn path=/trunk/; revision=19712
2008-03-05 10:36:35 +00:00
Michael Natterer
fee3aa919d gtk/gtkcellview.c gtk/gtkcolorbutton.c gtk/gtkentrycompletion.c
2008-03-04  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkcellview.c
	* gtk/gtkcolorbutton.c
	* gtk/gtkentrycompletion.c
	* gtk/gtkfontbutton.c
	* gtk/gtkiconview.c
	* gtk/gtkobject.c
	* gtk/gtkpaned.c
	* gtk/gtkpreview.c: don't include "gtksignal.h".

	* gtk/gtkfilefilter.c
	* gtk/gtkrecentchoosermenu.c
	* gtk/gtkrecentfilter.c
	* gtk/gtktext.c: don't include "gtkobject.h".


svn path=/trunk/; revision=19708
2008-03-04 12:49:40 +00:00
Simos Xenitellis
11abc0d691 Fix #321896 - Synch gtkimcontextsimple.c with Xorg
svn path=/trunk/; revision=19706
2008-03-04 11:21:48 +00:00
Carlos Garnacho
761749c26b bgo417389 - Scrollwheel for GtkPathBar
2008-03-03  Carlos Garnacho  <carlos@imendio.com>

	Fix http://bugzilla.gnome.org/show_bug.cgi?id=417389 - Make the
	scrollwheel work in GtkPathBar.

	* gtk/gtkpathbar.h (struct _GtkPathBar): New field event_window.

	* gtk/gtkpathbar.c (gtk_path_bar_realize): New function.  Create
	an input-only window, event_window, which we'll use to capture
	scroll events.
	(gtk_path_bar_map): Show the event_window under the rest of the
	windows, so it will be a catch-all for unhandled events.

Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19699
2008-03-03 21:15:21 +00:00
Sven Neumann
845a4632d9 fixed a typo in the documentation of the GtkFileChooserButtons::file-set
2008-03-03  Sven Neumann  <sven@gimp.org>

	* gtk/gtkfilechooserbutton.c (G_DEFINE_TYPE_WITH_CODE): fixed a
	typo in the documentation of the GtkFileChooserButtons::file-set
	signal (see bug #353196).

svn path=/trunk/; revision=19696
2008-03-03 12:35:43 +00:00
Johan Dahlin
b7e1d653dc Use void instead of empty arguments. (#508760, Philip Van Hoof)
2008-03-02  Johan Dahlin  <johan@gnome.org>

    * gtk/gtkitemfactory.h: Use void instead of empty arguments.
    (#508760, Philip Van Hoof)


svn path=/trunk/; revision=19694
2008-03-03 01:22:54 +00:00
Johan Dahlin
90cba8ffdb Remove left-over focus_pad variable. (#490892, Claudio Saavedra)
2008-03-02  Johan Dahlin  <johan@gnome.org>

    * gtk/gtkiconview.c (gtk_icon_view_paint_item): 
    Remove left-over focus_pad variable.
    (#490892, Claudio Saavedra)


svn path=/trunk/; revision=19693
2008-03-03 01:13:07 +00:00
Johan Dahlin
e2534d54e1 Add translatable/context and comment attributes on <col> tags under a
2008-02-29  Johan Dahlin  <johan@gnome.org>

	* demos/gtk-demo/demo.ui:
	* gtk/gtkbuilderparser.c:
	* gtk/gtkbuilderprivate.h:
	* gtk/gtkliststore.c:
	* tests/buildertest.c:
	Add translatable/context and comment attributes on
	<col> tags under a GtkListStore. Refactor parts of the
	translation api and make it available inside gtk+ itself.
	Update tests and example.
	Fixes a part of #518642


svn path=/trunk/; revision=19685
2008-03-02 01:14:48 +00:00
Johan Dahlin
bee4a9fcc3 Add missing g_return_val_if_fail checks for public API.
2008-02-29  Johan Dahlin  <johan@gnome.org>

	* gtk/gtkbuilder.c:
	Add missing g_return_val_if_fail checks for public API.


svn path=/trunk/; revision=19684
2008-03-01 16:47:34 +00:00
Johan Dahlin
a57b66aac2 Do not use g_error for a few more errors, instead set the GError sent in
2008-02-29  Johan Dahlin  <johan@gnome.org>

	* gtk/gtkbuilder.c:
	* gtk/gtkbuilderparser.c:
	* gtk/gtkbuilderprivate.h:
	Do not use g_error for a few more errors, instead set
	the GError sent in through add_from_file/add_from_string.
	* tests/buildertest.c:
	Add a couple of new parsing tests.
	(#519199, Pavel Syomin)


svn path=/trunk/; revision=19681
2008-03-01 13:49:06 +00:00
Federico Mena Quintero
9b440c1656 When refreshing an existing unix folder, turn off its is_finished_loading state
2008-02-29  Federico Mena Quintero  <federico@novell.com>

	* gtk/gtkfilesystemunix.c (gtk_file_system_unix_get_folder): When
	refreshing an existing folder (i.e. when we are about to reload
	its file list), turn off the folder's is_finished_loading flag.
	Otherwise callers which do ::is_finished_loading() followed by
	::list_children() will get nothing.

Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19677
2008-03-01 02:32:09 +00:00
Matthias Clasen
bf13970ddb Remove trailing comma from enum to make the compiler happy. (#517295,
2008-02-28  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkcalendar.h: Remove trailing comma from enum to
        make the compiler happy.  (#517295, Sylvain Pasche)



svn path=/trunk/; revision=19671
2008-02-28 05:41:56 +00:00
Michael Natterer
45debfb0ef gtk/gtkmenushell.c gtk/gtktable.c gtk/gtktext.c gtk/gtktipsquery.c
2008-02-27  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkmenushell.c
	* gtk/gtktable.c
	* gtk/gtktext.c
	* gtk/gtktipsquery.c
	* gtk/gtktoolbar.c
	* gtk/gtktreeitem.c
	* gtk/gtktreeview.c
	* gtk/gtkviewport.c
	* gtk/gtkwin32embedwidget.c: remove g_return_if_fail() from
	private functions and virtual function implementations.


svn path=/trunk/; revision=19668
2008-02-27 11:30:10 +00:00
Sven Neumann
1d7a62a2cd when building the Quartz backend, use a native Mac OS X application for
2008-02-27  Sven Neumann  <sven@gimp.org>

	* gtk/Makefile.am (GTK_PRINT_PREVIEW_COMMAND): when building the
	Quartz backend, use a native Mac OS X application for the print
	preview (bug #518624).

svn path=/trunk/; revision=19663
2008-02-27 09:58:49 +00:00
Michael Natterer
2b66e18dab don't g_free() the members of info->tag_stack since they are a) gobjects
2008-02-26  Michael Natterer  <mitch@imendio.com>

	* gtk/gtktextbufferserialize.c (parse_info_free): don't g_free()
	the members of info->tag_stack since they are a) gobjects and b)
	not even owned by us, ugh... Fixes crash when deserializing fails.


svn path=/trunk/; revision=19657
2008-02-26 14:20:08 +00:00
Matthias Clasen
36c4dff3da And don't use beagle_query_add_hit_type
svn path=/trunk/; revision=19649
2008-02-25 15:59:28 +00:00
Matthias Clasen
9f19c492a6 Look for libbeagle.so.1
svn path=/trunk/; revision=19646
2008-02-25 13:43:37 +00:00
Matthias Clasen
7dbb99c297 2.13.0
svn path=/trunk/; revision=19628
2008-02-21 18:03:04 +00:00
Tor Lillqvist
f07ad74afc Small further change to make it more robust.
svn path=/trunk/; revision=19626
2008-02-21 16:23:01 +00:00
Tor Lillqvist
7a9bbf551f Must pass the format string to strftime in the C library's locale's
2008-02-21  Tor Lillqvist  <tml@novell.com>

	* gtk/gtkfilechooserdefault.c (list_mtime_data_func) [Win32]: Must
	pass the format string to strftime in the C library's locale's
	charset, not the system's. Correspondingly, the return value from
	strftime() is in the C library's locale's charset. (#509885)


svn path=/trunk/; revision=19625
2008-02-21 12:47:45 +00:00
Marc-Andre Lureau
e4fe214f39 fix missing call to g_type_class_unref in case of error. (#517563)
2008-02-20  Marc-Andre Lureau  <marcandre.lureau@gmail.com>

        * gtk/gtkbuilder.c (_gtk_builder_enum_from_string): fix missing
        call to g_type_class_unref in case of error. (#517563)

svn path=/trunk/; revision=19619
2008-02-20 18:32:43 +00:00
Sven Neumann
16530f7908 gtk/Makefile.am (STOCK_ICONS) gtk/stock-icons/16/gtk-page-setup.png added
2008-02-18  Sven Neumann  <sven@gimp.org>

	* gtk/Makefile.am (STOCK_ICONS)
	* gtk/stock-icons/16/gtk-page-setup.png
	* gtk/stock-icons/24/gtk-page-setup.png: added page-setup icons
	taken from GNOME icon theme.

	* gtk/gtkstock.[ch]: added GTK_STOCK_PAGE_SETUP. Closes bug #514410.

svn path=/trunk/; revision=19614
2008-02-18 15:01:04 +00:00
Johan Dahlin
1cf6a85aab When converting a stock item based on the label, remove the label
2008-02-17  Johan Dahlin  <johan@gnome.org>

    * gtk/gtk-builder-convert (GtkBuilderConverter._add_action_from_menuitem): 
    When converting a stock item based on the label, remove the label property.
    (bug #515824, Yuri Pimenov)


svn path=/trunk/; revision=19607
2008-02-17 22:28:55 +00:00
Matthias Clasen
311cdbb346 Show the URI in a tooltip. (#505480, Teppo Turtiainen)
2008-02-16  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtklinkbutton.c: Show the URI in a tooltip.  (#505480,
        Teppo Turtiainen)


svn path=/trunk/; revision=19596
2008-02-16 05:28:22 +00:00
Matthias Clasen
3456639c39 Prevent a crash with hidden, reorderable tabs. (#513230, Mike Massonnet,
2008-02-15  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtknotebook.c (gtk_notebook_stop_reorder): Prevent
        a crash with hidden, reorderable tabs.  (#513230,
        Mike Massonnet, patch by Carlos Garnacho)


svn path=/trunk/; revision=19593
2008-02-16 04:09:15 +00:00
Matthias Clasen
34418c4e8e Warn on duplicate action group names. (#501746, Christian Persch)
2008-02-15  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkuimanager.c (gtk_ui_manager_insert_action_group):
        Warn on duplicate action group names.  (#501746, Christian
        Persch)



svn path=/trunk/; revision=19592
2008-02-16 03:43:38 +00:00
Matthias Clasen
ca36ffc2af Fix builddir!=srcdir builds. (#516254, Yevgen Muntyan)
2008-02-15  Matthias Clasen  <mclasen@redhat.com>

        * gtk/Makefile.am:
        * modules/other/gail/tests/Makefile.am:
        * modules/other/gail/libgail-util/Makefile.am:
        * modules/other/gail/Makefile.am: Fix builddir!=srcdir
        builds.  (#516254,  Yevgen Muntyan)



svn path=/trunk/; revision=19591
2008-02-16 02:39:20 +00:00
Matthias Clasen
13277493eb Use gtk_drag_*_add_{text,uri}_targets instead of hardcoded target tables.
2008-02-15  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkentry.c:
        * gtk/gtkfilesel.c:
        * gtk/gtklabel.c:
        * gtk/gtkpathbar.c: Use gtk_drag_*_add_{text,uri}_targets
        instead of hardcoded target tables.  (#516092, Christian Persch)



svn path=/trunk/; revision=19590
2008-02-16 02:31:33 +00:00
Matthias Clasen
3b3122ee06 Don't add the same target atom twice. (#516087, Christian Persch)
2008-02-15  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkselection.c (gtk_target_list_add_text_targets): Don't
        add the same target atom twice.  (#516087, Christian Persch)

svn path=/trunk/; revision=19589
2008-02-16 01:37:47 +00:00
Matthias Clasen
45e33fe9c2 Go back to 2.13.0 as version for now, as there was no consensus to do the
2008-02-15  Matthias Clasen  <mclasen@redhat.com>

        * configure.in: Go back to 2.13.0 as version for now,
        as there was no consensus to do the jump.

        * many other places: Update Since: tags.



svn path=/trunk/; revision=19586
2008-02-15 23:42:42 +00:00
Matthias Clasen
a6ccc040a2 Add gtk_tool_shell_get_type
2008-02-15  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtk.symbols: Add gtk_tool_shell_get_type

        * gtk/gtktestutils.c: Don't generate unnecessary PLT entries

svn path=/trunk/; revision=19585
2008-02-15 23:13:30 +00:00
Tor Lillqvist
4c731485a6 Don't leak Registry key handles. (#516578)
2008-02-15  Tor Lillqvist  <tml@novell.com>

	* gtk/gtkfilesystemwin32.c (get_viewable_logical_drives): Don't
	leak Registry key handles. (#516578)


svn path=/trunk/; revision=19572
2008-02-15 00:26:40 +00:00
Johan Dahlin
ddf4a07053 gdk/gdktestutils.h Remove ; trailing G_BEGIN/END_DECLS
2008-02-14  Johan Dahlin  <johan@gnome.org>

    * gdk/gdktestutils.h
    * gtk/gtktestutils.h: Remove ; trailing G_BEGIN/END_DECLS


svn path=/trunk/; revision=19564
2008-02-14 15:48:35 +00:00
Christian Persch
6b8de6a7a0 Typo fix
svn path=/trunk/; revision=19562
2008-02-13 19:24:10 +00:00
Richard Hult
fce8ef214e Remove unused variables. (gtk_clipboard_set_contents),
2008-02-13  Richard Hult  <richard@imendio.com>

	* gtk/gtkclipboard-quartz.c: (gtk_clipboard_wait_for_contents):
	Remove unused variables.
	(gtk_clipboard_set_contents),
	(gtk_clipboard_get_owner), (clipboard_unset),
	(gtk_clipboard_request_targets): Notify the previous clipboard
	owner when the owner changes. Fixes bug #493406.

svn path=/trunk/; revision=19560
2008-02-13 15:36:18 +00:00
Kristian Rietveld
ddf4aa8b3e only queue a redraw if the rubber banding has actually been active.
2008-02-13  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtktreeview.c (gtk_tree_view_stop_rubber_band): only
	queue a redraw if the rubber banding has actually been active.


svn path=/trunk/; revision=19556
2008-02-13 11:53:35 +00:00
Matthias Clasen
9d6954734d Fix some i18n errors. Pointed out by Behdad Esfahbod.
2008-02-12  Matthias Clasen  <mclasne@redhat.com>

        * gtk/gtkpapersize.c:
        * gtk/gtkprintoperation.c:
        * gtk/gtkvolumebutton.c:
        * gtk/gtkbulderparser.c: Fix some i18n errors. Pointed
        out by Behdad Esfahbod.



svn path=/trunk/; revision=19547
2008-02-12 22:43:35 +00:00
Federico Mena Quintero
1cda35d32c Fix 419737 - don't focus the file list when activating a shortcut in the file chooser
2008-02-12  Federico Mena Quintero  <federico@novell.com>

	Merged from gtk-2-12:

	Don't focus the file list when shortcuts get activated.  This
	removes a lot of ambiguity in when the file selection should
	change, and makes the overall code flow simpler.

	This fixes http://bugzilla.gnome.org/show_bug.cgi?id=419737 -
	file/save dialog clears the filename entry when changing
	directories.

	Also fixes http://bugzilla.gnome.org/show_bug.cgi?id=499940 -
	focus should not go to the file list when a shortcut is activated.

	* gtk/gtkfilechooserdefault.c
	(shortcuts_activate_volume_mount_cb): Don't focus the file list
	(shortcuts_activate_get_info_cb): Likewise.

	* gtk/gtkfilechooserdefault.c (switch_to_shortcut): Don't focus
	the file list (this was the last place where we would focus the
	file list explicitly).  If you are in the location entry, for
	example, you don't want Alt-Home to take you to the file list; you
	just want the current folder to change.  Thanks to Olle Bergkvist
	<olle.bergkvist@yahoo.se> for pointing this out in
	http://bugzilla.gnome.org/show_bug.cgi?id=419737#c51.
	(focus_browse_tree_view_if_possible): Removed.

Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=19543
2008-02-12 19:32:17 +00:00
Matthias Clasen
4118dd893f Skip exensions when selecting filenames in the save-as dialog. (#362516,
2008-02-12  Matthias Clasen  <mclasen@redhat.com>

        Skip exensions when selecting filenames in the save-as dialog.
        (#362516, Carlos Garnacho)

        * gtk/gtkfilechooserentry.h:
        * gtk/gtkfilechooserentry.c (_gtk_file_chooser_entry_select_filename):
        New function to skip the extension part when selecting a filename.
        (_gtk_file_chooser_entry_set_base_folder): Use it here.

        * gtk/gtkfilechooserdefault.c (gtk_file_chooser_entry_grab_focus):
        ...and here.


svn path=/trunk/; revision=19540
2008-02-12 17:34:43 +00:00
Matthias Clasen
0c2788943f Fix state change reporting for accessibility. (#499835, Rich Burridge,
2008-02-12  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkiconview.c: Fix state change reporting for
        accessibility.  (#499835, Rich Burridge, patch by LiYan Zhang)


svn path=/trunk/; revision=19538
2008-02-12 16:43:04 +00:00
Emmanuele Bassi
ede4f39e38 Set the default value of the :show-not-found property to TRUE, as every
2008-02-12  Emmanuele Bassi  <ebassi@gnome.org>

	* gtk/gtkrecentchooser.c:
	(gtk_recent_chooser_class_init): Set the default value of the
	:show-not-found property to TRUE, as every implementation sets
	it to TRUE already.

	* gtk/gtkrecentchooserdefault.c:
	(_gtk_recent_chooser_default_init): Sync show_tips to the
	default value of the :show-tips property.

svn path=/trunk/; revision=19535
2008-02-12 16:38:00 +00:00
Matthias Clasen
945db7f6a6 Use GSlice for GtkSelectionData. (#515060, Christian Persch)
2008-02-12  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkclipboard-quartz.c:
        * gtkquartz.c:
        * gtkselection.c: Use GSlice for GtkSelectionData.  (#515060,
        Christian Persch)


svn path=/trunk/; revision=19533
2008-02-12 16:10:39 +00:00
Kristian Rietveld
49f20887af guard against people deleting the row in question in the selection-changed
2008-02-12  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtktreeview.c (gtk_tree_view_real_select_cursor_row),
	(gtk_tree_view_real_toggle_cursor_row): guard against people
	deleting the row in question in the selection-changed callback.
	(#514621, Andreas Koehler).


svn path=/trunk/; revision=19530
2008-02-12 15:58:25 +00:00
Matthias Clasen
0509519d35 Unify the handling of various "Enter" keysyms all over the place.
2008-02-12  Matthias Clasen  <mclasen@redhat.com>

        * gtk/*.c: Unify the handling of various "Enter" keysyms
        all over the place.  (#515047, Christian Persch)



svn path=/trunk/; revision=19528
2008-02-12 15:51:09 +00:00
Matthias Clasen
f51751d2d8 Use g_value_set_static_string() where appropriate. (#515042, Christian
2008-02-12  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkfilesystemmodel.c:
        * gtk/gtkprinter.c:
        * gtk/gtkwidget.c: Use g_value_set_static_string() where
        appropriate.  (#515042, Christian Persch)


svn path=/trunk/; revision=19527
2008-02-12 15:41:30 +00:00
Matthias Clasen
6a80b177a0 Use gtk_selection_data_set_uris() instead of doing it by hand. (#514890,
2008-02-12  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkfilechooserdefault.c (recent_model_sort_drag_data_get):
        (recent_model_sort_drag_data_get):
        (search_model_sort_drag_data_get):
        * gtk/gtkfilesystemmodel.c (drag_source_drag_data_get):
        * gtk/gtkpathbar.c (button_drag_data_get_cb):
        Use gtk_selection_data_set_uris() instead of doing it
        by hand.  (#514890, Christian Persch)


svn path=/trunk/; revision=19524
2008-02-12 15:07:38 +00:00
Michael Natterer
697a50929e #include "gtkmain.h" for gtk_get_current_event_time().
2008-02-12  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkstatusicon.c: #include "gtkmain.h" for
	gtk_get_current_event_time().


svn path=/trunk/; revision=19522
2008-02-12 10:26:42 +00:00
Michael Natterer
c3c1fb9822 simply use gtk_window_get_key_hash() to get the hash instead of manually
2008-02-12  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkwindow.c (gtk_window_activate_key): simply use
	gtk_window_get_key_hash() to get the hash instead of manually
	fiddling with quarks and gtk_window_keys_changed(). Also add
	g_return_if_fail() to this public function.


svn path=/trunk/; revision=19521
2008-02-12 10:02:46 +00:00
Matthias Clasen
3b4ad6af97 Fix the build
svn path=/trunk/; revision=19517
2008-02-12 03:48:09 +00:00
Matthias Clasen
7cc251c016 Support keynav in status icons. (#473786, Li Yuan)
2008-02-11  Matthias Clasen  <mclasen@redhat.com>

        Support keynav in status icons.  (#473786, Li Yuan)

        * gtk/gtkstatusicon.c: Handle keynav, make the tray icon focusable.

        * gtk/gtktrayicon-x11.c: Draw a focus rectangle when focused.



svn path=/trunk/; revision=19515
2008-02-12 03:24:03 +00:00
Kristian Rietveld
defa802d23 gtk/gtkcellview.c (gtk_cell_view_cell_layout_reorder) plug leak wrt. link
2008-02-11  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtkcellview.c (gtk_cell_view_cell_layout_reorder)
	* gtk/gtkiconview.c (gtk_icon_view_cell_layout_reorder): plug leak
	wrt. link deletion from list; contination of fix for #503569.


svn path=/trunk/; revision=19513
2008-02-11 15:06:57 +00:00
Emmanuele Bassi
25f92d5f1b Revert spurious commit on GtkLinkButton
svn path=/trunk/; revision=19510
2008-02-11 09:55:29 +00:00
Emmanuele Bassi
48c87e3e17 Set no-show-all flag on the placeholder menu item.
2008-02-11  Emmanuele Bassi  <ebassi@gnome.org>

	* gtk/gtkrecentchoosermenu.c:
	(gtk_recent_chooser_menu_constructor): Set no-show-all flag
	on the placeholder menu item.

	* tests/testrecentchoosermenu.c:
	(create_recent_chooser_menu): Use gtk_widget_show_all() to test
	whether the placeholder menu item gets shown.

svn path=/trunk/; revision=19509
2008-02-11 09:54:09 +00:00
Cody Russell
97e0d1120f Check the return value of _gtk_file_chooser_get_file_system () for NULL
2008-02-10  Cody Russell  <bratsche@gnome.org>

        * gtk/gtkfilechooser.c (gtk_file_chooser_get_current_folder_uri):
        Check the return value of _gtk_file_chooser_get_file_system () for
        NULL before passing it to gtk_file_system_path_to_uri ().
        (#515667, Francesco Montorsi)


svn path=/trunk/; revision=19508
2008-02-11 01:51:14 +00:00
Philip Withnall
5f12954d92 Improve the documentation for gtk_builder_connect_signals. (#514471)
2008-02-10  Philip Withnall  <pwithnall@svn.gnome.org>

	* gtk/gtkbuilder.c: Improve the documentation for
	gtk_builder_connect_signals. (#514471)


svn path=/trunk/; revision=19507
2008-02-10 06:59:52 +00:00
Matthias Clasen
5cb3c35488 Propagate local-only. (#511987, Jonh Wendell)
2008-02-10  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkrecentaction.c: Propagate local-only.  (#511987,
        Jonh Wendell)



svn path=/trunk/; revision=19503
2008-02-10 06:14:59 +00:00
Cody Russell
d7292b61f8 Removed an extra semicolon. (#515219, reported by Kazuki IWAMOTO)
2008-02-08  Cody Russell  <bratsche@gnome.org>

        * gtk/gtkcombobox.c (gtk_combo_box_cell_layout_pack_start):
        Removed an extra semicolon.  (#515219, reported by Kazuki IWAMOTO)


svn path=/trunk/; revision=19502
2008-02-09 04:03:25 +00:00
Sven Herzberg
c12d7baeca Adjust the code to match the documentation, examples, "common sense" and
2008-02-08  Sven Herzberg  <sven@imendio.com>

	Adjust the code to match the documentation, examples, "common sense"
	and existing applications.

	* gtk/gtkaction.c: (_gtk_action_sync_menu_visible): take into account
	that a GtkMenu for a <popup> element doesn't have to have a GtkAction
	assigned

svn path=/trunk/; revision=19497
2008-02-08 00:25:50 +00:00
Michael Natterer
ac6c371997 gtk/gtkcellview.c gtk/gtklabel.c gtk/gtklayout.c gtk/gtklist.c
2008-02-07  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkcellview.c
	* gtk/gtklabel.c
	* gtk/gtklayout.c
	* gtk/gtklist.c
	* gtk/gtkmenu.c
	* gtk/gtkmenushell.c
	* gtk/gtkmisc.c
	* gtk/gtkoptionmenu.c
	* gtk/gtkplug.c
	* gtk/gtkpreview.c
	* gtk/gtkprogress.c
	* gtk/gtkradiomenuitem.c
	* gtk/gtkscale.c
	* gtk/gtkscrolledwindow.c
	* gtk/gtksocket.c: remove g_return_if_fail() from private
	functions and virtual function implementations.


svn path=/trunk/; revision=19492
2008-02-07 16:59:42 +00:00
Michael Natterer
d95069aa1f gtk/gtkaction.c gtk/gtkassistant.c gtk/gtkbin.c gtk/gtkbox.c
2008-02-07  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkaction.c
	* gtk/gtkassistant.c
	* gtk/gtkbin.c
	* gtk/gtkbox.c
	* gtk/gtkcalendar.c
	* gtk/gtkcellrenderercombo.c
	* gtk/gtkcombobox.c
	* gtk/gtkcombo.c
	* gtk/gtkdrawingarea.c
	* gtk/gtkentrycompletion.c
	* gtk/gtkfixed.h
	* gtk/gtkgamma.c
	* gtk/gtkhpaned.c
	* gtk/gtkiconview.c
	* gtk/gtkitem.c
	* gtk/gtkitemfactory.c: remove g_return_if_fail() from private
	functions and virtual function implementations.


svn path=/trunk/; revision=19491
2008-02-07 15:50:39 +00:00
Michael Natterer
e7355f82c2 gtk/gtkcontainer.c gtk/gtkexpander.c gtk/gtkframe.c gtk/gtklabel.c
2008-02-06  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkcontainer.c
	* gtk/gtkexpander.c
	* gtk/gtkframe.c
	* gtk/gtklabel.c
	* gtk/gtkmain.c
	* gtk/gtkmenu.c
	* gtk/gtkmenuitem.c
	* gtk/gtkmenushell.c
	* gtk/gtknotebook.c
	* gtk/gtkseparatortoolitem.c
	* gtk/gtksocket.c
	* gtk/gtktextlayout.c
	* gtk/gtktoggletoolbutton.c
	* gtk/gtktoolbutton.c
	* gtk/gtktoolitem.c
	* gtk/gtktree.c
	* gtk/gtktreeitem.c: replace "foo && GTK_IS_FOO (foo)" by simply
	"GTK_IS_FOO (foo)".


svn path=/trunk/; revision=19481
2008-02-06 09:53:34 +00:00
Matthias Clasen
0f1958e355 Allow to store half-open ranges.
2008-02-05  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkprintsettings.c (gtk_print_settings_get_page_ranges):
        Allow to store half-open ranges.



svn path=/trunk/; revision=19479
2008-02-06 04:04:07 +00:00
Matthias Clasen
d03a5fb35c Ignore images in the toplevel theme directory, avoiding one source of
2008-02-05  Matthias Clasen  <mclasen@redhat.com>

        * gtk/updateiconcache.c: Ignore images in the toplevel theme
        directory, avoiding one source of invalid caches that has been
        spotted in the wild.



svn path=/trunk/; revision=19466
2008-02-05 22:20:12 +00:00
Matthias Clasen
d9efa71c84 Fix the build
svn path=/trunk/; revision=19465
2008-02-05 21:43:26 +00:00
Matthias Clasen
c4be17ba1b Install a printerr handler that prepends the program name, since
2008-02-05  Matthias Clasen  <mclasen@redhat.com>

        * gtk/updateiconcache.c: Install a printerr handler that
        prepends the program name, since gtk-update-icon-cache output
        often appears in the middle of other output, e.g. rpm update logs.


svn path=/trunk/; revision=19464
2008-02-05 18:35:54 +00:00
Michael Natterer
ea8ffe42aa g_return_if_fail() is the cell is not part of the combo instead of
2008-02-04  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkcombobox.c (gtk_combo_box_cell_layout_add_attribute):
	g_return_if_fail() is the cell is not part of the combo instead of
	crashing in the next line.


svn path=/trunk/; revision=19462
2008-02-04 23:01:00 +00:00
Cody Russell
9e1fbc93a2 Change queue_resize() to queue_draw(), and add a check for child2 != NULL
2008-01-31  Cody Russell  <bratsche@gnome.org>

        * gtk/gtkpaned.c (gtk_paned_set_position):
        Change queue_resize() to queue_draw(), and add a check for
        child2 != NULL in case someone calls this before there is
        a child packed in there.  (#144269 again)


svn path=/trunk/; revision=19449
2008-01-31 17:53:06 +00:00
Michael Natterer
63af2cd041 use the right type for "subparser_data" and remove the (gpointer*) cast.
2008-01-30  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkbuilderparser.c (parse_custom): use the right type for
	"subparser_data" and remove the (gpointer*) cast. Fixes bogus
	aliasing warning.

	* gtk/updateiconcache.c (add_string): cast const gchar* to
	gpointer when inserting in a GHashTable.

	* tests/testcalendar.c (calendar_detail_cb): remove const from
	return value since it's a newly allocated string.

	(calendar_update_details): free the detail.


svn path=/trunk/; revision=19431
2008-01-30 15:06:06 +00:00
Paolo Borelli
5c1a343c75 do not leak the pango layout, fixes #512375.
2008-01-28  Paolo Borelli  <pborelli@katamail.com>

	* gtk/gtkprintunixdialog.c (draw_page_cb): do not leak the pango
	layout, fixes #512375.


svn path=/trunk/; revision=19419
2008-01-28 16:06:16 +00:00
Michael Natterer
2bf99bb12e gtk/gtktextchild.c meant to use G_STRFUNC, not G_STRLOC...
2008-01-28  Michael Natterer  <mitch@imendio.com>

	* gtk/gtktextchild.c
	* gtk/gtktextview.c: meant to use G_STRFUNC, not G_STRLOC...


svn path=/trunk/; revision=19418
2008-01-28 15:16:13 +00:00
Michael Natterer
f6f6a2a4b0 gtk/gtktextchild.c use G_STRLOC instead of G_GNUC_FUNCTION (which is
2008-01-28  Michael Natterer  <mitch@imendio.com>

	* gtk/gtktextchild.c
	* gtk/gtktextview.c: use G_STRLOC instead of G_GNUC_FUNCTION (which
	is deprecated now).


svn path=/trunk/; revision=19416
2008-01-28 13:01:01 +00:00
Johan Dahlin
09648b36e2 Restore accidentally removed unsetting of GTK_MODULES.
2008-01-25  Johan Dahlin  <johan@gnome.org>

	* gtk/gtktestutils.c (gtk_test_init): Restore accidentally removed
	unsetting of GTK_MODULES.


svn path=/trunk/; revision=19406
2008-01-25 18:42:16 +00:00
Johan Dahlin
4c08143831 Handle the case where there is no child text node. (GtkBuilderConverter):
2008-01-25  Johan Dahlin  <johan@gnome.org>

	* gtk/gtk-builder-convert
	(GtkBuilderConverter._convert_adjustment): Handle the case where
	there is no child text node.
	(GtkBuilderConverter): Allow xml comments in most places.


svn path=/trunk/; revision=19405
2008-01-25 18:23:10 +00:00
Johan Dahlin
3f3425d19c Remove the items even if there are no items set.
2008-01-25  Johan Dahlin  <johan@gnome.org>

	* gtk/gtk-builder-convert
	(GtkBuilderConverter._convert_combobox_items): Remove the items
	even if there are no items set.
	(GtkBuilderConverter._add_action_from_menuitem): Convert toggled
	signals and tooltips for all menu items subclasses and 
	GtkImageMenuItem:label. 
	Makes it possible to fully convert and run Jokosher.glade.


svn path=/trunk/; revision=19404
2008-01-25 18:00:15 +00:00
Johan Dahlin
fddc9b8561 Implement accessible support, fixes #454653.
2008-01-25  Johan Dahlin  <johan@gnome.org>

        * gtk/gtkwidget.c: (gtk_widget_buildable_interface_init),
        (gtk_widget_buildable_get_internal_child), (free_action),
        (free_relation), (gtk_widget_buildable_parser_finished),
        (accessibility_start_element),
        (gtk_widget_buildable_custom_tag_start),
        (gtk_widget_buildable_custom_finished):
        Implement accessible support, fixes #454653.

        * gtk/gtk-builder-convert:
        Add support for migrating old glade files
        
        * tests/buildertest.c: (test_widget), (test_file):
        Add accessible tests and improve the test_file function to display
        toplevels and run dialogs.


svn path=/trunk/; revision=19403
2008-01-25 16:17:38 +00:00
Michael Natterer
a362eecc4a gtk/gtkbutton.h gtk/gtkcellrenderer.h gtk/gtkimcontext.h gtk/gtkstyle.h
2008-01-25  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkbutton.h
	* gtk/gtkcellrenderer.h
	* gtk/gtkimcontext.h
	* gtk/gtkstyle.h
	* gtk/gtktoolbar.h
	* gtk/gtktooltip.h
	* gtk/gtktreeprivate.h
	* gtk/gtktreeviewcolumn.h
	* gtk/gtkwidget.h: add const to constant structs which are passed
	into GTK+. Also add some forgotten const for const strings.

	* gtk/gtkbutton.c
	* gtk/gtkcellrenderer.c
	* gtk/gtkimcontext.c
	* gtk/gtkstyle.c
	* gtk/gtktoolbar.c
	* gtk/gtktooltip.c
	* gtk/gtktreeview.c
	* gtk/gtktreeviewcolumn.c
	* gtk/gtkwidget.c: changed accordingly.


svn path=/trunk/; revision=19399
2008-01-25 09:30:40 +00:00
Sven Herzberg
970a143096 Reviewed by Johan Dahlin.
2008-01-25  Sven Herzberg  <sven@imendio.com>

	Reviewed by Johan Dahlin.

	* gtk/gtkuimanager.c (gtk_ui_manager_remove_ui): emit a warning if
	this is called with something that's not a GtkUIManager


svn path=/trunk/; revision=19395
2008-01-25 00:19:18 +00:00
Johan Dahlin
3d5b7c2078 Chain up to parent, so widgets can have internal children.
2008-01-24  Johan Dahlin  <johan@gnome.org>

	* gtk/gtkdialog.c (gtk_dialog_buildable_get_internal_child): 
	Chain up to parent, so widgets can have internal children.


svn path=/trunk/; revision=19394
2008-01-24 16:38:50 +00:00
Mathias Hasselmann
ff06ea9170 Use pango_layout_set_height() for calendar details (#506049).
* configure.in: Require 1.19.3 for pango_layout_set_height().
* gtk/gtkcalendar.c: Use pango_layout_set_height() for details.

svn path=/trunk/; revision=19392
2008-01-22 15:03:03 +00:00
Johan Dahlin
6805e87247 New method (GtkBuilderConverter._create_object): Conditionally take a node
2008-01-18  Johan Dahlin  <johan@gnome.org>

	* gtk/gtk-builder-convert (get_property_node): New method
	(GtkBuilderConverter._create_object): Conditionally take a node as
	a property value, so don't lose translate/context attributes if they
	are set. 
	(GtkBuilderConverter._add_action_from_menuitem): Send in Node as
	property values instead of strings.
	(#509153, Erik van Pienbroek)


svn path=/trunk/; revision=19383
2008-01-18 16:09:26 +00:00
Mathias Hasselmann
188894d18e Change GtkCalendarDetailFunc to return newly allocated string. (#339540)
* gtk/gtkcalendar.c: Release the memory returned by the detail_func.
* gtk/gtkcalendar.h: Remove G_CONST_RETURN from GtkCalendarDetailFunc.
* tests/testcalendar.c: Duplicate calendar details before returning.

svn path=/trunk/; revision=19382
2008-01-17 16:42:04 +00:00
Christian Persch
7265ed4fc8 Store the event mask and extension event mode directly in the gobject data
* gtk/gtkwidget.c: Store the event mask and extension event mode
	directly in the gobject data pointer, instead of in an allocated
	gint. Bug #506604.

svn path=/trunk/; revision=19381
2008-01-16 19:14:49 +00:00
Matthias Clasen
9fbb25f734 Emit the notify::model signal. (#509819, David Zeuthen)
2008-01-16  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkcombobox.c (gtk_combo_box_set_model): Emit
        the notify::model signal.  (#509819, David Zeuthen)



svn path=/trunk/; revision=19374
2008-01-16 05:25:35 +00:00
Michael Natterer
7a658c1389 add cast to fix const warning.
2008-01-14  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkrc.c (_gtk_rc_style_unset_rc_property): add cast to fix
	const warning.

	(gtk_rc_parse_any): change variables to const and introduce
	another local variable to fix const warnings.


svn path=/trunk/; revision=19371
2008-01-14 17:07:03 +00:00
Michael Natterer
730c907eff fix signedness warning.
2008-01-14  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkoldeditable.c (gtk_old_editable_selection_received): fix
	signedness warning.


svn path=/trunk/; revision=19368
2008-01-14 14:22:59 +00:00
Michael Natterer
824e2c74bb remove unused variable.
2008-01-14  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkiconcache.c (find_image_offset): remove unused variable.


svn path=/trunk/; revision=19367
2008-01-14 14:19:21 +00:00
Michael Natterer
06c6c39eb3 cast "uris" to guchar* when passing it to gtk_selection_data_set().
2008-01-14  Michael Natterer  <mitch@gimp.org>

	* gtk/gtkfilesystemmodel.c (drag_source_drag_data_get): cast
	"uris" to guchar* when passing it to gtk_selection_data_set().


svn path=/trunk/; revision=19366
2008-01-14 14:17:26 +00:00
Mathias Hasselmann
7027d8fc16 Explain name choice for gtk_tool_item_toolbar_reconfigured.
* gtk/gtktoolitem.c: Add comment expaining name choice for
gtk_tool_item_toolbar_reconfigured.

svn path=/trunk/; revision=19362
2008-01-14 00:12:53 +00:00
Mathias Hasselmann
e3625b6dfb Make _gtk_tool_item_toolbar_reconfigured public to allow GtkToolShell
implementations to notify its children, when some aspect of their
configuration changed (#509042).

* gtk/gtk.symbols: Add gtk_tool_item_toolbar_reconfigured.
* gtk/gtktoolbar.c, gtk/gtktoolitem.c, gtk/gtktoolitem.h:
Rename _gtk_tool_item_toolbar_reconfigured.

svn path=/trunk/; revision=19361
2008-01-13 23:41:46 +00:00
Mathias Hasselmann
2612868618 Include <gtk/gtktoolshell.h> from gtk.h.
* gtk/gtk.h: Add gtktoolshell.h

svn path=/trunk/; revision=19356
2008-01-12 22:45:14 +00:00
Mathias Hasselmann
f5589f2e80 Print angle brackets arround e-mail addresses in the about dialog
(#409520, Mariano Suárez-Alvarez).

* gtk/gtkaboutdialog.c: Keep e-mail brackets in add_credits_page().

svn path=/trunk/; revision=19354
2008-01-12 11:10:14 +00:00
13:28:02 Tim Janik
1d0392c558 removed old testutils special casing so test widgets are always queues for
2008-01-11 13:28:02  Tim Janik  <timj@imendio.com>

        * gtk/gtktestutils.c (gtk_test_create_widget): removed old testutils
        special casing so test widgets are always queues for destruction
        during teardown.

        * gtk/tests/testing.c: removed bits left-over from testing without
        gtestutils.h.



svn path=/trunk/; revision=19352
2008-01-11 12:29:29 +00:00
Emmanuele Bassi
8b370098ca Fix possible recursion by resetting the idle source id. (#507605, William
2008-01-10  Emmanuele Bassi  <ebassi@gnome.org>

	* gtk/gtkrecentchoosermenu.c:
	(idle_populate_func), (idle_populate_clean_up): Fix possible
	recursion by resetting the idle source id. (#507605, William
	Pitcock)

svn path=/trunk/; revision=19339
2008-01-10 14:27:54 +00:00
Kristian Rietveld
c7d28a02f5 fully initialize GdkWindowAttr to avoid valgrind warnings. (#507751, patch
2008-01-10  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtktreeview.c (gtk_tree_view_motion_draw_column_motion_arrow),
	(_gtk_tree_view_column_start_drag): fully initialize GdkWindowAttr to
	avoid valgrind warnings.  (#507751, patch from Christian Persch).


svn path=/trunk/; revision=19333
2008-01-10 10:13:28 +00:00
Kristian Rietveld
496d330181 Fix a leak of the path (#504611, patch from Sadrul Habib Chowdhury).
2008-01-10  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtktreemodelfilter.c (gtk_tree_model_filter_get_path): Fix
	a leak of the path (#504611, patch from Sadrul Habib Chowdhury).


svn path=/trunk/; revision=19332
2008-01-10 09:27:40 +00:00
Kristian Rietveld
244380529a Fix #477175, reported by Juri Pakaste.
2008-01-10  Kristian Rietveld  <kris@imendio.com>

	Fix #477175, reported by Juri Pakaste.

	* gtk/gtktreeprivate.h:
	* gtk/gtktreeview.c (gtk_tree_view_top_row_to_dy): do not set
	tree_view->priv->dy here directly, just calculate the new value
	and set it on the adjustment,
	(gtk_tree_view_adjustment_changed): add guards to not call
	gtk_tree_view_dy_to_top_row() if we are currently in
	gtk_tree_view_top_row_to_dy(),
	(gtk_tree_view_put): fix coordinate annotation: these are bin_window
	coordinates, not tree coordinates,
	(gtk_tree_view_real_start_editing): add cast.

	* gtk/tests/treeview-scrolling.c: add an assertion for checking the
	position of the editable in the "create new row and start editing"
	tests.


svn path=/trunk/; revision=19331
2008-01-10 09:24:11 +00:00
Michael Natterer
9c7a2c321f remove unused variable.
2008-01-09  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkcolorsel.c (make_label_spinbutton): remove unused
	variable.

	* gtk/gtkcombobox.c (gtk_combo_box_detacher)
	* gtk/gtkicontheme.c (theme_list_contexts)
	(gtk_icon_theme_lookup_icon)
	* gtk/gtkimcontextsimple.c (beep_window)
	* gtk/gtklinkbutton.c (set_link_color)
	* gtk/gtkuimanager.c (child_hierarchy_changed_cb): add casts to
	fix warnings.

	* gtk/gtkpathbar.c (_gtk_path_bar_set_file_system): remove unused
	variable and add const to another to fix a warning.


svn path=/trunk/; revision=19330
2008-01-09 17:02:50 +00:00
Matthias Clasen
781d94f141 Be more robust when removing the current page. (#499951, Andreas Sandberg)
2008-01-07  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkassistant.c (remove_page): Be more robust when removing
        the current page.  (#499951, Andreas Sandberg)



svn path=/trunk/; revision=19321
2008-01-08 03:50:29 +00:00
Johan Dahlin
0c05c6a917 Declare value in the example code for GtkSpinButton::output, as pointed
2008-01-06  Johan Dahlin  <johan@gnome.org>

	* gtk/gtkspinbutton.c: Declare value in the example code for
	GtkSpinButton::output, as pointed out by Anders Carlsson.


svn path=/trunk/; revision=19319
2008-01-07 01:26:39 +00:00
Christian Persch
67fd8b248d Make the labels left-aligned, and remove an obsolete event box. Bug
2008-01-06  Christian Persch  <chpe@gnome.org>

	* gtk/gtkpagesetupunixdialog.c: Make the labels left-aligned,
	and remove an obsolete event box. Bug #506760.

svn path=/trunk/; revision=19318
2008-01-06 23:09:24 +00:00
Johan Dahlin
0e09e8b3ff Allow domains to be overridden in <interface>'s if a translation-domain is
2008-01-06  Johan Dahlin  <johan@gnome.org>

	* gtk/gtkbuilderparser.c (parse_interface): 
	Allow domains to be overridden in <interface>'s if a translation-domain
	is set in the builder.
	(_gtk_builder_parser_parse_buffer): Do not modify the translation-domain
	of the builder, make the domain set in the <interface> apply only to strings
	in that interface.
	(#496831, Ryan Lortie)


svn path=/trunk/; revision=19316
2008-01-06 15:17:26 +00:00
Johan Dahlin
bf4f21118a Avoid adding unnecessary trailing newlines to g_warning calls.
2008-01-06  Johan Dahlin  <johan@gnome.org>

	* gtk/gtkbuilder.c: Avoid adding unnecessary trailing newlines 
	to g_warning calls.


svn path=/trunk/; revision=19315
2008-01-06 15:06:55 +00:00
Johan Dahlin
8568de818a Remove an unused variable
* gtk/gtktreestore.c (tree_model_end_element): 
	Remove an unused variable


svn path=/trunk/; revision=19314
2008-01-06 14:58:57 +00:00
Matthias Clasen
f8c2aaf473 Document the ::output signal and add an example. (#507566, example by Owen
2008-01-06  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkspinbutton.c: Document the ::output signal and
        add an example.  (#507566, example by Owen Taylor)

svn path=/trunk/; revision=19312
2008-01-06 06:35:49 +00:00
Johan Dahlin
71e9be7e6d Use G_OBJECT_WARN_INVALID_PROPERTY_ID consistently. Fixes #5075
2008-01-06  Johan Dahlin  <johan@gnome.org>

	* gtk/gtkcellrenderercombo.c:
	(gtk_cell_renderer_combo_get_property),
	(gtk_cell_renderer_combo_set_property):
	* gtk/gtkcombobox.c: (gtk_combo_box_set_property):
	* gtk/gtkcomboboxentry.c: (gtk_combo_box_entry_set_property):
	* gtk/gtknotebook.c: (gtk_notebook_set_property):
	* gtk/gtkspinbutton.c: (gtk_spin_button_set_property):
	* gtk/gtktextbuffer.c: (gtk_text_buffer_set_property),
	(gtk_text_buffer_get_property):
	* gtk/gtktextview.c: (gtk_text_view_set_property):
	* gtk/gtktogglebutton.c: (gtk_toggle_button_set_property):
	* gtk/gtktoolbutton.c: (gtk_tool_button_set_property),
	(gtk_tool_button_get_property):
	* gtk/gtktoolitem.c: (gtk_tool_item_set_property),
	(gtk_tool_item_get_property):
	* gtk/gtktreeview.c: (gtk_tree_view_set_property):
	* gtk/gtkwidget.c: (gtk_widget_set_property):
	* gtk/gtkwindow.c: (gtk_window_set_property):
	Use G_OBJECT_WARN_INVALID_PROPERTY_ID consistently.
	Fixes #5075

svn path=/trunk/; revision=19311
2008-01-06 03:28:40 +00:00
Johan Dahlin
284af5af69 Make sure that --root works for toplevel widgets. (#491847, Phil Lello)
2008-01-06  Johan Dahlin  <johan@gnome.org>

	* gtk/gtk-builder-convert (GtkBuilderConverter._strip_root): 
	Make sure that --root works for toplevel widgets.
	(#491847, Phil Lello)


svn path=/trunk/; revision=19309
2008-01-06 02:18:38 +00:00
Mathias Hasselmann
26124bb10b Avoid some compiler warnings (#507000).
* gtk/gtkbuilder.c, gtk/gtkbuilderprivate.h: Use proper sign
for value argument of _gtk_builder_flags_from_string.
* gtk/gtkwidget.c: Don't alias the child pointer passed
to gdk_window_get_user_data.

svn path=/trunk/; revision=19306
2008-01-05 08:33:53 +00:00
Emmanuele Bassi
6f1d571c04 Use the correct comparison function (kudos to Christian Persch and Claudio
2008-01-03  Emmanuele Bassi  <ebassi@gnome.org>

	* gtk/gtkfilechooserdefault.c (recent_sort_mru): Use the
	correct comparison function (kudos to Christian Persch and
	Claudio Saavedra for spotting this)

	* gtk/gtkrecentchooserutils.c:
	(sort_recent_items_mru),
	(sort_recent_items_lru): Ditto as above.

svn path=/trunk/; revision=19302
2008-01-03 12:29:16 +00:00
Johannes Schmid
16383d431a Also reorder menu when reordering tabs by drag & drop (Bug #506474)
2007-12-30  Johannes Schmid <jhs@gnome.org>

        * gtk/gtknotebook.c: (gtk_notebook_stop_reorder):
        Also reorder menu when reordering tabs by drag & drop
        (Bug #506474)

        * tests/testnotebookdnd.c: (create_notebook_with_notebooks):
        Add a menu to one of the notebooks to have a test-case for
        the change mentioned above.


svn path=/trunk/; revision=19294
2007-12-31 16:26:18 +00:00
Philip Van Hoof
89017e8452 Using GSlice for GtkTreePath
2007-12-31  Philip Van Hoof  <pvanhoof@gnome.org>

        * gtk/gtktreemodel.c: Using GSlice for GtkTreePath


svn path=/trunk/; revision=19292
2007-12-31 11:26:55 +00:00
Christian Persch
88e5b9d26e Plug a mem leak. Bug #506107.
2007-12-31  Christian Persch  <chpe@gnome.org>

	* gtk/gtkprintunixdialog.c: (gtk_print_unix_dialog_get_property):
	Plug a mem leak. Bug #506107.

svn path=/trunk/; revision=19290
2007-12-31 00:04:32 +00:00
Matthias Clasen
4c718accf8 Adjust to icon cache api change. (#506135, Kazuki Iwamoto)
2007-12-28  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkiconfactory.c (render_fallback_image): Adjust to
        icon cache api change.  (#506135, Kazuki Iwamoto)



svn path=/trunk/; revision=19289
2007-12-29 00:14:30 +00:00
Mathias Hasselmann
5155cff8d1 Remove max_detail_height field from GtkCalendarPrivate. (#339540)
* gtk/gtkcalendar.c: Drop max_detail_height field, and use
a local variable instead in gtk_calendar_size_request.

svn path=/trunk/; revision=19286
2007-12-28 22:11:35 +00:00
Matthias Clasen
88fa693540 Make finalizer more robust
svn path=/trunk/; revision=19283
2007-12-28 19:55:37 +00:00
Mathias Hasselmann
2227e2993a Draw bottom shadow of GtkCalender headings. (#506113)
* gtk/gtkcalendar.c: Set proper initial height for priv->header_win.

svn path=/trunk/; revision=19282
2007-12-28 19:46:53 +00:00
Matthias Clasen
2c35a3f9b2 Document some initial values
svn path=/trunk/; revision=19281
2007-12-28 19:36:16 +00:00
Matthias Clasen
6bfb299f30 More default property value fixes
svn path=/trunk/; revision=19280
2007-12-28 19:20:26 +00:00
Christian Persch
b9a505b10c Plug a mem leak. Bug #506096.
2007-12-28  Christian Persch  <chpe@gnome.org>

	* gtk/gtkfontsel.c: (gtk_font_selection_get_property): Plug
	a mem leak. Bug #506096.

svn path=/trunk/; revision=19279
2007-12-28 19:18:55 +00:00
Matthias Clasen
5e30c5d986 More default property value fixes
svn path=/trunk/; revision=19278
2007-12-28 18:10:32 +00:00
Matthias Clasen
32530a9f78 More default property value fixes
svn path=/trunk/; revision=19277
2007-12-28 17:29:53 +00:00
Matthias Clasen
81b82a676f More default property value corrections
svn path=/trunk/; revision=19276
2007-12-28 17:10:33 +00:00
Matthias Clasen
98c4b12ea3 Fix a finalizer issue
svn path=/trunk/; revision=19275
2007-12-28 15:57:14 +00:00
Matthias Clasen
fb161a603f Fix default property values
svn path=/trunk/; revision=19273
2007-12-28 15:46:18 +00:00
Matthias Clasen
b78baef499 Fix default values
svn path=/trunk/; revision=19272
2007-12-28 15:43:51 +00:00
Matthias Clasen
0006024e6f Fix the default value of the curve-type property
svn path=/trunk/; revision=19271
2007-12-28 15:21:24 +00:00
Matthias Clasen
ae285834f7 Fix the default value of enable-arrows-always
svn path=/trunk/; revision=19270
2007-12-28 15:18:32 +00:00
Johan Dahlin
f3ec3ddac2 Chain up. This makes it possible to have accelerators tags on GtkDialog
2007-12-28  Johan Dahlin  <johan@gnome.org>

	* gtk/gtkdialog.c (gtk_dialog_buildable_custom_finished)
	(gtk_dialog_buildable_custom_tag_start): Chain up. 
	This makes it possible to have accelerators tags on GtkDialog 
	subclasses.


svn path=/trunk/; revision=19268
2007-12-28 10:36:07 +00:00
Mathias Hasselmann
c32421418a Add GTK_CALENDAR_SHOW_DETAILS display flag, which chooses if details are shown within the widget, or jst as tooltip.
* gtk/gtkcalendar.c, gtk/gtkcalendar.h: Add "show-details" property
aka. GTK_CALENDAR_SHOW_DETAILS, and use it.
* tests/testcalendar.c: Test GTK_CALENDAR_SHOW_DETAILS. Reduce padding
in flags vbox.

svn path=/trunk/; revision=19267
2007-12-28 09:39:34 +00:00
Mathias Hasselmann
6fda2b46a7 Try more decent appearance of calendar details separator. (#339540)
* gtk/gtkcalendar.c: Use different colors for drawing the separator,
and make it short by one pixel on each side.

svn path=/trunk/; revision=19266
2007-12-28 09:36:57 +00:00
Mathias Hasselmann
dbac73cfb1 Implement GtkTooltip API for calendar details. (#339540)
* gtk/gtkcalendar.c: Add gtk_calendar_query_tooltip and chain it up.
Remember detail overflows in calendar_paint_day to show the tooltip
only when neccessary.

svn path=/trunk/; revision=19263
2007-12-28 09:36:06 +00:00
Mathias Hasselmann
f35439bfac Without setting "detail-width-chars" and "detail-height-rows"
properties not only the widget has to be redrawn on certain
conditions, but also its size must be recalculated. (#339540)

* gtk/gtkcalendar.c: Add calendar_queue_refresh and call
that function instead of gtk_widget_queue_draw.

svn path=/trunk/; revision=19262
2007-12-28 09:26:38 +00:00
Mathias Hasselmann
d1e8ca6c4a Consider details for size-request and expose-event. (#339540)
* gtk/gtkcalendar.c: Add gtk_calendar_get_detail and
is_color_attribute functions. Change gtk_calendar_size_request
and calendar_paint_day to consider and show calender details.

svn path=/trunk/; revision=19261
2007-12-28 09:26:20 +00:00
Matthias Clasen
d52e6cd124 Introduce local priv variables to reduce ->->
2007-12-28  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkcombobox.c: Introduce local priv variables to
        reduce ->->



svn path=/trunk/; revision=19258
2007-12-28 06:56:48 +00:00
Matthias Clasen
f78277f0a3 Fix the default value of the tearoff-title property
svn path=/trunk/; revision=19257
2007-12-28 05:49:21 +00:00
Matthias Clasen
1312be0dd5 Fix the default value for the wrap-mode and font-scale properties.
2007-12-27  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkcellrenderertext.c: Fix the default value for the
        wrap-mode and font-scale properties.



svn path=/trunk/; revision=19256
2007-12-28 05:32:55 +00:00
Matthias Clasen
1a4abedf73 Fix the default value for the ratio property.
2007-12-27  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkaspectratio.c: Fix the default value for the ratio
        property.



svn path=/trunk/; revision=19255
2007-12-28 05:02:29 +00:00
Matthias Clasen
9302b1b3c7 Fix 0<>NULL confusion in gtk_signal_connect... defines. (#505708, MINAMI
2007-12-27  Matthias Clasen  <mclasen@redhat.com>

        * gkt/gtksignal.h: Fix 0<>NULL confusion in gtk_signal_connect...
        defines.  (#505708,  MINAMI Hirokazu)



svn path=/trunk/; revision=19253
2007-12-28 03:46:03 +00:00
Mathias Hasselmann
fdbf92ad90 Add infrastructure for GtkCalendar details. (#339540)
* gtk/gtkcalendar.c, gtk/gtkcalendar.h, gtk/gtk.symbols:
Add "detail-width-chars" and "detail-height-rows" properties,
and gtk_calendar_set_detail_func function.

svn path=/trunk/; revision=19251
2007-12-27 20:41:08 +00:00
Xan Lopez
b28fea94a0 Add gtk_border_new to avoid memory allocator confusions when using
2007-12-27  Xan Lopez  <xan@gnome.org>

	* gtk/gtk.symbols:
	* gtk/gtkstyle.c (gtk_border_new, gtk_border_copy):

	Add gtk_border_new to avoid memory allocator confusions when using
	GtkBorders. Also, make gtk_border_copy use g_slice_dup. (#454042)

svn path=/trunk/; revision=19248
2007-12-27 14:04:37 +00:00
Xan Lopez
89664f543d Take into account modifications of the inner frame for has_extra_children.
svn path=/trunk/; revision=19245
2007-12-26 11:32:47 +00:00
Xan Lopez
a374f81b88 We always chain to the parent size_allocate, no need to do this.
svn path=/trunk/; revision=19244
2007-12-26 11:32:16 +00:00
Matthias Clasen
3b8541a8c4 When popping up a menu from a treeview cell, use the time and button
2007-12-24  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkcombobox.c: When popping up a menu from a treeview cell,
        use the time and button information from the event.  (#504901,
        Peter Bloomfield)


svn path=/trunk/; revision=19234
2007-12-25 04:04:21 +00:00
Xan Lopez
dcbaaf2a69 pass correct argument to g_signal_emit for TEST_EXPAND_ROW (GtkTreeIter*
2007-12-23  Xan Lopez  <xan@gnome.org>

	* gtk/gtktreeview.c (gtk_tree_view_build_tree): pass correct argument
	to g_signal_emit for TEST_EXPAND_ROW (GtkTreeIter* vs. GtkTreeIter**).

	Patch by Sadrul Habib Chowdhury (#504804)

svn path=/trunk/; revision=19225
2007-12-23 01:27:06 +00:00
Johan Dahlin
05360ff15a Refactor to avoid some duplication. Convert toplevel GtkMenu's top popups
2007-12-20  Johan Dahlin  <johan@gnome.org>

	* gtk/gtk-builder-convert (GtkBuilderConverter._remove_window): 
	Refactor to avoid some duplication.
	Convert toplevel GtkMenu's top popups and not menubars in the ui manager.
	Fixes #504749, Yuri Pimenov


svn path=/trunk/; revision=19213
2007-12-20 23:44:18 +00:00
Mathias Hasselmann
2967c27e6a Avoid some compiler warnings and remove obsolete code. (#339540)
* gtk/gtkcalendar.c: Change week and year variable in
calendar_paint_week_numbers from gint to guint. Remove obsolete "#if
0" block from calendar_paint_day: The feature in question is handled
few lines above. Cast data returned by gtk_selection_data_get_text()
to (gchar*) in gtk_calendar_drag_data_received.

svn path=/trunk/; revision=19201
2007-12-19 22:57:01 +00:00
Matthias Clasen
f8a1be3a04 Add a gtk-im-module GTK setting
2007-12-17  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtksettings.c: Add a gtk-im-module GTK setting
        * gdk/win32/gdkproperty-win32.c:
        * gdk/x11/gdksettings.c: ...and back it by a Gtk/IMModule X setting.

        * gtk/gtkimmodule.[hc]:
        * gtk/gtkimmulticontext.[hc]: When determining the default context,
        look at the gtk-im-module setting, and listen for changes to the
        setting.  (#502446, Akira Tagoh)


svn path=/trunk/; revision=19195
2007-12-18 03:24:17 +00:00
Kristian Rietveld
239fd8ace2 use a weak pointer to set last_window to NULL as soon as it's destroyed.
2007-12-17  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtktooltip.c (gtk_tooltip_finalize),
	(gtk_tooltip_set_last_window): use a weak pointer to set last_window
	to NULL as soon as it's destroyed.  (#496546, patch from
	Benjamin Berg).


svn path=/trunk/; revision=19189
2007-12-17 15:33:45 +00:00
Kristian Rietveld
c3b2b3ed00 always determine what arrow to show if show_sort_indicator is true.
2007-12-17  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtktreeviewcolumn.c (gtk_tree_view_column_update_button):
	always determine what arrow to show if show_sort_indicator is true.
	(#352738, Chris Vine).


svn path=/trunk/; revision=19188
2007-12-17 13:25:43 +00:00
Mathias Hasselmann
15c571eaf3 Prevent assertion failure in gtk_paned_find_neighbours. (#503824,
Sébastien Granjoux)

* gtk/gtkpaned.c: Call gtk_container_forall instead of
gtk_container_foreach in get_child_panes.

svn path=/trunk/; revision=19186
2007-12-16 19:15:17 +00:00
Xan Lopez
447de09918 Plug leak: When reordering the info in the list the old node is removed
2007-12-15  Xan Lopez  <xan.lopez@nokia.com>

	* gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_layout_reorder):

	Plug leak: When reordering the info in the list the old node is
	removed but not freed. (#503569)

svn path=/trunk/; revision=19184
2007-12-15 11:15:19 +00:00
Ray Strode
8609315d28 Suggest g_signal_connect (..., "realize", ...) instead of
2007-12-14  Ray Strode  <rstrode@redhat.com>

	* gtk/gtkwidget.c: Suggest g_signal_connect (..., "realize", ...)
	instead of g_signal_connect_after (..., "realize", ...) as an
	alternative to gtk_widget_realize () (bug 503537).

svn path=/trunk/; revision=19181
2007-12-14 17:06:08 +00:00
Mathias Hasselmann
41c300a5c7 Correct "Since:" tags for GtkPageSetup and GtkPrintSettings as
next stable release shall be 2.16, not 2.14 - even if disagree.

* gtk/gtkpagesetup.c, gtk/gtkprintsettings.c: s/2.14/2.16/

svn path=/trunk/; revision=19179
2007-12-14 11:07:23 +00:00
Mathias Hasselmann
95adf7ee26 Change GtkToolItem to retrieve its properties from GtkToolShell interface,
instead of relying on being child of a GtkToolbar. (#5034079)

* gtk/gtk.symbols, docs/reference/gtk/gtk-docs.sgml,
docs/reference/gtk/gtk-sections.txt: Add GtkToolShell symbols.
* docs/reference/gtk/tmpl/gtktoolitem.sgml: Move section docs inline.
* gtk/gtktoolbar.c: Implement GtkToolShellIface.
* gtk/gtktoolbar.h: Remove _gtk_toolbar_rebuild_menu.
* gtk/gtktoolitem.c: Use GtkToolShell, instead of GtkToolbar.
Take section docs from template file and update them for GtkToolShell.
* gtk/Makefile.am: Add gtk/gtktoolshell.c and gtk/gtktoolshell.h.
* gtk/gtktoolshell.c, gtk/gtktoolshell.h: New GtkToolShellIface.

svn path=/trunk/; revision=19177
2007-12-14 10:57:46 +00:00
Mathias Hasselmann
ea8074a407 Extract loading of GtkPageSetup and GtkPrintSettings from their *_new_*()
functions and move that code into separate *_load_*() functions (#475565).

* gtk/gtk.symbols, gtk/gtkpagesetup.c, gtk/gtkpagesetup.h:
Extract gtk_page_setup_load_file, gtk_page_setup_load_key_file,
gtk_print_settings_load_file and gtk_print_settings_load_key_file.
Change the matching *_new_*() functions to use those functions.

svn path=/trunk/; revision=19176
2007-12-14 09:02:54 +00:00
Matthias Clasen
da057b5675 Close an api gap in tooltips
svn path=/trunk/; revision=19175
2007-12-14 05:00:51 +00:00
Kristian Rietveld
22e102081a added tests for insertion functions.
2007-12-14  Kristian Rietveld  <kris@imendio.com>

	* gtk/tests/liststore.c:
	* gtk/tests/treestore.c: added tests for insertion functions.


svn path=/trunk/; revision=19174
2007-12-14 00:52:04 +00:00
Kristian Rietveld
935d9a6574 test the move and swap functions on a store with only one node.
2007-12-13  Kristian Rietveld  <kris@imendio.com>

	* gtk/tests/liststore.c:
	* gtk/tests/treestore.c: test the move and swap functions on a
	store with only one node.


svn path=/trunk/; revision=19172
2007-12-13 16:28:12 +00:00
Kristian Rietveld
6900ad4b41 add a call to g_test_bug_base().
2007-12-13  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtktestutils.c (gtk_test_init): add a call to
	g_test_bug_base().

	* gtk/tests/treeview-scrolling.c: add g_test_bug() calls to
	appriopriate tests.


svn path=/trunk/; revision=19171
2007-12-13 14:05:04 +00:00
Kristian Rietveld
790c308fd4 start composing tests for the list and tree store.
2007-12-13  Kristian Rietveld  <kris@imendio.com>

	* gtk/tests/liststore.c:
	* gtk/tests/treestore.c: start composing tests for the list and tree
	store.

	* gtk/tests/treeview-scrolling.c: added automated tests for
	GtkTreeView's scrolling "subsystem".

	* gtk/tests/Makefile.am: updated; added new test programs.


svn path=/trunk/; revision=19170
2007-12-13 12:59:01 +00:00
Michael Natterer
64c73a61b7 Remove all .cvsignore files.
svn path=/trunk/; revision=19169
2007-12-13 11:18:45 +00:00
Mathias Hasselmann
594e3660e9 Another attempt to improve gtk_drag_dest_set docs.
* gtk/gtkdnd.c: Another attempt to improve gtk_drag_dest_set docs.

svn path=/trunk/; revision=19164
2007-12-12 09:39:36 +00:00
Mathias Hasselmann
dce782750f Mention impact of GtkDestDefaults on "drag-motion" handlers. Clearify
* gtk/gtkdnd.c, gtk/gtkwidget.c: Mention impact of GtkDestDefaults
on "drag-motion" handlers. Clearify documentation for
gtk_drag_dest_set.

svn path=/trunk/; revision=19159
2007-12-11 18:56:56 +00:00
Matthias Clasen
2a702dcd42 Another fix to avoid further fallout from the fix for bug 388321.
2007-12-10  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtknotebook.c (gtk_notebook_real_remove): Another fix
        to avoid further fallout from the fix for bug 388321.



svn path=/trunk/; revision=19139
2007-12-10 06:19:53 +00:00
Matthias Clasen
c131da48c9 Correct the documentation of child property getter arguments. (#501992,
2007-12-07  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkcontainer.c: Correct the documentation of child
        property getter arguments.  (#501992, David Brigada)



svn path=/trunk/; revision=19130
2007-12-07 19:06:03 +00:00
Matthias Clasen
dcc86ce57c Don't leak pixbufs. (#502250, Yevgen Muntyan)
2007-12-07  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkfilechooserdefault.c (shortcuts_reload_icons): Don't
        leak pixbufs.  (#502250, Yevgen Muntyan)


svn path=/trunk/; revision=19128
2007-12-07 18:51:25 +00:00
Yevgen Muntyan
6003bcbd96 added alternative button order in Print and Page Setup dialogs.
2007-12-07  Yevgen Muntyan  <muntyan@tamu.edu>

	* gtk/gtkprintunixdialog.c:
	* gtk/gtkpagesetupunixdialog.c: added alternative button order in
	Print and Page Setup dialogs.


svn path=/trunk/; revision=19126
2007-12-07 18:05:42 +00:00
Tommi Komulainen
62315bd5d0 Remove trailing whitespace that can trigger false positives in abicheck.sh
2007-12-06  Tommi Komulainen  <tommi.komulainen@iki.fi>

	* gdk-pixbuf/gdk-pixbuf.symbols:
	* gdk/gdk.symbols:
	* gdk/gtk.symbols: Remove trailing whitespace that can trigger false
	positives in abicheck.sh

svn path=/trunk/; revision=19124
2007-12-06 20:14:17 +00:00
18:59:59 Tim Janik
9ba5da2f36 run tests in current dir after setting up the logging directory, so their
2007-12-05 18:59:59  Tim Janik  <timj@imendio.com>

        * gtk+/Makefile.decl: run tests in current dir after setting up the
        logging directory, so their results get properly merged into the
        resulting test log.

        * gtk+/gtk/gtktestutils.[hc]: added gtk_test_list_all_types() for
        tests to loop over registered Gdk/Gtk+ types.

        * gtk+/tests/objecttests.c: new test program, implements automated
        property tests. several properties are blacklisted because they
        seem to trigger Gdk/Gtk+ bugs. ./objecttests -m thorough --verbose
        can be used to test blacklisted properties and see which proprty failed.



svn path=/trunk/; revision=19115
2007-12-05 16:58:44 +00:00
Matthias Clasen
2b3c7b70ef Modify the tab-label-destroy fix to not crash epiphany.
2007-12-04  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtknotebook.c: Modify the tab-label-destroy fix to not
        crash epiphany.


svn path=/trunk/; revision=19107
2007-12-04 18:43:47 +00:00
Richard Hult
f411b93ca3 Don't crash when dragging from a source that doesn't support uri lists
2007-12-03  Richard Hult  <richard@imendio.com>

	* gtk/gtkquartz.c: (_gtk_quartz_set_selection_data_for_pasteboard):
	Don't crash when dragging from a source that doesn't support uri
	lists (bug #499868, Paul Davis).

svn path=/trunk/; revision=19102
2007-12-03 19:51:20 +00:00
Matthias Clasen
f9e4618bda Two optimizations for icon cache lookups.
2007-12-03  Matthias Clasen  <mclasen@redhat.com>

        Two optimizations for icon cache lookups.

        * gtk/gtkiconcache.[hc]:
        * gtk/gtkicontheme.c: Remember the directory index for
        subdirectories, instead of running over the directory list
        again and again.

        * gtk/gtkiconcache.c (find_image_offset): Remember the last
        chain and try it first; this helps with the the usage patterns
        in gtkicontheme.c, where the same icon is queried for a lot
        of subdirectories.


svn path=/trunk/; revision=19099
2007-12-03 17:44:27 +00:00