Matthias Clasen
80de4ab0d9
Another property formatting fix
2009-11-01 18:53:51 -05:00
Matthias Clasen
0a9a1bec93
Work around a gtk-doc formatting problem
2009-11-01 16:41:48 -05:00
Matthias Clasen
097b254e4b
Documentation and stylistic fixups
2009-11-01 16:12:43 -05:00
Javier Jardón
550796d897
Fix some compilation warnings
...
Use proper gint8 array variable instead a string
2009-10-30 18:36:03 +01:00
Javier Jardón
8763551b6b
Fix warning: cast to gint*
2009-10-30 18:34:35 +01:00
Javier Jardón
3388a1b146
Use "Since: 2.x" instead "Since 2.x"
2009-10-30 18:11:44 +01:00
Javier Jardón
0a9843c1b9
Fix warning: some casts to gchar*
2009-10-30 04:27:32 +01:00
Javier Jardón
07236ee745
Remove statement with no effect
2009-10-30 04:19:10 +01:00
Javier Jardón
cbba733b47
Fix warning: cast to gchar*
2009-10-30 04:17:29 +01:00
Matthias Clasen
0f78a6c89a
Allow setting type hints on unmapped windows
...
We set the hint on map, so it makes sense to check for GTK_WIDGET_MAPPED,
not GTK_WIDGET_VISIBLE as the code currently does.
2009-10-28 12:13:58 -04:00
Johannes Schmid
ed41fa8b50
Fixed GtkToolPalette API docs to mention 2.20 instead of 2.18
2009-10-28 13:17:13 +01:00
Johannes Schmid
e83013c066
Fix custom label handling in gtktoolitemgroup
2009-10-28 13:11:37 +01:00
Johannes Schmid
c229306a18
Merge branch 'master' into toolpalette
2009-10-28 10:57:46 +01:00
Yevgen Muntyan
4ff709c24b
Use standard mac shortcuts: add gtk/gtkrc.key.mac
...
This completes commit 3c510f028f
https://bugzilla.gnome.org/show_bug.cgi?id=530351
2009-10-28 00:54:28 +01:00
Christian Dywan
da8dde446d
Deprecate functions according to deprecated GtkButton signals
...
https://bugzilla.gnome.org/show_bug.cgi?id=599218
2009-10-27 22:42:25 +01:00
Christian Dywan
6271cb9672
Don't use deprecated button signal functions in clist and combo
2009-10-27 22:42:24 +01:00
Christian Dywan
4f0b0d0775
Don't use structure fields of GtkAccelMap in GtkSocket
...
https://bugzilla.gnome.org/show_bug.cgi?id=599403
2009-10-27 21:27:28 +01:00
Christian Dywan
f4d5ed5397
Allow removing all closures with gtk_accel_group_disconnect
...
https://bugzilla.gnome.org/show_bug.cgi?id=599403
2009-10-27 21:25:56 +01:00
Marek Kasik
33ec0ecf05
Don't assign a GtkPageOrientation to a boolean value
...
GtkPrintOperationPrivate->orientation is a boolean value.
2009-10-27 17:35:37 +01:00
Adrian Johnson
9f2c5e3b3a
Take printer margins into account on Windows
...
Fixes bug #381371 .
2009-10-27 12:30:50 +02:00
Christian Dywan
57af1cdb8c
Only set the accesible label if it is non-empty
...
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=599446
2009-10-27 00:34:49 +01:00
Javier Jardón
d0f2cd73b0
Use G_STRLOC instead __FILE__ and __LINE__
2009-10-27 00:21:51 +01:00
Nick Schermer
92a68f4cf9
gtk_init_with_args() arguments should be const gchar*
...
The translation_domain argument should be const gchar * to allow compilation
with -Wwrite-strings. It only passes the argument to
g_option_context_add_main_entries() which is already const gchar*.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=583305
2009-10-26 22:29:33 +01:00
Javier Jardón
12061507b4
Use G_STRFUNC and G_STRLOC instead __FUNCTION__ and __FILE__
2009-10-26 18:46:19 +01:00
Javier Jardón
42aebf51a2
Use G_STRFUNC instead __FUNCTION__
2009-10-26 18:46:14 +01:00
Marek Kasik
6b5912a213
Show correct print preview
...
Modify print preview according to settings from print dialog.
Similar approach as during real print is applied to the preview
process (#592582 ).
2009-10-26 17:47:37 +01:00
Matthias Clasen
d3e6cffff7
Fix issues with symbolic colors in rc file parsing
...
Don't recreate the settings color hash every time, repopulate it
instead. This avoids invalidating the references held by RcContexts.
2009-10-25 23:47:59 -04:00
Matthias Clasen
16482f20db
Fixes for the compose-parse.py script
...
Several fixes by Ray Strode and Peter Hutterer to make compose-parse.py
work with the current X.org Compose file.
2009-10-25 23:46:27 -04:00
Matthias Clasen
4c26d99d3e
Update compose sequences
...
This patch includes additions to the X.org Compose file from the
last year. Patch by Peter Hutterer
2009-10-25 23:42:58 -04:00
Yevgen Muntyan
3c510f028f
Use standard mac shortcuts
...
This changes Ctrl-X, Ctrl-C, etc. to Cmd-X, Cmd-C, etc. Also,
Alt-Left and Alt-Right in text widgets bound to Ctrl-Left and
Ctrl-Right actions
https://bugzilla.gnome.org/show_bug.cgi?id=530351
2009-10-26 00:03:05 +01:00
Matthew Barnes
13d968adbe
Bug 581150 - GtkIconView tries to paint items with invalid sizes
...
Run gtk_icon_view_layout() if necessary before attempting to paint the
icon view items during an expose event. This ensures all the items have
valid sizes, as some themes don't take kindly to negative dimensions.
2009-10-23 19:32:25 -04:00
Luca Ferretti
af6f5c1349
Add translators comments for tab labels (closes 599118)
2009-10-21 22:06:31 +02:00
Michael Natterer
34b4b4d9c3
Add single-include guard and reduce includes to what's needed
2009-10-21 20:21:20 +02:00
Michael Natterer
8c34831e42
Don't allow to include this new header individually
2009-10-21 20:20:54 +02:00
Javier Jardón
c43a3acac3
Fix a compilation warning: use NULL instead ""
2009-10-21 19:41:50 +02:00
Javier Jardón
d020cb4aa3
Remove unused function
2009-10-21 19:39:46 +02:00
Federico Mena Quintero
48f1b89eae
bgo#563010 - Fix clearing the selection in GtkFileChooserButton
...
Previously the filename would get re-set on the button if one cleared the selection,
as an async cancellable was not getting canceled in that case.
Signed-off-by: Federico Mena Quintero <federico@novell.com>
2009-10-21 12:29:03 -05:00
Cody Russell
0f33ad4ee1
Added editing_canceled property to GtkCellEditable
...
GTK_ENTRY()->editing_canceled should really have been a parameter of the
GtkCellEditable::editing-done signal, it should be a property on the cell
editable interface
https://bugzilla.gnome.org/show_bug.cgi?id=594962
2009-10-21 18:55:24 +02:00
Christian Dywan
272e0b5b76
Deprecated GtkNotebook tab packing
...
https://bugzilla.gnome.org/show_bug.cgi?id=596083
2009-10-21 18:25:02 +02:00
Christian Dywan
7c6823373a
Deprecate GtkCurve and GtkGammaCurve
...
https://bugzilla.gnome.org/show_bug.cgi?id=556263
2009-10-21 18:17:32 +02:00
Christian Dywan
f5df4e05e2
Added accesor for GTK_VIEWPORT (widget)->bin_window
...
Although, you can use:
gtk_widget_get_parent_window (gtk_bin_get_child (GTK_BIN (widget)))
there already are gtk_tree_view_get_bin_window() and
gtk_layout_get_bin_window() in GTK+ api.
https://bugzilla.gnome.org/show_bug.cgi?id=594960
2009-10-21 18:14:31 +02:00
Javier Jardón
6f6746389c
Fix a compilation warning
...
Use switch instead if's to get a default value
2009-10-21 02:57:19 +02:00
Javier Jardón
69773763ee
Fix a compilation warning
...
Reorder the function so the "lookup_context" variable can't be
used uninitialized
2009-10-21 02:45:05 +02:00
Javier Jardón
13ff557587
Fix some compilation warning
...
Complete the previous patch: set lower to 0 too
2009-10-21 02:37:05 +02:00
Javier Jardón
670e141b3a
Fix some compilation warning
...
Added some default cases and assert if reached
2009-10-21 02:08:18 +02:00
Javier Jardón
d3155bb1ea
Remove some unnused variables
2009-10-20 20:37:46 +02:00
Marek Kasik
cf8c4a6a80
A small correction of previous commit
...
Correct of a typo.
2009-10-19 11:44:09 +02:00
Matthias Clasen
52ef2f2a3e
Correct a small oversight
...
When changing themes, we also need to update the box spacing of
tooltips.
2009-10-18 20:38:28 -04:00
Matthias Clasen
9f11bb0ff6
Don't omit GTK_ICON_SIZE_DIALOG
2009-10-18 02:07:58 -04:00
Matthias Clasen
1dbfcf484b
Fix a problem in GtkImage size allocation
...
When GtkMisc padding is set on an image, the optimization for only
recalculating size after a clear() breaks, since the requisition is
not (0, 0). We need a separate 'need_calc' flag.
2009-10-18 01:38:44 -04:00
Christian Dywan
8e6dbff2b0
Deprecate GtkInputDialog
...
Deprecate the widget and adjust the documentation.
https://bugzilla.gnome.org/show_bug.cgi?id=594903
2009-10-16 16:05:13 +02:00
Tor Lillqvist
6d62e4fafe
Fix build on Windows
2009-10-16 13:29:54 +03:00
Debarshi Ray
34f6b9518c
Use G_BEGIN/END_DECLS in gtkcellrendererspinner.h
2009-10-16 00:22:20 +03:00
Federico Mena Quintero
f0e2d7d88b
Fix thinkos in which fields get used
...
Signed-off-by: Federico Mena Quintero <federico@novell.com>
2009-10-15 22:06:20 +02:00
Federico Mena Quintero
02d96465f4
Oops, it's gsize, not GSize
...
Signed-off-by: Federico Mena Quintero <federico@novell.com>
2009-10-15 22:06:19 +02:00
Federico Mena Quintero
1d283145bf
Fix a g_strdup_printf()
...
Signed-off-by: Federico Mena Quintero <federico@novell.com>
2009-10-15 22:06:19 +02:00
Federico Mena Quintero
c39e8af7f4
Put the list of column types in a macro
...
Every call to _gtk_file_system_model_new*() gets the same list of column types,
so we now keep the list in a macro instead of having duplicated copies all around.
Signed-off-by: Federico Mena Quintero <federico@novell.com>
2009-10-15 22:06:19 +02:00
Federico Mena Quintero
4c242317b0
Clarify the arguments of g_file_query_info_async()
...
Signed-off-by: Federico Mena Quintero <federico@novell.com>
2009-10-15 22:06:19 +02:00
Federico Mena Quintero
2f3367fbf8
Make copy_attribute() a function instead of a macro
...
Signed-off-by: Federico Mena Quintero <federico@novell.com>
2009-10-15 22:06:19 +02:00
Federico Mena Quintero
442484a280
Don't leak a treepath if the treeview is not populated yet
...
Signed-off-by: Federico Mena Quintero <federico@novell.com>
2009-10-15 22:06:18 +02:00
Federico Mena Quintero
35028b9f05
Factor out function to set a fixed size for the icon cell renderers
...
Signed-off-by: Federico Mena Quintero <federico@novell.com>
2009-10-15 22:06:18 +02:00
Federico Mena Quintero
90647c1a13
Comment that the column order needs to be kept in sync across two functions
...
Signed-off-by: Federico Mena Quintero <federico@novell.com>
2009-10-15 22:06:18 +02:00
Federico Mena Quintero
0144521438
Fix typo in a comment
...
Signed-off-by: Federico Mena Quintero <federico@novell.com>
2009-10-15 22:06:18 +02:00
Federico Mena Quintero
6e3a6ba12f
Make get_selected_file() return a ref'ed file
...
The old semantics was to return a GFile* owned by the file system model; the new
semantics is to hand out new references whenever possible.
Signed-off-by: Federico Mena Quintero <federico@novell.com>
2009-10-15 22:06:18 +02:00
Federico Mena Quintero
7e9fbd16e4
In set_filter(), handle the case where the new filter is the same as the old filter
...
Signed-off-by: Federico Mena Quintero <federico@novell.com>
2009-10-15 22:06:17 +02:00
Federico Mena Quintero
fb1a72fcb0
s/get_is_visible/iter_is_visible for clarity
...
Signed-off-by: Federico Mena Quintero <federico@novell.com>
2009-10-15 22:06:17 +02:00
Federico Mena Quintero
9efa64fba5
Remove obsolete comment
...
Signed-off-by: Federico Mena Quintero <federico@novell.com>
2009-10-15 22:06:17 +02:00
Federico Mena Quintero
55a04b1da0
Make the code match the docs in _gtk_file_system_model_clear_cache()
...
Signed-off-by: Federico Mena Quintero <federico@novell.com>
2009-10-15 22:06:17 +02:00
Federico Mena Quintero
112d2430be
Free some missing fields in ::finalize()
...
Signed-off-by: Federico Mena Quintero <federico@novell.com>
2009-10-15 22:06:17 +02:00
Federico Mena Quintero
5ea265ca61
Clarify variable names in gtk_file_system_model_sort()
...
To comply with the i -> indexes; r -> rows convention.
Signed-off-by: Federico Mena Quintero <federico@novell.com>
2009-10-15 22:06:17 +02:00
Federico Mena Quintero
7ecc87ed59
Nothing to do for ref/unref_node
...
Signed-off-by: Federico Mena Quintero <federico@novell.com>
2009-10-15 22:06:17 +02:00
Federico Mena Quintero
8bf24cdd9d
Clarify a couple of spots with comments
...
Signed-off-by: Federico Mena Quintero <federico@novell.com>
2009-10-15 22:06:16 +02:00
Federico Mena Quintero
14cc3e17f5
Clarify array indexes vs. row numbers
...
There was some confusion between "index" as used for the model->files[] array,
and node->index as used for our 1-based row numbers. Now we use "index" only
for indices in the model->files[] array, and node->row for row numbers. Functions
and variables are renamed to clarify whether they refer to indexes or rows.
Signed-off-by: Federico Mena Quintero <federico@novell.com>
2009-10-15 22:06:16 +02:00
Federico Mena Quintero
d0468ee7e1
Big comment on how GtkFileSystemModel works
...
Let's have some documentation on the idea behind this beast...
Signed-off-by: Federico Mena Quintero <federico@novell.com>
2009-10-15 22:06:16 +02:00
Federico Mena Quintero
04c78019fb
Remove obsolete code to use a cached mime-type
...
The non-standard "filechooser::mime-type" was a remnant of the recent-files code using
a hand-built GFileInfo; now we just query the file info ourselves.
Signed-off-by: Federico Mena Quintero <federico@novell.com>
2009-10-15 22:06:16 +02:00
Federico Mena Quintero
6166fccf30
Fix thinko in node_should_be_visible()
...
Signed-off-by: Federico Mena Quintero <federico@novell.com>
2009-10-15 22:06:16 +02:00
Federico Mena Quintero
908911d6db
Factory out functions to emit row_inserted, row_changed, row_deleted
...
This is to avoid temporary variables for the path/iter and to avoid duplicated code.
Signed-off-by: Federico Mena Quintero <federico@novell.com>
2009-10-15 22:06:16 +02:00
Federico Mena Quintero
ad2e6ff52c
When updating a file, handle the case where the old file info is the same as the new one
...
This prevents us from inadvertently losing the last ref to the info.
Signed-off-by: Federico Mena Quintero <federico@novell.com>
2009-10-15 22:06:16 +02:00
Federico Mena Quintero
688917cdbb
When removing a file, also remove it from the file_lookup hash table
...
Signed-off-by: Federico Mena Quintero <federico@novell.com>
2009-10-15 22:06:15 +02:00
Federico Mena Quintero
385fa71ec0
Comment on how the file_lookup hash table gets rebuilt on demand
...
Signed-off-by: Federico Mena Quintero <federico@novell.com>
2009-10-15 22:06:15 +02:00
Federico Mena Quintero
6820dee988
Clarify the arguments to g_file_query_info_async()
...
Signed-off-by: Federico Mena Quintero <federico@novell.com>
2009-10-15 22:06:15 +02:00
Federico Mena Quintero
ccee7ef4fb
Show an error dialog when we can't read the folder's contents
...
Signed-off-by: Federico Mena Quintero <federico@novell.com>
2009-10-15 22:06:15 +02:00
Federico Mena Quintero
3b86973075
Clarify the code flow in gtk_file_system_model_got_files()
...
Signed-off-by: Federico Mena Quintero <federico@novell.com>
2009-10-15 22:06:15 +02:00
Federico Mena Quintero
3f7c144605
Remove the dir_thaw_source while disposing the model
...
Otherwise that timeout may trigger after the model has died.
Signed-off-by: Federico Mena Quintero <federico@novell.com>
2009-10-15 22:06:15 +02:00
Federico Mena Quintero
30016185be
Make _gtk_file_system_model_remove_file() static
...
It was only used internally by the model.
Signed-off-by: Federico Mena Quintero <federico@novell.com>
2009-10-15 22:06:14 +02:00
Federico Mena Quintero
2e0382cf02
Make _gtk_file_system_model_add_file() static
...
It was only used internally by the model, anyway.
Signed-off-by: Federico Mena Quintero <federico@novell.com>
2009-10-15 22:06:14 +02:00
Federico Mena Quintero
93588c6d5c
Clarify the comments that some fields in GtkFileSystemModel can be NULL
...
Signed-off-by: Federico Mena Quintero <federico@novell.com>
2009-10-15 22:06:14 +02:00
Federico Mena Quintero
88bb9342ab
Clarify the arguments to g_file_monitor_directory()
...
Signed-off-by: Federico Mena Quintero <federico@novell.com>
2009-10-15 22:06:14 +02:00
Federico Mena Quintero
d2d997a021
Clarify an argument to g_file_enumerate_children_async()
...
Signed-off-by: Federico Mena Quintero <federico@novell.com>
2009-10-15 22:06:14 +02:00
Federico Mena Quintero
d5d9601852
Fix and tighten an assertion
...
Signed-off-by: Federico Mena Quintero <federico@novell.com>
2009-10-15 22:06:14 +02:00
Federico Mena Quintero
86c32c2502
Complete the documentation string for _gtk_file_system_model_new()
...
Signed-off-by: Federico Mena Quintero <federico@novell.com>
2009-10-15 22:06:14 +02:00
Federico Mena Quintero
3232c469fc
Start with a file array with a resonable preallocated size
...
g_array_new() doesn't reserve any size by default, so during the initial population
of the file array, we'll do more reallocs than strictly needed. We'll start with
a reasonable preallocated size, in this case the number of files which we can
get in a single chunk out of GIO.
Signed-off-by: Federico Mena Quintero <federico@novell.com>
2009-10-15 22:06:13 +02:00
Federico Mena Quintero
5110415684
Compute the node size only once to avoid the scary macro
...
Signed-off-by: Federico Mena Quintero <federico@novell.com>
2009-10-15 22:06:13 +02:00
Federico Mena Quintero
dfe20ea1a8
g_error() as soon as we catch an invalid column type
...
There's no point in running a GtkFileSystemModel with invalid column types.
This way we can also avoid clearing the memory of the column_types array.
Signed-off-by: Federico Mena Quintero <federico@novell.com>
2009-10-15 22:06:13 +02:00
Benjamin Otte
836c3ab043
Improve show_and_select_files() function
...
The previous function enumerated the whole directory and used a lot of
outdated API to decide how to show files.
The new code queries the filesystem model to decide about this.
The now unused old functions were removed.
2009-10-15 22:01:40 +02:00
Benjamin Otte
6bdaaea3a4
Remove unused error argument from show_and_select_files()
2009-10-15 22:01:40 +02:00
Benjamin Otte
682a3c8c75
Enable the size column in recent files/search
...
Previously information about file sizes was not available for search
results and recent files, so the column was always hidden. As this
information is now available, we can stop the special handling and use
the same setting as in browse mode.
2009-10-15 22:01:40 +02:00
Benjamin Otte
d68bca1771
Use the faster accessor function in the sort functions
...
Use the faster _gtk_file_system_model_get_value() function instead of
gtk_tree_model_get() inside the sort functions. This gives a significant
speed-up when sorting large lists.
In a test case with 40.000 files, the sorting time went from ~5 seconds
to less than 0.5 seconds for my test case. There is 2 significant
problems with gtk_tree_model_get() that cause this:
1) The value is copied, which takes quite a bit of time for strings.
~25% of excessive time or ~1 second in my test
2) The tree model functions need to lookup the interface vfunc. And
gtk_tree_model_get() doesn't do that only once, but multiple times
(verifying column id, getting the actual value, ...)
~75% of excessive time or ~3 seconds in my test
2009-10-15 22:01:39 +02:00
Benjamin Otte
53a00e3cc3
Convert recent files to a GtkFileSystemModel
...
This does to the recent files what the last commit did to the search. It
uses a GtkFileSystemModel and its API niceties to show the recent files.
2009-10-15 22:01:39 +02:00
Benjamin Otte
5a31dfd66b
Convert search to use a GtkFileSystemModel
...
Replace the list model code with the file system model and use all the
file system model API niceties we get from that.
Also adds the function _gtk_file_system_model_add_and_query_file() which
g_file_query_info()'s the file before adding it, so it gets added with
the right information.
2009-10-15 22:01:09 +02:00